From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B32DCA00BE; Tue, 28 Apr 2020 17:01:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69CDD1D5F2; Tue, 28 Apr 2020 17:01:48 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id C1DA41D5D0 for ; Tue, 28 Apr 2020 17:01:46 +0200 (CEST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03SEq2xu014750 for ; Tue, 28 Apr 2020 11:01:45 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 30mhr6yxgm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 28 Apr 2020 11:01:45 -0400 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 03SEqBL8015562 for ; Tue, 28 Apr 2020 11:01:45 -0400 Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 30mhr6yxfn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Apr 2020 11:01:45 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 03SEtNDg025043; Tue, 28 Apr 2020 15:01:44 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma03wdc.us.ibm.com with ESMTP id 30mcu6cutx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Apr 2020 15:01:44 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 03SF1hO354722934 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Apr 2020 15:01:43 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2689AE063; Tue, 28 Apr 2020 15:01:43 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EEA68AE064; Tue, 28 Apr 2020 15:01:41 +0000 (GMT) Received: from [9.81.197.60] (unknown [9.81.197.60]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 28 Apr 2020 15:01:41 +0000 (GMT) To: Jerin Jacob Cc: dpdk-dev , David Christensen References: <20200427215849.116064-1-thinhtr@linux.vnet.ibm.com> From: Thinh Tran Message-ID: Date: Tue, 28 Apr 2020 10:01:39 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-28_10:2020-04-28, 2020-04-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004280112 Subject: Re: [dpdk-dev] [PATCH] rte_trace: fix build on PPC64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Agreed, this is not rte_trace issue. Moving to rte_common.h does not work neither, because altivec.h is included after and redefine bool This conflict happens on PPC64, I'll create a different patch. Thanks, Thinh Tran On 4/28/2020 2:57 AM, Jerin Jacob wrote: > On Tue, Apr 28, 2020 at 3:29 AM Thinh Tran wrote: >> >> The AltiVec header file breaks boolean type: >> >> In file included from ../lib/librte_mempool/rte_mempool_trace_fp.h:18:0, >> from ../lib/librte_mempool/rte_mempool.h:54, >> from ../lib/librte_mbuf/rte_mbuf.h:38, >> from ../lib/librte_net/rte_ether.h:23, >> from ../drivers/common/mlx5/mlx5_nl.h:10, >> from ../drivers/common/mlx5/mlx5_nl.c:23: >> ../lib/librte_eal/include/rte_trace_point.h: In function >> ‘__rte_trace_point_fp_is_enabled’: >> ../lib/librte_eal/include/rte_trace_point.h:226:9: error: incompatible >> types when returning type ‘int’ but ‘__vector __bool int {aka >> __vector(4) __bool int}’ was expected >> return false; >> >> This is the same as >> https://git.dpdk.org/dpdk/commit/?id=725f5dd >> >> and yet, there is no better solution for it >> >> Signed-off-by: Thinh Tran >> --- >> lib/librte_eal/include/rte_trace_point.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/lib/librte_eal/include/rte_trace_point.h b/lib/librte_eal/include/rte_trace_point.h >> index 4d956ec16..2ede9e3ba 100644 >> --- a/lib/librte_eal/include/rte_trace_point.h >> +++ b/lib/librte_eal/include/rte_trace_point.h >> @@ -26,6 +26,12 @@ extern "C" { >> #include >> #include >> >> +#if defined(__PPC64__) && !defined(__APPLE_ALTIVEC__) >> +#undef bool >> +/* redefine as in stdbool.h */ >> +#define bool _Bool >> +#endif > > NACK. > > Please move the fix to rte_common.h or similar as it not specific to trace. > if you do so, the following hack also not need. > https://git.dpdk.org/dpdk/commit/?id=725f5dd > >> + >> /** The tracepoint object. */ >> typedef uint64_t rte_trace_point_t; >> >> -- >> 2.17.1 >>