From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA9244404F; Wed, 12 Jun 2024 17:22:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC6E84324F; Wed, 12 Jun 2024 17:06:39 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id E553D43007 for ; Wed, 12 Jun 2024 17:06:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718204797; x=1749740797; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DlVqkAMlqMzZ5BGpOjMveSXvKjRYJFh24aarflHXJjY=; b=b2GNm3bAh8nEXewzBM7e3Z41YaAE5b14Z+DePFankjpbddynsvhIYQGg hNU8BSEtbiUButcQO08ce6JHdrnzuHIjwgWow4EU2b/ILJk0qkCItGVYT lrLY/pWqkYd/9Khj3IAjn9AhY32tSTKH0LBFFrNaoumOwHcdCMiORnOJZ Cdp641u8TbZMU3ugwfLNX+QgGpRnsW7Ea6fei5reODBEYycXp1vGVevH1 4MRyu6Wwv9yjZcK/JEEo3bdNIAYRrgYR+j0jeQdOIGiGB7RctDfBYPjB/ cESMM1MYvBLMWp21vyfqNeHvZmwamCMmS7CvOyyGvz837KN222Cx+vLS7 A==; X-CSE-ConnectionGUID: Px72Sx23Qh2/BsYR2IqWoQ== X-CSE-MsgGUID: LhBLb7p/Q0aeHPhGuRtffA== X-IronPort-AV: E=McAfee;i="6700,10204,11101"; a="32460018" X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="32460018" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2024 08:06:37 -0700 X-CSE-ConnectionGUID: ewdIQzshTAGJbfMMRphVdw== X-CSE-MsgGUID: 3up/Qp/JTQms4PiLZ6vjVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,233,1712646000"; d="scan'208";a="39925909" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 12 Jun 2024 08:06:36 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: ian.stokes@intel.com, bruce.richardson@intel.com, Dan Nowlin Subject: [PATCH v2 119/148] net/ice/base: support E830 in Topology AQ command Date: Wed, 12 Jun 2024 16:01:53 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20240430154014.1026-1-ian.stokes@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In E830, regarding the Get Tx Topology AQ command, there is a change in the way that the RD bit must be set. For E830, the RD bit must be cleared. Setting the RD bit for the E830 device was causing the Get Tx Topology command to fail. Fix it to clear RD bit for E830 device. Signed-off-by: Dan Nowlin Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ddp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c index 798abb41c4..af843f4e08 100644 --- a/drivers/net/ice/base/ice_ddp.c +++ b/drivers/net/ice/base/ice_ddp.c @@ -2301,11 +2301,16 @@ ice_get_set_tx_topo(struct ice_hw *hw, u8 *buf, u16 buf_size, if (buf) cmd->set_flags |= ICE_AQC_TX_TOPO_FLAGS_SRC_RAM | ICE_AQC_TX_TOPO_FLAGS_LOAD_NEW; + + desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); } else { ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_get_tx_topo); cmd->get_flags = ICE_AQC_TX_TOPO_GET_RAM; + + if (!ice_is_e830(hw)) + desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); } - desc.flags |= CPU_TO_LE16(ICE_AQ_FLAG_RD); + status = ice_aq_send_cmd(hw, &desc, buf, buf_size, cd); if (status) return status; -- 2.43.0