Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

[David Hunt <david.hunt@intel.com>]

Hi Anatoly,

On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> When .get_monitor_addr API was introduced, it was implemented in the
> i40e driver, but only for the physical function; the virtual function
> portion of the driver does not support that API.
>
> Add the missing function pointer to VF device structure.
>
> The i40e driver is not meant to use the VF portion any more, as
> currently i40e VF devices are supposed to be managed by iavf drier, but
> add this just in case it needs backporting later.
>
> Fixes: a683abf90a22 ("net/i40e: implement power management API")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   drivers/net/i40e/i40e_ethdev_vf.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index 3c258ba7cf..156ad9ab96 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -216,6 +216,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {
>   	.mtu_set              = i40evf_dev_mtu_set,
>   	.mac_addr_set         = i40evf_set_default_mac_addr,
>   	.tx_done_cleanup      = i40e_tx_done_cleanup,
> +	.get_monitor_addr     = i40e_get_monitor_addr
>   };
>   
>   /*


Same issue as the ixgbe, get_monitor_addr op missing for the vf portion 
of the driver. Thanks.

Reviewed-by: David Hunt <david.hunt@intel.com>