From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id E82E14C92 for ; Fri, 30 Mar 2018 16:17:58 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3B1B24023150; Fri, 30 Mar 2018 14:17:58 +0000 (UTC) Received: from [10.36.112.32] (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4112B215CDC6; Fri, 30 Mar 2018 14:17:55 +0000 (UTC) To: Tonghao Zhang , Ferruh Yigit Cc: Andrew Rybchenko , "dev@dpdk.org" , Thomas Monjalon References: <93d00a28-d52d-25b3-42d0-84b1d95c756a@redhat.com> <98626f3d-c959-37d2-c238-6babc6272745@intel.com> From: Maxime Coquelin Message-ID: Date: Fri, 30 Mar 2018 16:17:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 30 Mar 2018 14:17:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 30 Mar 2018 14:17:58 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] Build is broken in dpdk-next-net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 14:17:59 -0000 On 03/30/2018 04:16 PM, Tonghao Zhang wrote: > On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wrote: >> On 3/30/2018 2:27 PM, Maxime Coquelin wrote: >>> Hi Andrew, >>> >>> On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >>>> Hi all, >>>> >>>> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >>>> >>>> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_read_cb’: >>>> lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of ‘read’, declared with attribute warn_unused_result [-Werror=unused-result] >>>> read(readfd, charbuf, sizeof(charbuf)); >>>> ^ >>>> lib/librte_vhost/fd_man.c: In function ‘fdset_pipe_notify’: >>>> lib/librte_vhost/fd_man.c:324:2: error: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Werror=unused-result] >>>> write(fdset->u.writefd, "1", 1); >>>> ^ >>>> >>>> $ gcc --version >>>> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 >>> >>> Thanks for reporting, I don't catch it with my Fedora build system: >>> $ gcc --version >>> gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) >>> >>>> >>>> As I understand it is broken in ad94ade905454401b705be9e06b19e54a1c78148 >>>> vhost: add pipe event for optimizing negotiating >>> >>> I confirm it is this patch. >>> >>> Xiangxia, can you provide a fix please? >>> >>> Ferruh, how do you want to proceed? >>> Would you revert it? >> >> next-net not pulled yet, lets try to fix first, at last resort if there is no >> solution we can think about revert > I will fix it soon. Thanks! FYI, casting to void have been tried by Andrew but does not work. See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425 Cheers, Maxime >>> >>> Thanks, >>> Maxime >>>> Andrew. >>>> >>