From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matan Azrad <matan@mellanox.com>, dev@dpdk.org
Cc: jackmin@mellanox.com
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix missed item expansion for RSS flow
Date: Tue, 26 Nov 2019 13:22:04 +0000 [thread overview]
Message-ID: <fda6d7e7-d91b-fb0d-fa22-b9624e022b81@intel.com> (raw)
In-Reply-To: <1574759050-21879-1-git-send-email-matan@mellanox.com>
On 11/26/2019 9:04 AM, Matan Azrad wrote:
> When the last item in flow pattern includes "next protocol" field which
> is relevant for RSS flow expansion, a new item is added to the pattern
> according to the "next protocol" field. This field is called missed
> field.
>
> The missed field wrongly was not initialized what caused to some of the
> flow item fields to contain garbage values.
>
> As a result, the PMDs internal flow engine may crash.
>
> For example, the spec value may include garbage pointer and to cause
> crash.
>
> Initialize the missed field with zeroes.
>
> Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows")
> Cc: jackmin@mellanox.com
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Ori Kam <orika@mellanox.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-11-26 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 9:04 Matan Azrad
2019-11-26 13:22 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fda6d7e7-d91b-fb0d-fa22-b9624e022b81@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jackmin@mellanox.com \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).