From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1672A0032; Fri, 29 Oct 2021 11:22:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A97C941144; Fri, 29 Oct 2021 11:22:17 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 4848941144 for ; Fri, 29 Oct 2021 11:22:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10151"; a="228084223" X-IronPort-AV: E=Sophos;i="5.87,192,1631602800"; d="scan'208";a="228084223" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 02:22:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,192,1631602800"; d="scan'208";a="665770612" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 29 Oct 2021 02:22:14 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 02:22:13 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 29 Oct 2021 02:22:13 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 29 Oct 2021 02:22:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J1oRK1ZUW1r8jUVuP89QfbhvnvP4upbh1w6d+Q3bm7dpTylA8V2cXxG564yMKVtgUqU7g12NI1TN1vdsZv+l/4UGKI/0Irx7G+PvNsLI99KVEeJth6rQqD+6OpCg1n1N7P8QW7pggTFjFiyUFQJfylcP5oKbOqNxQy97Ap3wmk30aWDxk37r0xxJq07UkMMo6h61wUc70VKp75GjtgYCR+dR1sUMspBHgzR32WC7t8k0gdAtEhp1ay2nK6djVg9QexP5/8EVXnnZwWfXorBVqz7rFUrDDmnvNrrjQKAjLB+kj+C6JQnsIx/Pi7sxRXxNfY4Qju82b2q0oPYbfMlL0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QWByWS7zEGveZJr//G9WWwTKWL4Vkqwnc99xhXh/QHA=; b=MGcqcLHWOkYeu9tNsEK4p8DBvycIyh6WsvgXvaldsQ3EG8wOVExm5+sM+DgLW8Vk7bhjxz2HFOMAUYpNx7vS1pFUQGdbM/wFab2cT+TDfHJge4fWKznv7zfOlM7xRInu/d8NLmFPG8VvlUyISXbKEms22AChgbptaj/Rup8wme0+lxoKibOe+3f94ItDv2IGeIpcwMF5KMBYBYWhrqdpqGbUfkxAptgN+c0fiGXSjgW2kPNfWAbnP3rsBiS3jhz8EeFu36BRnJU1SkA7tFm2VB4wkFrwcV4QyLLMBVmnJ2CsMx26Eb74t1h2xr/y/2aaOgZFysU+YwTXX5Odxikf6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QWByWS7zEGveZJr//G9WWwTKWL4Vkqwnc99xhXh/QHA=; b=LMo+JOEzJYv5y3jwyx9VE0NC6AprehXUyS2lGU6ul4WcgF7Eb+RwhRWv489DDfMxWhEJVnn02XdwmQ3+WthmAkC/rH1uLK/fKmC75JChESSsBhIlwkJQgCjI+sj7k/eLSR+ymB/kv3+qmW+Up2DkVJcI5smbTGHbOY5R91Ebwfk= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5927.namprd11.prod.outlook.com (2603:10b6:510:14e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Fri, 29 Oct 2021 09:22:12 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 09:22:12 +0000 Message-ID: Date: Fri, 29 Oct 2021 10:22:05 +0100 Content-Language: en-US To: Andrew Rybchenko , "Jiang, YuX" , Thomas Monjalon , Ajit Khaparde , Huisong Li , "Ananyev, Konstantin" , "Xu, Rosen" CC: "dev@dpdk.org" , Ivan Ilchenko References: <20211022101828.649441-1-andrew.rybchenko@oktetlabs.ru> <116518a0-cdb5-b4f0-a9b0-f58864904b7a@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <116518a0-cdb5-b4f0-a9b0-f58864904b7a@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0301CA0097.eurprd03.prod.outlook.com (2603:10a6:6:30::44) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0097.eurprd03.prod.outlook.com (2603:10a6:6:30::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Fri, 29 Oct 2021 09:22:10 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d285334-fc0c-48b3-1cd0-08d99abd96c2 X-MS-TrafficTypeDiagnostic: PH0PR11MB5927: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1388; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tNGvcdi+xvyzO4qFdJEfs/YrzBIX6/GfuqU9giUI3jmAYcOfsxKZpl37pBn9iPztc4FHdxrYctnjAksAcRXJSYgsOzWx7Z8KXjAQwlvP18xsIg5+bGSPRixBjK/Z08GA1znI/cBGFaDtFd+9OHSGAfKFnymfXDcz9NH3Al4889jPB0K+lQluxl74Q8WQn1aPYG8zLj+fZ2URpAfZYG9eUUTrLmJyAZqMJsyhszp4AyxP61QI5DwPq9Fjhy36JBYx1Ec6nB3JaMcXcKSC+AqXCEM4ZF8/nh0KWjpJfd5qQXpdQZlpnysAGMG/yeHsz1ew0UuQ88aMVcm8hw0OGisEqf4L/dlH6og6R3209AF8Cnka4BZAdG1rWp92xsMN4hwgZFMH4NwS46/4oFp4d3f1HAtZ6C8CF9AY0v2twIW5dhtq1DniUcG7rFGdNxd0Oof/Nme6w0OtoQGvjLpnVTSqKLK+uxTVBjdYw/XAt3wcUe+mek6NrxwgEpxGp5rUqw9Mji6ct4TTQnwB7uU4IE7o0bXdjYcEcRm+5JR4FIc/ReA7igfJOlHGw0CbHnKIMpP7Keg2KJWwE20Ez6U+NIYR+nZbh+VQQODyLAcwmERYEthcRH+3s0KGF8V06n890bZ3zpqZCHjmmwPYMBYioffIuZCTevK0CAeXx4EkzY9vRG4m+Pn9cCxe1+nuWmiOiJRjTpeXVEN+IsPvUb6R/N0XYIdun2nNvI5nyL8XK25lSFOUXDp9tzKPB+UxmLrLfuqwQgkupRfeKD7rkquahxfFtEWOkvnuUtJidvOKh3E8VgLcQuhSizIiy2cx+0Mmr0PCy6YeFo4go15Ufa69SdcAivjxivGw42MK+fqZXp2tOCo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(956004)(2906002)(38100700002)(2616005)(66946007)(66476007)(66556008)(8936002)(53546011)(921005)(44832011)(8676002)(26005)(83380400001)(508600001)(36756003)(5660300002)(6666004)(31696002)(966005)(16576012)(186003)(110136005)(31686004)(6636002)(82960400001)(4326008)(6486002)(316002)(54906003)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTZNdS81Sng0Vi8xcDJlM2hyeXRtdmdxNjh5THZzMzJ5TXVtYlRCL0xROUZt?= =?utf-8?B?YTYxYXo1T0RtOHd4NWpFT3orYTF6YUUxM0lsVkpVU0R4dEtKUU0zNGNQczhi?= =?utf-8?B?SjQzOFlvL0Z5TzdoTXBQTUR5WjBRWmhvWllMaGNRK2RLMWZvZXpmZFRLTnRX?= =?utf-8?B?eW9IR25kM1I3WXRBOFM3eXBiQUU4dVdya09rb3NwNEZza0ZsNHk5aThyUnll?= =?utf-8?B?c0NIQ2cwMlU2ZS9WcGo2eS8ybnlOQkh4dkJndHN3aE0zeUNjQld6MTZtMTQw?= =?utf-8?B?TVZBUDdMdnRSU3BIVmM5YkMwd20xMGNJL2pYcHJjWmF0NGtNSUNvSVhFd1Y1?= =?utf-8?B?MStya0JzYTBTaW43L0h3YVBsLzBQOGE0ZkJ0NEwzenpmRXdaUHF0N2VydUwv?= =?utf-8?B?djFBRXBIS2d0R3lsUlVnQ3NZamFrOTFSUXFWVjR4bGpiT0tEZGlqTTdnZVp4?= =?utf-8?B?aEFkUVVtQno1N3g4ZXBHMXBrYjUzM1oreWlXaWpsaGVzeGdieU1vWDR4cUlP?= =?utf-8?B?SmZhTGt6aUtRc1ppRWF5dE1HM2JZSWViUUFTT2l5Q3RsOWRpajdvNXc4NDFD?= =?utf-8?B?V2tOQWVoVjhxV0VGN01XUnFoMXlMTlBicHc2QlNtNHZ5TjAyMUtBdVBPcHlE?= =?utf-8?B?SVhZNXFyOWZYNzkxbnpmS2tkOFg3aU1EOGZBcGRnUEtNWFBHWld2cnlQbWZI?= =?utf-8?B?MnByMUVSOEtvN1JDZG1zOW9wd2prRk5HcjRKRDNPeXF3Rm9yK2ZqWTJFZFRT?= =?utf-8?B?QVBNcjllTFZzcmNIUFpIblFDd2lLT1Bpd1drWXYvQzByRnlHdzU2eE9CUkQ4?= =?utf-8?B?eDRzRUtXdXRRLytBTjJJcHhtdTJqMzl2WEx2b2JwU3FoQUxScXhEQTJDdFNp?= =?utf-8?B?UGxBaGQ5akFZUFhYalhiZTl1V1A5bm54ek1xeTlSNFBVK0FJZ0RIYnNvYTlr?= =?utf-8?B?cnp5U2xKU05FT2wrS05iTVhMY2ozTlNrVENINFpvUTJ6V0F0N2pjcFRGMisr?= =?utf-8?B?TmZaQVdDT2UrUjdqdmxWYWl1VmlkOExVUkhNMFlNYkV0UDhlSmpuc3R5djFL?= =?utf-8?B?RDg0WTFGenc1TXhrR3pGM1NudFZxN2pqemNsdnhiNENRWWIxcFVaUGY2MmN1?= =?utf-8?B?RHBpWUI0TkJGbjBUWU5hQlBXUy9hc3ZZUkUxV3Fva2VJa1NmWlZlZEYxZ08v?= =?utf-8?B?VTA5VkVBd2hpMnVmd3NxaVloM0Z2eUVoRUUvZ0ZZVlVDQWJQM0gvL0o5dHZ2?= =?utf-8?B?bGtGYnlTMTcrOFFUSWorWVBoaTRMbkRncW5DQlAwajNPd2xGZWp0VHRrVGFM?= =?utf-8?B?Y0l5VmZOMC8zUDNrS0duSUViWVhjeTV0SS8yY0JkbGk5ODA3LytUNWNRS3lQ?= =?utf-8?B?d3pTOFdxZ1BTUHAxK3NWNWREN3ZsSURDMVZFYlBFUHBQOVVleDRKMEg1MFhQ?= =?utf-8?B?YUw2dk1wS2FiQTF6dXZyUkRzRHd0Nmh0V3pTa01LYWRFRjUvZGpIMEpmVC82?= =?utf-8?B?YkpjTWhIMElidXpvUUs0cWoybEx5Z28zMzVRNFJwR28wOHVPYmR6MkRQckVU?= =?utf-8?B?dkhHcVVuOHIwVlUwbWcrMUlINnpOVnVLcURwS1dmQWNGak5xZzIxN2lvNS81?= =?utf-8?B?NWdhQ2JjOGVHZmZ2dXh1bkRyZjRKdWZNMlkzbU1iUmp2OWViaE9jV1pWNThk?= =?utf-8?B?WjJQelc0MzVzRVBmbDV2cXE1SG9xbm5Nc3ZLZDRONlpwdUI1UHBKUnJqYWph?= =?utf-8?B?d3BFWGZzdGVsUnhhTUlKLytNOWVSb0JWSVdYcm94WFJ6dDIxNS9qM29xY2Jp?= =?utf-8?B?QWh6akpIMm54ckxaK00vVS81OGxybWxjZllsenUzWlJSQUFabjltOUtSelIy?= =?utf-8?B?VjB5YmFVY3dKanpRNDAweVpLNEFyL0MzZGNIUVhKTzIyK252U2NLaWRxQXFa?= =?utf-8?B?eXVhNExhejN4aU1VdW0vVDR0Sm9vZkYySTZ5U3ZuMXhlREdFZUdZUC8zT0NM?= =?utf-8?B?aEtPK1FWYXVSMHVFbWtIOXRDaUtvOGFOcUx0eWlsQUVjblVjdDBncUgvZ1VC?= =?utf-8?B?N0d1b3pNMUdRak9LTSs0YUVOamZaY0VNTDY1S1dnMStXeDVOOUZTRHNvZVVy?= =?utf-8?B?c1NCSmxMMXlMY2pZNEVTWUsvT3ovdjB1VG02Nk8rZ2NmYThKTlNXRzJYWHVv?= =?utf-8?Q?xL7SBKHyp/CkBsO0i37aQHk=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9d285334-fc0c-48b3-1cd0-08d99abd96c2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 09:22:12.0945 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pHO/lWfPgjOpGjmQpxgcwCxvQwh1FeFC0IELrNfgOuPa0fE8RxBX6uQEC/HWiKVvbuRw4u/PHN5Q6YoyzgC4tg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5927 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/29/2021 7:19 AM, Andrew Rybchenko wrote: > On 10/29/21 8:58 AM, Jiang, YuX wrote: >>> -----Original Message----- >>> From: dev On Behalf Of Andrew Rybchenko >>> Sent: Friday, October 22, 2021 6:18 PM >>> To: Thomas Monjalon ; Yigit, Ferruh >>> ; Ajit Khaparde ; >>> Huisong Li ; Ananyev, Konstantin >>> ; Xu, Rosen >>> Cc: dev@dpdk.org; Ivan Ilchenko >>> Subject: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device >>> configure >>> >>> From: Ivan Ilchenko >>> >>> rte_eth_dev_configure() always sets MTU to either dev_conf.rxmode.mtu >>> or RTE_ETHER_MTU if application doesn't provide the value. >>> So, there is no point to allow rte_eth_dev_set_mtu() before since set value >>> will be overwritten on configure anyway. >>> >>> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") >>> >>> Signed-off-by: Ivan Ilchenko >>> Signed-off-by: Andrew Rybchenko >>> --- >>>   lib/ethdev/rte_ethdev.c | 7 +++++++ >>>   1 file changed, 7 insertions(+) >>> >>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index >>> 4ea5a657e0..0d7dd68dc1 100644 >>> --- a/lib/ethdev/rte_ethdev.c >>> +++ b/lib/ethdev/rte_ethdev.c >>> @@ -3728,6 +3728,13 @@ rte_eth_dev_set_mtu(uint16_t port_id, uint16_t >>> mtu) >>>               return ret; >>>       } >>> >>> +    if (dev->data->dev_configured == 0) { >>> +        RTE_ETHDEV_LOG(ERR, >>> +            "Port %u must be configured before MTU set\n", >>> +            port_id); >>> +        return -EINVAL; >>> +    } >>> + >>>       ret = (*dev->dev_ops->mtu_set)(dev, mtu); >>>       if (ret == 0) >>>           dev->data->mtu = mtu; >>> -- >>> 2.30.2 >> Hi Ivan, >> >> We meet an issue based on this patch when test dpdk21.11-rc1. >> BugID: https://bugs.dpdk.org/show_bug.cgi?id=864, could you pls have a look? >> > > Hi, I think the problem is fixed by [1]. > > [1] https://patches.dpdk.org/project/dpdk/patch/20211024164237.2116166-1-andrew.rybchenko@oktetlabs.ru/ That patch is merged to next-net, Yu can you please verify the issue with latest next-net?