DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Olivier Matz <olivier.matz@6wind.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, matan@mellanox.com, stable@dpdk.org,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH BUG 335 3/3] net/virtio: fix compilation error with 0 headroom
Date: Tue, 30 Jul 2019 15:35:27 +0200	[thread overview]
Message-ID: <fdae9256-5bf9-987e-9ffd-2c8be739943e@redhat.com> (raw)
In-Reply-To: <20190726122538.GC4485@neon>



On 7/26/19 2:25 PM, Olivier Matz wrote:
> Hi,
> 
> On Thu, Jul 25, 2019 at 04:36:45PM +0530, Hemant Agrawal wrote:
>> When using RTE_PKTMBUF_HEADROOM as 0, virito ethdev driver throws
>> compilation error
>> virtio_ethdev.c:1851:2: note: in expansion of macro ‘RTE_BUILD_BUG_ON’
>> RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM
>> 	< sizeof(struct virtio_net_hdr_mrg_rxbuf));
>>
>> This patch change it into run-time check.
>> Reported as: https://bugs.dpdk.org/show_bug.cgi?id=335
>>
>> Fixes: 198ab33677c9 ("net/virtio: move device initialization in a function")
> 
> I think the proper commit is:
> Fixes: dec08c28c0b3 ("virtio: check packet headroom at compile time")

Indeed.

> It looks this patch more or less reverts this old commit.
> +CC Stephen

I wonder whether we could have a warning at build time so that the one
who builds DPDK is aware some driver may not be usable, in addition to
the below patch that fails virtio-net init.

Any thoughts?

Thanks,
Maxime

>> Cc: stable@dpdk.org
>> Cc: Olivier Matz <olivier.matz@6wind.com>
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>   drivers/net/virtio/virtio_ethdev.c | 9 ++++++++-
>>   1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
>> index 62c827443..3e2e8bd2a 100644
>> --- a/drivers/net/virtio/virtio_ethdev.c
>> +++ b/drivers/net/virtio/virtio_ethdev.c
>> @@ -1848,7 +1848,14 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
>>   	struct virtio_hw *hw = eth_dev->data->dev_private;
>>   	int ret;
>>   
>> -	RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM < sizeof(struct virtio_net_hdr_mrg_rxbuf));
>> +	if (sizeof(struct virtio_net_hdr_mrg_rxbuf) > RTE_PKTMBUF_HEADROOM) {
>> +		PMD_INIT_LOG(ERR,
>> +			"Not sufficient headroom required = %d, avail = %d",
>> +			(int)sizeof(struct virtio_net_hdr_mrg_rxbuf),
>> +			RTE_PKTMBUF_HEADROOM);
>> +
>> +		return -1;
>> +	}
>>   
>>   	eth_dev->dev_ops = &virtio_eth_dev_ops;
>>   
>> -- 
>> 2.17.1
>>
> 

  reply	other threads:[~2019-07-30 13:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-25 11:06 [dpdk-dev] [PATCH BUG 335 1/3] net/dpaa: " Hemant Agrawal
2019-07-25 11:06 ` [dpdk-dev] [PATCH BUG 335 2/3] bus/fslmc: " Hemant Agrawal
2019-07-25 11:06 ` [dpdk-dev] [PATCH BUG 335 3/3] net/virtio: " Hemant Agrawal
2019-07-26 12:25   ` Olivier Matz
2019-07-30 13:35     ` Maxime Coquelin [this message]
2019-08-01  8:09       ` Hemant Agrawal
2019-08-05 13:07         ` Maxime Coquelin
2019-08-05 17:26           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdae9256-5bf9-987e-9ffd-2c8be739943e@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=matan@mellanox.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).