From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCECCA0548; Fri, 23 Apr 2021 13:06:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 674D0410D8; Fri, 23 Apr 2021 13:06:41 +0200 (CEST) Received: from mail-108-mta86.mxroute.com (mail-108-mta86.mxroute.com [136.175.108.86]) by mails.dpdk.org (Postfix) with ESMTP id 953004014F for ; Fri, 23 Apr 2021 13:06:39 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta86.mxroute.com (ZoneMTA) with ESMTPSA id 178fe68f4d20004964.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 23 Apr 2021 11:06:34 +0000 X-Zone-Loop: 6f35c5b92978dd6d7791f67a132db503c55ba2ef6551 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=K9V45ZyP7Atb30mNIxXGsUsfLy+TtwtfTSL6mnWpH20=; b=JXUmtRltB3ib3RmSKxYWIC8Kae 7pRqN2Pts8I7T4Xb02zj/bSFobBLj7qU+WxDl/Y89pvwMtzs74NuR/l1Vdfo011veofR9AZ5whaAY ilqVEwCjiLgIr8tYrIH6WNfodR5ewdvUqA+nG0uVM/995X4a2d+xRUrXW27VAz+3/I8wuscjCeGYK xY5B+FOGXjIZ48Py45gi7DFqCWDMX3B9p5H8a9TQPhTS+DkL0x6dWxppSrKykEOil+x5pE5QOMO8l QHU3fwWKtSHvfRJ1Phm0+Z/XRqm9jRNHlpQOPZzCYUAIvzmxwiPEb0pUqVvCR56Pse86Q7iZNbjdb 9zwYzMog==; To: Thomas Monjalon , Xueming Li Cc: Gaetan Rivet , dev@dpdk.org, Asaf Penso , david.marchand@redhat.com References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <1618283653-16510-1-git-send-email-xuemingl@nvidia.com> <2917281.N2CalQlgY7@thomas> From: "Kinsella, Ray" Message-ID: Date: Fri, 23 Apr 2021 12:06:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <2917281.N2CalQlgY7@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v5 0/5] eal: enable global device syntax by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 14/04/2021 20:49, Thomas Monjalon wrote: > 13/04/2021 05:14, Xueming Li: >> Xueming Li (5): >> devargs: unify scratch buffer storage >> devargs: fix memory leak on parsing error >> kvargs: add get by key function >> bus: add device arguments name parsing API >> devargs: parse global device syntax > > The patch 4 adds a new callback in rte_bus. > I thought about it during the whole day and I don't see any good way > to merge it without breaking the ABI compatibility. > > Only first 3 patches are applied for now, thanks. > I took a look, I don't immediately see the concern. The new entry is at the end of the memory structure. The call back is internal and hidden behind the symbol rte_devargs_layers_parse. So will only be trigger by a rte_devargs_layers_parse of the same version of DPDK that introduce the new callback. Should be fine?