From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08050A0C4A; Thu, 17 Jun 2021 18:49:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E694B4067A; Thu, 17 Jun 2021 18:49:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 53B2040150 for ; Thu, 17 Jun 2021 18:49:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623948581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HUkwGNOUtAr8y01gStDYp3mfaMZI0AaZf+AxPDqcGG8=; b=gqpA4+vsJTrSdc4icei4PXBA+CR6DbYpa9cEYAvroPegzp40CA6j9tBXaPk9T8iO47ACW8 uXTspjfFlUC3laKLw8FuU8DnOHheB9J9Q2iHkdVj8EyxFcjM4xVTQDZbTcX2X+t666ra8r YxsJQ2RvkBNuAcBc8QmZNjNwldqbCXc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-m910gB60PwSln3s8p0KQJg-1; Thu, 17 Jun 2021 12:49:40 -0400 X-MC-Unique: m910gB60PwSln3s8p0KQJg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 46642101F7A1; Thu, 17 Jun 2021 16:49:39 +0000 (UTC) Received: from [10.36.110.45] (unknown [10.36.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20A6F70580; Thu, 17 Jun 2021 16:49:37 +0000 (UTC) To: Thierry Herbelot , dev@dpdk.org Cc: Thomas Monjalon , stable@dpdk.org, Chenbo Xia References: <20210524085812.15916-1-thierry.herbelot@6wind.com> <20210524090821.17780-1-thierry.herbelot@6wind.com> From: Maxime Coquelin Message-ID: Date: Thu, 17 Jun 2021 18:49:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210524090821.17780-1-thierry.herbelot@6wind.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] vhost/vhost_crypto: do not use possibly NULL Pointers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/24/21 11:08 AM, Thierry Herbelot wrote: > Use vc_req only after it was checked not to be NULL. > > Fixes: 2d962bb736521 ("vhost/crypto: fix possible TOCTOU attack") > Cc: stable@dpdk.org > Cc: Maxime Coquelin > Cc: Chenbo Xia > > Signed-off-by: Thierry Herbelot > -- > V2: fix copy/paste typo > --- > lib/vhost/vhost_crypto.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime