[PATCH] net/gve: fix RSS hash endianness in DQO format

[PATCH] net/gve: fix RSS hash endianness in DQO format

[Shreesh Adiga]

The hash field in struct gve_rx_compl_desc_dqo defined in
gve_desc_dqo.h has the type __le32. Therefore the hash must be
read in little endian rather than big endian.

Bugzilla ID: 1441

Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com>
---
 drivers/net/gve/gve_rx_dqo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c
index f08b58c78d..5efcce3312 100644
--- a/drivers/net/gve/gve_rx_dqo.c
+++ b/drivers/net/gve/gve_rx_dqo.c
@@ -161,7 +161,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
 		rxm->ol_flags = 0;
 		rxm->ol_flags |= RTE_MBUF_F_RX_RSS_HASH |
 				gve_parse_csum_ol_flags(rx_desc, rxq->hw);
-		rxm->hash.rss = rte_be_to_cpu_32(rx_desc->hash);
+		rxm->hash.rss = rte_le_to_cpu_32(rx_desc->hash);
 
 		rx_pkts[nb_rx++] = rxm;
 		bytes += pkt_len;
-- 
2.44.2

Re: [PATCH] net/gve: fix RSS hash endianness in DQO format

[Joshua Washington]

Thank you for your contribution, Shreesh! Let's get this applied as a
stable fix so that it can be applied to 23.11 as well.
https://doc.dpdk.org/guides/contributing/patches.html, section "Patch
for Stable Releases" should have more detail for how this can be done.

> Bugzilla ID: 1441
Please add a "fixes" tag as well. For reference, this is the commit
which is being fixed: net/gve: support basic Rx data path for DQO.

Thanks!

Re: [PATCH] net/gve: fix RSS hash endianness in DQO format

[Shreesh Adiga]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

Thank you Joshua for your review and suggestions.
Appreciate the help with dpdk process.
I've sent a new patch with "Fixes" tag to stable@dpdk.org.
I'm not sure if same needs to be sent here to dev@dpdk.org as well.
Please let me know if I've missed anything.

Thanks,
Shreesh

[-- Attachment #2: Type: text/html, Size: 510 bytes --]

Re: [PATCH] net/gve: fix RSS hash endianness in DQO format

[Ferruh Yigit]

On 7/7/2024 3:53 AM, Shreesh Adiga wrote:
> Thank you Joshua for your review and suggestions. 
> Appreciate the help with dpdk process.
> I've sent a new patch with "Fixes" tag to stable@dpdk.org
> <mailto:stable@dpdk.org>. 
> I'm not sure if same needs to be sent here to dev@dpdk.org
> <mailto:dev@dpdk.org> as well.
> Please let me know if I've missed anything.
> 
> 

I am copy/pasting from the stable mail list patch:

Bugzilla ID: 1441
Fixes: 45da16b5b181 ("net/gve: support basic Rx data path for DQO")
Cc: junfeng.guo@intel.com
Cc: stable@dpdk.org


You should send a fix to dev & stable mail list, with commit log has
'Fixes' & 'stable' tag.
Patch is first merged to main tree, tested and released. Later it is
backported to LTS release by LTS tree maintainers, this is when 'Fixes'
& 'stable' tags in commit log is used.

If a fix can't be backported to an LTS automatically, that is when a fix
need to be backported manually by its author to a specific LTS release
and sent only to stable mail list. It is not the case for this patch.

*Only* fixes merged and tested in the regular release are backported
(automatically or manually) to LTS trees. A fix can't exist only in LTS
release.


Briefly, expectation is send this fix both dev and stable mail list,
with commit log has 'Fixes' and 'stable' (Cc: stable@dpdk.org) tag.
No need to send a new version of this patch, I will use above data to
proceed with the patch.

Re: [PATCH] net/gve: fix RSS hash endianness in DQO format

[Ferruh Yigit]

On 7/3/2024 2:31 PM, Shreesh Adiga wrote:
> The hash field in struct gve_rx_compl_desc_dqo defined in
> gve_desc_dqo.h has the type __le32. Therefore the hash must be
> read in little endian rather than big endian.
> 
> Bugzilla ID: 1441
> 
> Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com>
>

As patch is trivial and Joshua not objected other than fixes tag, I am
adding explicit ack:

Acked-by: Joshua Washington <joshwash@google.com>

    Bugzilla ID: 1441
    Fixes: 45da16b5b181 ("net/gve: support basic Rx data path for DQO")
    Cc: stable@dpdk.org


Applied to dpdk-next-net/main, thanks.