DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Xueming Li <xuemingl@mellanox.com>
Cc: Asaf Penso <asafp@mellanox.com>, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] malloc: fix memory element size in case of padding
Date: Thu, 21 Nov 2019 15:14:10 +0000	[thread overview]
Message-ID: <fdfae084-9d58-a0c5-530e-10c77d7d2869@intel.com> (raw)
In-Reply-To: <1574346302-1263-1-git-send-email-xuemingl@mellanox.com>

On 21-Nov-19 2:25 PM, Xueming Li wrote:
> This patch fixes wrong inner memory element size when joining two
> elements.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
>   lib/librte_eal/common/malloc_elem.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/lib/librte_eal/common/malloc_elem.c b/lib/librte_eal/common/malloc_elem.c
> index afacb1813c..885d00424b 100644
> --- a/lib/librte_eal/common/malloc_elem.c
> +++ b/lib/librte_eal/common/malloc_elem.c
> @@ -487,6 +487,10 @@ join_elem(struct malloc_elem *elem1, struct malloc_elem *elem2)
>   	else
>   		elem1->heap->last = elem1;
>   	elem1->next = next;
> +	if (elem1->pad) {
> +		struct malloc_elem *inner = RTE_PTR_ADD(elem1, elem1->pad);
> +		inner->size = elem1->size - elem1->pad;
> +	}
>   }
>   
>   struct malloc_elem *
> 

Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

  reply	other threads:[~2019-11-21 15:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 14:25 Xueming Li
2019-11-21 15:14 ` Burakov, Anatoly [this message]
2019-11-25 23:24   ` Thomas Monjalon
2019-11-26 12:57     ` Burakov, Anatoly
2019-11-26 13:30       ` Thomas Monjalon
2019-11-26 13:39         ` Xueming(Steven) Li
2019-11-26 13:45           ` Thomas Monjalon
2019-11-26 14:55             ` Burakov, Anatoly
2019-11-26 15:01             ` Thomas Monjalon
2019-11-26 15:26   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdfae084-9d58-a0c5-530e-10c77d7d2869@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=asafp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=xuemingl@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).