Re: [dpdk-dev] [PATCH v2 05/16] bus/fslmc: support handle portal alloc failure

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 3/6/2020 9:57 AM, Hemant Agrawal wrote:
> Add the error handling on failure.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

[Copy/paste from v1 comment which put there by mistake]

Hi,

This commit seems doing,
- Fix 'dpaa2_put_qbman_swp()' which previously may reference the 'dpio_dev' when
it is null, but the function introduced in this patchset, why not fix it at
first place where it is introduced?

- Updates some log messages

- Adds a new log message

- add 'rte_atomic16_clear()' on error in 'dpaa2_get_qbman_swp()'

I assume the title "support handle portal alloc failure" refers to the last one
but can you please give more details in the commit log to clarify it. Also if
this is fixing a defect can you please reflect it in the commit title/log?

Thanks,
ferruh