From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4BF141C61; Fri, 10 Feb 2023 14:42:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA00B40EE6; Fri, 10 Feb 2023 14:42:00 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2043.outbound.protection.outlook.com [40.107.220.43]) by mails.dpdk.org (Postfix) with ESMTP id 1467E40687 for ; Fri, 10 Feb 2023 14:41:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c9fjLJJg9Qubwi5G3+k2I1JJzbqQ/zE0XnGM50fy5q4A90acKVk9DP38cEoI9YaSsauPdUTeqzPS0Gqne4Z8iYA4mzmqZcFd5pedpvG/upL5dx7FbaI/OyJbl4eXujoVf376H1HTEevdEOHQHTrmnTeaUQSljfl3psrLLsDk0ii951eiYCMrrFI4Eo82Kx597S/EOPsS/5dHq8B+zg21HYPZnalh9jpl2kKsgbxEzXfAZ9MFhvoGym+PNd8rzEkYDhcrcAXU0pGdsXgEifdcXmzdQBJzbO55Q0u6hnBuysXqsGluU2TJeMR4Nqz3AyyqIP0v6G24LuWX+qTXxDCqAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yrqs/WxLXhdbah2mVhsDaFF409fr6Ik4Sr8ZmQcD6fk=; b=QgSsaiEwjrQksCu6ovcAF+Tof8+WL6V3PblGqyBOTMQJu/RCsQhWABE4WiPiI1esyfqZPauATogxtOcgvADD0Fjs47S4Bk5+l8d8gtJ/p5irPTqA5VIDtKJj1DS4V5Ng7VJTi0FNn39JZvqi8EAyL4matejpP5pbYpcJC7dQkoDBlcuzJpKYibBcgvd5okxrdlmJpAPrNuqEVHRPEQHLsfssZWCtw/W7ZCU5YzeQ3Fog3amF/F5WXVypNSHKD7cDEm0xh0ixGLjIa65F2J4GlOZMXXv3Hs20acHtrPcm6H0UAbweK7qSnvYd9hl7dqEIlPTY/SSwjbv6dkpC9GloeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yrqs/WxLXhdbah2mVhsDaFF409fr6Ik4Sr8ZmQcD6fk=; b=1/jho5Jq1Np/1zWd67fs6SWjKjxiusWBKWIjUR3mLu+VYvrVBqZTV2Ui+CLSKOfxr7lTtgJk91o8aJSbYbpnrhrwRaoj2tgXJU2f1KT8crZjgsQ0hW5rnqeXSdW81JG1FQH1Yc60lPZGJGxwDU99uMj4q0+iTnZhLDl6je84ev8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB8139.namprd12.prod.outlook.com (2603:10b6:a03:4e8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Fri, 10 Feb 2023 13:41:56 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.021; Fri, 10 Feb 2023 13:41:56 +0000 Message-ID: Date: Fri, 10 Feb 2023 13:41:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v4] net/af_xdp: AF_XDP PMD CNI Integration Content-Language: en-US To: Shibin Koikkara Reeny , dev@dpdk.org, qi.z.zhang@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, john.mcnamara@intel.com Cc: ciara.loftus@intel.com References: <20230202165513.31012-1-shibin.koikkara.reeny@intel.com> <20230209120549.388318-1-shibin.koikkara.reeny@intel.com> From: Ferruh Yigit In-Reply-To: <20230209120549.388318-1-shibin.koikkara.reeny@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0192.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a4::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB8139:EE_ X-MS-Office365-Filtering-Correlation-Id: 64163ba3-27c2-4dd4-7b1d-08db0b6c939a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DlqR3iAIRzz9eYTUxGJVGSAgagLiE3QvRTEiP1HFnwmnmJCaJ7ZNtwkTL2bSpg+83oszhI4DcH8rmS49Nbh+1r8Tnow47GNQdDPxFUcRMh8B5GPDu9SZ/fQDpN56vqfU2BjWWZiTVfFT7VtiN9M/HSRNTvbcgbPB7yTONpUERzclhUv/wZeb4VFWrNG1JNBvOK70iCg2zQZYq08Va9RUajFExwdNUH+Xm7gVyCABEsA45GTt/SQ4RxWl2H8KQo5x4uBD4hDgTLrM9X2n1eAGNI/5+34a3ghTg2pm/648Hl8t5wwn5+KCBvXcaDbSizoYlMaTmqtN0WZqJJSt5SukW+jbbXiK2eApWg5GXdXiVy7JmVNOTKxY1uDp1khZcClg+YVOEoNxUtvTvS5f3UFF20WBGeafW+W4jb72gpwr+rf+LXdCAOt4gFM4qexMBXVBgd82ql08S7MJv4I64SwUR/BswwyE4VoTxFpE9R6UPI+0kcczcSDYw644EHYS8KMjLI7V/8mOCQCpxLvlvVgiOUo/1n2hhy7hv53zwpEA1uZuxxwIlnkK3WOhIKCNDi7MU9I+nDkJzvhZ2HO6ppg7qFKidLyoZnDUtbSz6iFX0U6XFEbl2AFt/rT3T9HATiZgsScN0HXW6gDkdaKzA0Mw+o0un3AqVW5eUTvDCWzsaeTEqvumNPWmFYnsLZKzkYVPyZbzDYeRqaxKM5isorxiltWW8rXRTrdW7ejiqrict9Oc/XsSrYT4aLkQTvLYtfJAbB0LBt+l0LNuQpoO4ZnyBA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(396003)(136003)(366004)(376002)(451199018)(44832011)(2906002)(86362001)(38100700002)(31686004)(2616005)(966005)(6486002)(186003)(6506007)(6512007)(53546011)(26005)(36756003)(31696002)(66556008)(66946007)(66476007)(83380400001)(316002)(41300700001)(6666004)(4326008)(478600001)(8676002)(8936002)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YW00aHVaWTZnWm44T2xadUwyZFN5TDNuQjkrTmFyRGEvVUV0L2o0S2ltZjRs?= =?utf-8?B?MExvZ3dSZC9pZWRBa0Q3dS9zSFJIeWRMdkJSM096WUhGNDZlWHVibERUUlpi?= =?utf-8?B?TXYwZzNMQm5oZUpvU2Y3V1lRU1B0aXpHVndMOXE0SWRNL0VWVk9UbUwrVjNV?= =?utf-8?B?M2NMSC95RmV4cUpRRGFicCtBM1Azd0NaVkQwd1pVM000Z3FmRU9oUnA3VFRw?= =?utf-8?B?V0ZtNFZJZjNnT1NERTNmUU5FRERUaDF1Tk1vYXJPRDYzcThkcWFTN2JkaE44?= =?utf-8?B?RkY2VFFXMnl3SFJ4ckNHRXVFVzlhWWRXVDhvTCsrZkZuVS9pZkdrMS9MQnlU?= =?utf-8?B?SEVvb1hRaVpSRXkwUzNuTitHN29CSnRtQmxraFVualZEeTJmQzRFU1JCb0NS?= =?utf-8?B?eS9CdjNxWjhBNi9wTFNpZEVNRlZCNnhMNXFhSEh4MHUrV2h1S3kycllZVUVQ?= =?utf-8?B?aDlMZFh2Tm1ucVZuTUZZdGltVm92c0prbUxyRHpJcnFsUDMvaWIyUFZxRG1q?= =?utf-8?B?Z0tsWnpmbS9aYzBGY0VaOGc1N0lqQnhoZnErajJDcGdjZXZ6enY2MTdicmRC?= =?utf-8?B?eU04Z2FtbURiZW44Ky95Wm14dHJnQzFVS05HY1VRV0lnMGcwVXhVeDRrOWY4?= =?utf-8?B?dEI4ZmdBUmFRRDNFVTFtV1pVdGhYTXU3anJualhFZUJQY05kMnRHcnlpcEdt?= =?utf-8?B?VnBHZ0doTVRSd0xRUk1KSGN2aDlwdjNFaW1oc2N4VDEwZ0tGL1RyVzY5cWFi?= =?utf-8?B?cG9UN0w5WEdBN1R2M2tyaG5oQ21ueVhwd2s2ZHpRY1plaitTcVMveDZoeUdH?= =?utf-8?B?dlZwRm1ITzBuN1BwaWp6UzBRaTMzTUcwWFd3aHJobTF0cDR5MzFrRU1Edkpk?= =?utf-8?B?RFlBdGVaMzl2MC8rb2xBUlJzQm00SGVWYTN6bURaKzl5YWdHdHZzbjhVTVcw?= =?utf-8?B?aU8wVVd2cFlFd2lGWFR6YW51TVpvY1A2aVMycFRlWTJ0QzdRQXQ3ZlBYZmVF?= =?utf-8?B?MGh1WUN1ZXhLcU5UejNBWThyQW10eGlJdzNWMHFyd21zK0R5ellPdks0cUVp?= =?utf-8?B?Y1ZSMlN0a1ppamJyMlFUYVA2Z3pBREVhTW5UZnJHeXpLTVB6UVg2UTlSREhy?= =?utf-8?B?ei9KMDRpYXN1R2grUzVQS1JoNzNhdm0ycGdNcnlBVnpGd24rK1ZSVTBublpr?= =?utf-8?B?VUZxSGxEMFJiSTQraS8wZVBJR3RoSlpQMXF4eXpNdkVFWUdKOHBuK2VWUHJ3?= =?utf-8?B?aWZ4ajVFcTNOekJKMElZU29PZC95NTRRR2svRHNpbUVBMlFJWUhNZUk4T0xC?= =?utf-8?B?UEtDbVJQbU05azVTMk80QVVlVkE2NkNsY1I3aXpubXdpNHN3Zm9PVlVmM3pY?= =?utf-8?B?R0dxZFFnUUpwR1ZIVzJuOUJvUkQwMitWZ1o2SGVENFFEUXI0WE5kd1hPbTFZ?= =?utf-8?B?M0FOSS9Mbm9QbFZiMmhlaU1jdTNQS0FXMW8rckF4YmlJNXVCSk9BdEsyWVVX?= =?utf-8?B?N2gydFpQeEdKb0ZrSjF3K1lwTVZIOTdWK3hwNlQrYi8wVnhPRzNWMFd0QzZ0?= =?utf-8?B?cjlwcWs0MG1aZnExbC9USmljb2FTanRDSExqQlQvYSthSVRBTlhlWnExWkRw?= =?utf-8?B?Q3Faalc5WHV5L3hncWJ6c2M4UzdPRVQ5VEZsV29ZeE9USTE4TnJZUld3QlVq?= =?utf-8?B?N2l4RXBrK2gyazRVRFJta2lpWUE2dnBwWVVVRVFDRk5FRHJNOTdFb2VlOVl6?= =?utf-8?B?TTg2QlZlRi9KRzRIZ3U4NlFKZVhoVkdsZkdHYWFsZ2haTW9reEp0WVhneXZQ?= =?utf-8?B?YmswYzdtM3NZeE5mYTB3K2xaL3lQUjJMRjd3ZDRvdituS1VVS09sbVdXVlQ0?= =?utf-8?B?RDRGZHBSS2tTdkhxamtUVHV4VjROejFjYUtGMWZTSmp1NVR1b2hTQmdEVEVG?= =?utf-8?B?QmR3S1N4bHlhNXB3UVBBMmJEZFpHbFczLzl3NldCQlB4Q2I0SUoxZmtJVGd2?= =?utf-8?B?allUSzEyQ2pnckFuODM2ZXhPMGdTSWVWVWVoYXhXSWhjVWZyclNPUVpJWGVo?= =?utf-8?B?ZmRLRFhxL0xtSmlPNjNYcUYzaU1Uc2JXK25SSjZqWUFSVC9ibDVJclNZYzFN?= =?utf-8?Q?kWWbwEiRdtMQlwkBZ7lOTx/3o?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64163ba3-27c2-4dd4-7b1d-08db0b6c939a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 13:41:56.5849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /msU0oY7g+wDcOFQFNJzRyy3zdUwYXLiztoBd2Gt8owLiQQwKu20kBpSsQRsVaEl X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8139 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2023 12:05 PM, Shibin Koikkara Reeny wrote: > Integrate support for the AF_XDP CNI and device plugin [1] so that the > DPDK AF_XDP PMD can work in an unprivileged container environment. > Part of the AF_XDP PMD initialization process involves loading > an eBPF program onto the given netdev. This operation requires > privileges, which prevents the PMD from being able to work in an > unprivileged container (without root access). The plugin CNI handles > the program loading. CNI open Unix Domain Socket (UDS) and waits > listening for a client to make requests over that UDS. The client(DPDK) > connects and a "handshake" occurs, then the File Descriptor which points > to the XSKMAP associated with the loaded eBPF program is handed over > to the client. The client can then proceed with creating an AF_XDP > socket and inserting the socket into the XSKMAP pointed to by the > FD received on the UDS. > > A new vdev arg "use_cni" is created to indicate user wishes to run > the PMD in unprivileged mode and to receive the XSKMAP FD from the CNI. > When this flag is set, the XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD libbpf flag > should be used when creating the socket, which tells libbpf not to load the > default libbpf program on the netdev. We tell libbpf not to do this because > the loading is handled by the CNI in this scenario. > > Patch include howto doc explain how to configure AF_XDP CNI to > working with DPDK. > > [1]: https://github.com/intel/afxdp-plugins-for-kubernetes > > Signed-off-by: Shibin Koikkara Reeny btw, it is just a detail but if you will send a new version, can you please fix the patch title to remove the duplicated "af_xdp", it can be something like: net/af_xdp: support CNI integration