From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7704F4582E; Wed, 21 Aug 2024 10:53:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F88C40395; Wed, 21 Aug 2024 10:53:54 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 0B6B94003C for ; Wed, 21 Aug 2024 10:53:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724230432; x=1755766432; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SQ70U+KlbKKdj66n8BlfIgWdXU3B8PlIoyVhqir8NSE=; b=fh3R6SoC6TgivjuP8f6MdT/LHx2PjZCgZMvJV0AYV3zu6w6794GsW07d pfOCfavfuH7jCJ2/77XmrSqnGrofSLorz1SMAGyTOYbdPrZy4b8tDvQZR vuNaWvLfLemjiqp7HdsGyjjx+rxiWSiK6ankrw98tKQGQLBjoYGHEbPKH aaLGoAeWTXJNlUxklRq3HlE77Kjoyxcf9qDDy7kcu9F1PaHl39C9RTUxC UfIFl3W+gqMlAOEWf/MwH2S2q5QS95LJzepkV2Mt1LzQDvnzs84VPP8+o CeTlINjC7u4SzTkjNduJf5d0DBVvTafkN+QxFcEJsXCIuApOPsEqLIVS1 g==; X-CSE-ConnectionGUID: aDCu5JERQ72BiIcR4hv7YA== X-CSE-MsgGUID: ITnQj72uQ5yV00IhlD3/3Q== X-IronPort-AV: E=McAfee;i="6700,10204,11170"; a="25474643" X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="25474643" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2024 01:53:49 -0700 X-CSE-ConnectionGUID: iru+hsXYQE+ubKdohL9A9A== X-CSE-MsgGUID: sWsTRCU5RgO5GrKOXPA3Ag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,164,1719903600"; d="scan'208";a="60756092" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Aug 2024 01:53:50 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 21 Aug 2024 01:53:49 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 21 Aug 2024 01:53:49 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 21 Aug 2024 01:53:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=elzxZlZW/n5KegoUdZkXasF/8Z+XvyTanQ2cnGtNULkv9zwbaP3595LbKAJirG68N/ohhmtTtGZX4CKGQlAcVZZOFCiys7Flyw2Riipi5jAm0spsuLMdqMVm4/wNeJG62Ci21ZRv2jQVP8ZMuS82r3SXC1dZz19VkFmIBSw+z7zF1Y5LlsqvPr41Y0/YbKgyg9B6dfzyXwIZTA4wgySAInFgHP8U7sVRQiNCSmcX6Y9LwjfGx3gSN7gS0Cy7sFwtlT1nGqHQoyZmEsPsNcxB6Dvx2fkqD9n2ymZHYvKoZGoUvTDiVd9Ys9mx70DC5NFD6zqm47IJ+kAf7xuIs5fWQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Olh+tjHCtk6i9Kg5Zzt1ukAWUOEQBU3KmVcRjaS89qs=; b=P0Yg4oTIqNsjo/iyZd/kr0hLhsHBrlAtghMmLxKTZjF6hlBHPbbNHUia7iH5u6MwPPDUpOHcHpycELtz07wmQVqYkqBu2Khh85CkjlrKRl21kfQVJTOPnOmDfQjnnH7Q4dxSD2fk/oIHUK2y9+OsVHslPR1CKdA1lyv2HO42rXnjOvQJuRfEVT1e9TxR4EVy2VdMMcEBzWn6mwlSlPMegcnmRsvH88qXGkbIkExrHBFlUX+R4UrX+6PKrrBqGu9eM7DXaz7xE0hH+6vCDd5+4kLWWOmXVDVl/mOYIF7iBS1Kpn9oMrfvrRuTix1pzfYx9/eNOJIKh6WA5ZZGQ8GFTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by DM6PR11MB4628.namprd11.prod.outlook.com (2603:10b6:5:28f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.16; Wed, 21 Aug 2024 08:53:47 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%4]) with mapi id 15.20.7897.014; Wed, 21 Aug 2024 08:53:47 +0000 Message-ID: Date: Wed, 21 Aug 2024 10:53:41 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] usertools/dpdk-hugepages.py: update coding style To: Stephen Hemminger CC: , Robin Jarry , References: <1c9f589c434cfb91c53dae7528cfc165c976b0c6.1724168117.git.anatoly.burakov@intel.com> <20240820085205.37d25751@hermes.local> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20240820085205.37d25751@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0316.eurprd04.prod.outlook.com (2603:10a6:10:2b5::21) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|DM6PR11MB4628:EE_ X-MS-Office365-Filtering-Correlation-Id: f646868a-5c0e-42ec-939a-08dcc1bec4d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Wmt0MnZRWU8xME42cW02UXNCWmY2MHBJa1lMUzh4d2FPZUwweUw2SFgrb3A4?= =?utf-8?B?b3RIcjlHQ0ZjVFVKOGlnYWk5V2lKNnkxS0FyN3QvdWx3QnNlS1cybW1wbnps?= =?utf-8?B?RXBFeFM1cmpueXhDMk53bVQ3ek9XeDhqZGhURFF1NTZzdzFURnBEVVB5NXhs?= =?utf-8?B?RUZDdlVGTGk2d2gvcTlrbTZnVmlUV3JZWitiQlVwcHlsUkVPRWlwQnRvVjRJ?= =?utf-8?B?T3NCb05JYjFXbW5TVVZNQ0NiczdUTCtuWngrTXU3NzNSdmlVMUFSQ0FZanVw?= =?utf-8?B?aUNoQVd6bnE4MWo0RU00YkhtbVAzaFNQWTFyOTkzdTZjbEJkSmYvQXVmZmhm?= =?utf-8?B?aHdkd3I5Q2JmVzJWOE43dXVIRTluV1NGSjhFT0NSOGludkg3KzV5QWVnVWxw?= =?utf-8?B?aHhsZXErNUVUZ0ZaYVRIZDZNVXI2RXZtcGhJT2pTdWZMcHlLR1RUaStYSWVu?= =?utf-8?B?dytNbWhqZkpZNVh3dDFKeHUxaGdSaTNURFNTN3JpdGVZZnhiZmdkN3RCNDVw?= =?utf-8?B?azM5M3NyOHBkMWszc24ybWRITnZBcG43L1I5MVhLeFNCTGdHcHNLdmcrQlIw?= =?utf-8?B?RXNOZktORThmdGNJdDJxcjVDZlZIWHlHUEo5VE5RREZ6Z2J3S0Rhb2F6WUVZ?= =?utf-8?B?RlpOTlQrVFQyS2hPQzR5cTdIcENvdXk4TGJ0MkhpeGRHMFNqTjlRWU9KallI?= =?utf-8?B?VW1tUlR2SjQwc3pCWlF5cHFHU2cvdEhqbGFxNW5RT0cxSjJpYThod2V5WC9k?= =?utf-8?B?Q3Zkbm9ycVBPTGNIVlVUcjhFZTVVUStMZERaaEo5MTJydzV5Y0FRUmRiMkQ3?= =?utf-8?B?YnhaT0lSRk9MVHZqUGdBYmhOc1l5NDl1enBSNkhKam1vaTA0ZUZuRTZkSGha?= =?utf-8?B?TWd0aGs2WUJ5eDZHa1EwWVpmVkxydzN4MmZYUU83RGcrdUhuZjdtTmw3TG4x?= =?utf-8?B?VmJhb3VteUU0U29GeFRZQ3lQdENJNUNhcDZmdWxKcE5NazhLNDlFQXk4S0N4?= =?utf-8?B?MkdmYkV4MWY1UkR0YUh0ODBrRTJFaTlKWllRNVBTbzdTcDV3MEorU3ZBUTdl?= =?utf-8?B?SGpHR1RwaHBGeGR5RjNCRHZieXBudHZMb2xRbGFqRGUrTXEzanZQb1k0Z2VL?= =?utf-8?B?aWprV1U1WllHSis1ZUo4ZlJ6aUdER3gxb0hhdHd0R1dQc29Pc2psQnA4WjI4?= =?utf-8?B?dWR6RE5maHJWaGtoa2wwTUUwb1NVejd3cWhsdzJYbjFXOThUc2tqdU1NcVEy?= =?utf-8?B?MVpiM255Qmt5dXUzcUdhNWdoamoycnh5TkpRMUw0QmdxT1hITDI1Y2tMRGYv?= =?utf-8?B?L1pWWXMwdUZlOEJmMXRiY2wyQjg2cFBZd29Sc0JWd3dueWdJMGRvTHBxeG9H?= =?utf-8?B?U2FjVlVrek1DUGsxSjF1WkN1N0YwdklmZ2ExaEFzeGFvL2tVeWszYzFUa0Nk?= =?utf-8?B?OWFxejZDdFVUeFUzMzZhUjdZMWJSRlNLaU9xLzRXWnVBTFJqa010NWlsVWdk?= =?utf-8?B?dXhOVFdJb29QNkVXRlRiVCswUlFxTmtPVWFFSUZxbVpYcXFqVzNxUklaMGVU?= =?utf-8?B?RlB5Z1I4VUlDWnVMejZpcjRnZjFDN0s0KzV4MHJSWE0xZE5hOEJGTW1UNmsz?= =?utf-8?B?WVNrYlNWd3VUOWdSeGc1SDVxS3lFakZ4QVZ3elhXaVk1SzhOSlFqN1hacmFR?= =?utf-8?B?b1FyenhGYmNiZldDa2dYckJvemxGSVVENnE1RFZEUE90SXh5V1IrLy9qR1hp?= =?utf-8?B?Zm9PWUsvSlByeWxUN05iVVBFdHJFMCtDK0VzRzhpRE82clpoRWNIMHBSK05Y?= =?utf-8?B?V3R6NjV4ZEZIZForZldBZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekVRZGtpMkozRDFEaUxxdWMyb2VBOEhobzgxUU9pNlRzRHlISGFFSjJTQzFV?= =?utf-8?B?N0MyelRZU01FbEZFcFQ2Nit2bHNwZGR6TWlkOHBCWEw5SHBZUWdwRjJRalV1?= =?utf-8?B?Y2JFc1BYdlRaQVByLzMyUVRsYzhndHhNM1hwRkpCbFdTdS9vb1BIZXNZeGF3?= =?utf-8?B?N0EvTmtOMXVWcGg3d20wREU2OGFBK3dUcm1QNUVmbmI4bG80RU5CRWdBalhS?= =?utf-8?B?ZmErVkVxakNnOW9acjBlWUdvN2NEQ3ZRcVpUU202TjhyM1h0dHJaOERRd1o3?= =?utf-8?B?RWJVNkhxNjlrb3JXRzNaZ1dKYUlId0VwY3BQZEVvekcrakY4VGUwSS8yaFZk?= =?utf-8?B?Qk1aWlJjQU1NWE9mUFdyN3RRbUJ1RmtLa1FlSlhvQzFwYXF0WGdiNW9Mek5N?= =?utf-8?B?YkI0QUo0ZUN1R0cyWDVHeFlaZGFGN3lhYVNRanZFZlhvajlDOXZka2tlMWkz?= =?utf-8?B?aStGWEtDMWlYTWtwdVFGdkpYaml1MUU2aExYQ0svSGkwakNoc2E2ZmVibGVJ?= =?utf-8?B?SWJtYWNsQWNUOGpjb3hQaEdablZWUmRnNW5MT1dwK05GWUxHdGpnckJ3VzhJ?= =?utf-8?B?V2F5b2lTRm9qY2tpR29WZnIyVlNSWUJhWW5BMXJpK0FWaG9yZy9oWUNHRG1r?= =?utf-8?B?NkVRTUN2ekNEK09yTkJiWkl5Vy9NcVVaYVFkTVQ1UlEvMktOd1hzeUN0ejI0?= =?utf-8?B?YzdSUzMxYnI2bnZxNGNMTDA2VFVWOURqa2R1T1JKR3Y0WVlHTS9SdC9YelVJ?= =?utf-8?B?UDhDZW5ZdnlVTE45c3FySHhLODl0Y1k2c0hEQ3VQcG1FWEZ0eTFtZC9CZGVX?= =?utf-8?B?VHJWb2wvb2tJWkhLbGFORUVqSGl5WEExdW9SMXVweEswUUFveXZ6NFJwcURt?= =?utf-8?B?VEJiRkFubXVMWTdGYVc0RExJSzZxQ1pOU2lIUlNzUzhxcWt0Vi9oM1JSM1hL?= =?utf-8?B?SmlWYk1TTmxWMjNRK0pCVXZiM1ZSYlBZWlNIZVcvRWJMNGU3TFlFNHFaMGls?= =?utf-8?B?dlhnOFhDZjRnNmxkRXFseXNVQzZBc1BpcmtyMTU1UFVPWk1jeFRiRWIzdFlS?= =?utf-8?B?SERRTk9HSWV6NmhRL29XbEpSd2ZzSnU5YmpEdE9wUkN0NUhBNFBDRFlJRFhL?= =?utf-8?B?NWdLUGpueWJmQllWWFU5YlREUGtLT3c3Qk5rdHc3N2ZTaCt5SjZBR3REWTRi?= =?utf-8?B?UG5vQWpYV0haZ1JadE8zbklLYnJhOVFsazV1bUkveHRYL1FscVZ1N2VUR3RQ?= =?utf-8?B?TTRIUjk5bmxIR2RWc0p1Y0dKRHNJaUVOZUtyYlNibWVnYzdwOGFPVDZZWDlz?= =?utf-8?B?RWtSRStJd3ltOXVKenp6cDNjb0ttSnpxUEtmUTIyM3E0Q2N6SmFKc0JVSXc5?= =?utf-8?B?aU9jOTVXVk5PU3p0UzFLTGVxdHJuUlB0QlBDMThoZjVyY3hybnhOQWh0ekVJ?= =?utf-8?B?MnR3RU5PN0piUFI0OCtZWmNIVFZoOXhNOHcrbjNpRktCTUthcjZhZy9WR2di?= =?utf-8?B?b2hmUlhLNzRZOGxIYUJCMlpoSmErRkVzSGtHSWphTXlES2VjRzJZU3pJM09Q?= =?utf-8?B?dHpSZDlVT0NkMXBWeEdWbm9uYXRVQ0NmMTcxZzd4RWhra2NNK1RpT0YyMGND?= =?utf-8?B?ZW04ZXBYWGV0MWliL0NhUjhwZ09HZGdaTGZNcXdVa0dKMlljeUF3OUZ2ZlVN?= =?utf-8?B?ZWRnclBTc05CbngrRjR4UGpJV2lNcWRpdndsSDM3Wlo4dlozMlRJYjd3MThl?= =?utf-8?B?dnhtRXU5OUNFZTBELytTaTNaWjV2a0pEcVh3cWVwUk1wL0RzTmhoMTdhbU1L?= =?utf-8?B?OU9zc0ZEekV3TERZMDRob0hwcnVndzZ4OFY1bW1vNWhGTFZ2MzJNOHdzQVlZ?= =?utf-8?B?dHdmSjNrMExFQUNUYUpvd3F5Q09ualhTWC9rVzRZbHZOdE83WUMvcDZBVWFl?= =?utf-8?B?R2QxVjI5M0hTZmJ1WG53SEpCSzNGaHFWN2M3bFZ6NW95MjJCRGN2M2xDRXZk?= =?utf-8?B?ZVhERWpXRHdpbVFIaWVuWWJBN3JQb0t0cmRwTmU2UEduQ01PUWlNb3AvNHor?= =?utf-8?B?eEJEMkpIWDN0bHRSMnQzZDZlaFZhY0dFQzdCczZ5Z1VkSGFSbTM1R3dwR2VG?= =?utf-8?B?MlllbVpxSG9kanZObGF5Slhtc2ZCdCtIeE5zbUxnNkdXRmhDWUl3WlVPMkx4?= =?utf-8?B?ZVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f646868a-5c0e-42ec-939a-08dcc1bec4d0 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 08:53:47.1583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: st86tIJoUDNQRFxfdl1jIEjBhqLbRzUZJqRSU3cUkv7kCumMypytCxrGWWqpiNJuHbciJ63j2CT/2sII8ASqjQ0/O597ob5tOmQWiTMmUCg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4628 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/2024 5:52 PM, Stephen Hemminger wrote: > On Tue, 20 Aug 2024 16:35:16 +0100 > Anatoly Burakov wrote: > >> Update coding style: >> >> - Make the code PEP-484 compliant >> - Add more comments, improve readability, use f-strings everywhere >> - Use quotes consistently >> - Address all Python static analysis (e.g. mypy, pylint) warnings >> - Improve error handling >> - Refactor printing and sysfs/procfs access functions >> - Sort output by NUMA node >> >> Signed-off-by: Anatoly Burakov > > Looks good, but not sure if always using single quote is really necessary. > Many python programs seem to use either one indiscriminately. Well, that doesn't mean it's a good example to follow :) At least it annoys me visually so I went ahead and fixed it since I was doing a rewrite anyway. > > Acked-by: Stephen Hemminger -- Thanks, Anatoly