From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99E72A0C3F; Sat, 3 Jul 2021 01:26:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 178D341402; Sat, 3 Jul 2021 01:26:35 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1C75F40696 for ; Sat, 3 Jul 2021 01:26:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10033"; a="189172727" X-IronPort-AV: E=Sophos;i="5.83,320,1616482800"; d="scan'208";a="189172727" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2021 16:26:31 -0700 X-IronPort-AV: E=Sophos;i="5.83,320,1616482800"; d="scan'208";a="490375753" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.220.186]) ([10.213.220.186]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2021 16:26:29 -0700 To: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "jerinj@marvell.com" , "dpdklab@iol.unh.edu" , "aconole@redhat.com" Cc: "gakhil@marvell.com" , "Power, Ciara" , Ali Alnubani References: <20210630124637.2987722-1-abhinandan.gujjar@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Sat, 3 Jul 2021 01:26:26 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/2/2021 7:08 PM, Gujjar, Abhinandan S wrote: > Hi Aaron/dpdklab, > > This patch's CI seems to have lot of false positive! > Ferruh triggered the re-test sometime back. Now, it is reporting less. > Could you please check from your end? Thanks! > Only a malloc related unit test is still failing, which seems unrelated with the patch. I am triggering it one more time, third time lucky. Also after re-run, some tests passing now still shown as fail in the patchwork checks table. Isn't re-run sending the patchwork test status again? > Regards > Abhinandan > > >> -----Original Message----- >> From: Gujjar, Abhinandan S >> Sent: Wednesday, June 30, 2021 6:17 PM >> To: dev@dpdk.org; jerinj@marvell.com >> Cc: gakhil@marvell.com; Gujjar, Abhinandan S >> ; Power, Ciara >> Subject: [PATCH] test: fix crypto_op length for sessionless case >> >> Currently, private_data_offset for the sessionless is computed wrongly which >> includes extra bytes added because of using sizeof(struct >> rte_crypto_sym_xform) * 2) instead of (sizeof(union >> rte_event_crypto_metadata)). Due to this buffer overflow, the corruption was >> leading to test application crash while freeing the ops mempool. >> >> Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test") >> Reported-by: ciara.power@intel.com >> >> Signed-off-by: Abhinandan Gujjar >> --- >> app/test/test_event_crypto_adapter.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/app/test/test_event_crypto_adapter.c >> b/app/test/test_event_crypto_adapter.c >> index f689bc1f2..688ac0b2f 100644 >> --- a/app/test/test_event_crypto_adapter.c >> +++ b/app/test/test_event_crypto_adapter.c >> @@ -229,7 +229,7 @@ test_op_forward_mode(uint8_t session_less) >> first_xform = &cipher_xform; >> sym_op->xform = first_xform; >> uint32_t len = IV_OFFSET + MAXIMUM_IV_LENGTH + >> - (sizeof(struct rte_crypto_sym_xform) * 2); >> + (sizeof(union rte_event_crypto_metadata)); >> op->private_data_offset = len; >> /* Fill in private data information */ >> rte_memcpy(&m_data.response_info, &response_info, @@ - >> 424,7 +424,7 @@ test_op_new_mode(uint8_t session_less) >> first_xform = &cipher_xform; >> sym_op->xform = first_xform; >> uint32_t len = IV_OFFSET + MAXIMUM_IV_LENGTH + >> - (sizeof(struct rte_crypto_sym_xform) * 2); >> + (sizeof(union rte_event_crypto_metadata)); >> op->private_data_offset = len; >> /* Fill in private data information */ >> rte_memcpy(&m_data.response_info, &response_info, >> -- >> 2.25.1 >