From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 277F1968 for ; Tue, 19 Sep 2017 11:23:59 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20170919092358euoutp02017ccd27619b868613cc07a7363cbc0a~luPr8fHDi3161031610euoutp020; Tue, 19 Sep 2017 09:23:58 +0000 (GMT) Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170919092357eucas1p2eacf15cc335ada7448d1a0c9bef246c3~luPrMqVKm2113721137eucas1p2h; Tue, 19 Sep 2017 09:23:57 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1.samsung.com (EUCPMTA) with SMTP id 76.81.12576.D22E0C95; Tue, 19 Sep 2017 10:23:57 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170919092357eucas1p16a42cc196e27e100970312f17c6b33b1~luPqhDRFg2017920179eucas1p16; Tue, 19 Sep 2017 09:23:57 +0000 (GMT) X-AuditID: cbfec7ef-f79ee6d000003120-f7-59c0e22dcca5 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id EC.6C.20118.D22E0C95; Tue, 19 Sep 2017 10:23:57 +0100 (BST) Received: from [106.109.129.68] by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OWI0065VSRWZU40@eusync3.samsung.com>; Tue, 19 Sep 2017 10:23:56 +0100 (BST) To: Bruce Richardson Cc: tomasz.kantecki@intel.com, dev@dpdk.org From: Vladimir Kuramshin Organization: Samsung R&D Institute Russia Message-id: Date: Tue, 19 Sep 2017 12:23:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-version: 1.0 In-reply-to: <20170919085619.GA17536@bricha3-MOBL3.ger.corp.intel.com> Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsWy7djPc7q6jw5EGqx/ImtxY5W9xbtP25ks pq3+zW5x+uZmdgcWj18LlrJ6LN7zksmjb8sqxgDmKC6blNSczLLUIn27BK6MQ5+fshXcFap4 9+I7cwPjXv4uRk4OCQETifPXOxghbDGJC/fWs4HYQgLLGCV+LePtYuQCsj8zShx70sQG07Bo 1moWuKINDzghip4zSuxe3ww2SVggQOLGvZOsILaIgKHE1oVbmUFsZgFtib72XWA2m4CRxKqN +8GG8gtoSTzevJEdxOYVsJM4dfQDWA2LgKrE1GsnwOaICkRIbPs+gw2iRlDix+R7YEdwCrhJ tP16xAgx30ri2b9WVghbXmLzmrdQe8UlmltvsoAcKiGwh01i0pLNUC+7SHx92gllC0u8Or6F HcKWkbg8uRuqoZtR4mzrHFYIZwqjxJ5lT1ggquwlTt28ygSxgk9i0rbpQOs4gOK8Eh1tQhAl HhLvznZCDXWUWNR6jwkSXP8ZJfbdnsQ8gVFhFpKPZiH5YhaSL2Yh+WIBI8sqRpHU0uLc9NRi Q73ixNzi0rx0veT83E2MwIRy+t/x9zsYnzaHHGIU4GBU4uEVuLY/Uog1say4MvcQowQHs5II 76FFByKFeFMSK6tSi/Lji0pzUosPMUpzsCiJ89pGtUUKCaQnlqRmp6YWpBbBZJk4OKUaGON3 TP4SePDN3E8f1i84sZVpirPNrVuZ/L88/s9tEknnXsL60ZpXxmm3Qvm533oH7jL1J87ctujg VquGgKKljm8lZ/3tbw+rSn2i/Mf4QKbmuQdajn+YSi7czPxyM+aizBTFakGf5z/llGxns7+U V1wcesdKXf4yzyud6CX/G9jjA6NcFz3hu6rEUpyRaKjFXFScCACIn8DQJAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t/xq7q6jw5EGlw7y2hxY5W9xbtP25ks pq3+zW5x+uZmdgcWj18LlrJ6LN7zksmjb8sqxgDmKC6blNSczLLUIn27BK6MQ5+fshXcFap4 9+I7cwPjXv4uRk4OCQETiUWzVrNA2GISF+6tZ+ti5OIQEljCKPFz7mMWCOc5o8ScZzfZQKqE Bfwknn9sYgWxRQQMJbYu3MoMYjMLaEv0te9ihmj4zyhx+ccURpAEm4CRxKqN+8Ga+QW0JB5v 3sgOYvMK2EmcOvoBrJlFQFVi6rUTYENFBSIk+t5ehqoRlPgx+R7YeZwCbhJtvx4xQiwzk/jy 8jArhC0vsXnNW6gjxCWaW2+yTGAUmoWkfRaSlllIWmYhaVnAyLKKUSS1tDg3PbfYSK84Mbe4 NC9dLzk/dxMjMPi3Hfu5ZQdj17vgQ4wCHIxKPLwC1/ZHCrEmlhVX5h5ilOBgVhLhPbToQKQQ b0piZVVqUX58UWlOavEhRmkOFiVx3t49qyOFBNITS1KzU1MLUotgskwcnFINjGePXtjUW1q1 InuLwjm+i7ccf9Unb9jE9eEk9yK2BdXsZ5itIxc99UsU27rtpe5K7Yj01tPLXzMvO/gvl1VN iPue7RoO96XFJXJbN1Qa/LzZ8FZ8SnFWbcLLb/PiXcJ06qK59q/hXNDjE6Wv57ws/7Xz3Hcr 3x382qP1SfjvQZ8dAVFlN1e+4lNiKc5INNRiLipOBACjfq3BegIAAA== X-CMS-MailID: 20170919092357eucas1p16a42cc196e27e100970312f17c6b33b1 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?VmxhZGltaXIgS3VyYW1zaGluG1NSUi1WaXJ0dWFsaXphdGlv?= =?UTF-8?B?biBMYWIb7IK87ISx7KCE7J6QG0V4cGVydCBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?VmxhZGltaXIgS3VyYW1zaGluG1NSUi1WaXJ0dWFsaXphdGlv?= =?UTF-8?B?biBMYWIbU2Ftc3VuZyBFbGVjdHJvbmljcxtFeHBlcnQgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-CMS-RootMailID: 20170919081803eucas1p255aac78e316693ea52c85e31bbfcc81b X-RootMTR: 20170919081803eucas1p255aac78e316693ea52c85e31bbfcc81b References: <20170907114527.26649-1-v.kuramshin@samsung.com> <20170919081731.23970-1-v.kuramshin@samsung.com> <20170919085619.GA17536@bricha3-MOBL3.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH v3] examples/l2fwd-cat: fix build according to API changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 09:24:00 -0000 On 19.09.2017 11:56, Bruce Richardson wrote: > On Tue, Sep 19, 2017 at 11:17:31AM +0300, Vladimir Kuramshin wrote: >> Current version is compatible with PQOS version 1.3 >> but not compatible with higher versions. This change >> makes l2fwd-cat example compatible with versions since 1.4 >> >> Signed-off-by: Vladimir Kuramshin >> --- >> examples/l2fwd-cat/Makefile | 5 +-- >> examples/l2fwd-cat/cat.c | 85 +++++++++++++++++++++++++++++++++++++++------ >> 2 files changed, 76 insertions(+), 14 deletions(-) >> >> diff --git a/examples/l2fwd-cat/Makefile b/examples/l2fwd-cat/Makefile >> index ae921ade6..a7fe6d68e 100644 >> --- a/examples/l2fwd-cat/Makefile >> +++ b/examples/l2fwd-cat/Makefile >> @@ -40,9 +40,6 @@ endif >> # Default target, can be overridden by command line or environment >> RTE_TARGET ?= x86_64-native-linuxapp-gcc >> >> -# Location of PQoS library and includes, >> -PQOS_LIBRARY_PATH = $(PQOS_INSTALL_PATH)/libpqos.a >> - >> include $(RTE_SDK)/mk/rte.vars.mk >> >> # binary name >> @@ -65,6 +62,6 @@ CFLAGS += -I$(PQOS_INSTALL_PATH)/../include >> CFLAGS_cat.o := -D_GNU_SOURCE >> >> LDLIBS += -L$(PQOS_INSTALL_PATH) >> -LDLIBS += $(PQOS_LIBRARY_PATH) >> +LDLIBS += -lpqos >> >> include $(RTE_SDK)/mk/rte.extapp.mk >> diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c >> index 6133bf5bb..9330b2d26 100644 >> --- a/examples/l2fwd-cat/cat.c >> +++ b/examples/l2fwd-cat/cat.c >> @@ -53,7 +53,11 @@ >> static const struct pqos_cap *m_cap; >> static const struct pqos_cpuinfo *m_cpu; >> static const struct pqos_capability *m_cap_l3ca; >> +#if PQOS_VERSION <= 10300 >> static unsigned m_sockets[PQOS_MAX_SOCKETS]; >> +#else >> +static unsigned int *m_sockets; >> +#endif > Does this check work right? The version number in git right now seems to > be just 10100, which would use the "old" path here, despite being latest > code? https://github.com/01org/intel-cmt-cat/blob/master/lib/pqos.h > > I will try and follow up with the maintainers of the pqos files, and see > how the version numbers in pqos.h are meant to work. > > Regards, > /Bruce > Sorry, added redundant zeros. The correct version number should be 103. But there is one pitfall in this commit 6a6d9ef0cae67efe63a394f09fa587b6fc8b1046 but for other case 103 will work.