From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 698174338B; Tue, 21 Nov 2023 09:29:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 380C440298; Tue, 21 Nov 2023 09:29:46 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id B96754025F for ; Tue, 21 Nov 2023 09:29:44 +0100 (CET) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SZHbf1Vv0zvPy5; Tue, 21 Nov 2023 16:29:18 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 21 Nov 2023 16:29:40 +0800 Subject: Re: [PATCH] ethdev: add trace for the new fields added in 23.11 To: Huisong Li , , , Thomas Monjalon , Andrew Rybchenko CC: References: <20231121081801.47098-1-lihuisong@huawei.com> From: fengchengwen Message-ID: Date: Tue, 21 Nov 2023 16:29:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20231121081801.47098-1-lihuisong@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2023/11/21 16:18, Huisong Li wrote: > The 'max_rx_bufsize' and 'rss_algo_capa' in struct rte_eth_dev_info and > the 'algorithm' in struct rte_eth_rss_conf are introduced to 23.11. > This patch add the trace of these new fields in related trace point > interface. > > In addition, the 'max_lro_pkt_size' in struct rte_eth_dev_info is also > important. So this patch also add it. > > Signed-off-by: Huisong Li > --- > lib/ethdev/ethdev_trace.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h > index e367d29c3a..1b1ae0cfe8 100644 > --- a/lib/ethdev/ethdev_trace.h > +++ b/lib/ethdev/ethdev_trace.h > @@ -32,6 +32,7 @@ RTE_TRACE_POINT( > rte_trace_point_emit_u32(dev_conf->link_speeds); > rte_trace_point_emit_u32(dev_conf->rxmode.mq_mode); > rte_trace_point_emit_u32(dev_conf->rxmode.mtu); > + rte_trace_point_emit_u32(dev_conf->rxmode.max_lro_pkt_size); > rte_trace_point_emit_u64(dev_conf->rxmode.offloads); > rte_trace_point_emit_u32(dev_conf->txmode.mq_mode); > rte_trace_point_emit_u64(dev_conf->txmode.offloads); > @@ -556,7 +557,9 @@ RTE_TRACE_POINT( > rte_trace_point_emit_u16(dev_info->min_mtu); > rte_trace_point_emit_u16(dev_info->max_mtu); > rte_trace_point_emit_u32(dev_info->min_rx_bufsize); > + rte_trace_point_emit_u32(dev_info->max_rx_bufsize); > rte_trace_point_emit_u32(dev_info->max_rx_pktlen); > + rte_trace_point_emit_u32(dev_info->max_lro_pkt_size); > rte_trace_point_emit_u16(dev_info->max_rx_queues); > rte_trace_point_emit_u16(dev_info->max_tx_queues); > rte_trace_point_emit_u32(dev_info->max_mac_addrs); > @@ -566,6 +569,7 @@ RTE_TRACE_POINT( > rte_trace_point_emit_u64(dev_info->tx_queue_offload_capa); > rte_trace_point_emit_u16(dev_info->reta_size); > rte_trace_point_emit_u8(dev_info->hash_key_size); > + rte_trace_point_emit_u32(dev_info->rss_algo_capa); > rte_trace_point_emit_u64(dev_info->flow_type_rss_offloads); > rte_trace_point_emit_u16(dev_info->rx_desc_lim.nb_max); > rte_trace_point_emit_u16(dev_info->rx_desc_lim.nb_min); > @@ -774,6 +778,7 @@ RTE_TRACE_POINT( > rte_trace_point_emit_ptr(rss_conf->rss_key); > rte_trace_point_emit_u8(rss_conf->rss_key_len); > rte_trace_point_emit_u64(rss_conf->rss_hf); > + rte_trace_point_emit_u32(rss_conf->algorithm); > rte_trace_point_emit_int(ret); > ) > > @@ -785,6 +790,7 @@ RTE_TRACE_POINT( > rte_trace_point_emit_ptr(rss_conf->rss_key); > rte_trace_point_emit_u8(rss_conf->rss_key_len); > rte_trace_point_emit_u64(rss_conf->rss_hf); > + rte_trace_point_emit_u32(rss_conf->algorithm); > rte_trace_point_emit_int(ret); > ) > >