From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48105A0C55; Wed, 13 Oct 2021 15:46:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D70CF410DA; Wed, 13 Oct 2021 15:46:55 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id EE6D2410DA for ; Wed, 13 Oct 2021 15:46:53 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="227387359" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="227387359" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 06:46:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="527032336" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 13 Oct 2021 06:46:51 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 06:46:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 06:46:50 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 06:46:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ii+mrDzVwYn4D4g3yYMiDpvKrE8wSqrNh4pKIxZLQR9WsbcCjQkuu4SCUvGZl2CNn9Ka0nXv8Ckk5cgOIJGtDChHn3FdVGUsZctXaEuI7MVUQPzja7Xz39ts6Q7JPpVsqFuuRIHJDFNhHyDATbzapVrmB/IcKyr2fkaQdCxTV7F8MCVXtimh9SzGIOUozuBvuaw/jy0vPMV6FN5iQ6mfbeROkTccCQBFlofN1rAW+EJST/S+0Yv8eQ2MqVbf5ExLWOux9ZlnnO6kei/K60pJpd/IeC52/5LsMRfCKP2EUZ2yz4G7m20wJK4baJxdGlhN4Mocn6Pw3R19EwqA52Pu8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=beuJ0d6IrpV77X3DLamtw2GgqrFoieUGL+90HS7m7RA=; b=nZhlRTgR2uA0KInCtvxwCvYWttvGDIXiV7Q38nQpjTouAy96CCtklDsIVuWqYn9oZ9sVT9+YBYFzSFpcGXITX6uY6NEyMPGm7QJG1HDlpB9XfKTHxto+KPGSbtTlvOEQ8mxwQBwK1nUHb6J2TaJi0OTN15MDaZgmF8Lqx/aKxjPEv8s2Vzp9qeOA+KD/0MfLqlbgV3wiSjtv2CRaLaAckGQ06JLWvsQXkp+ftkQOI0vemZNzM4nv435BLfhJ/nVU0E4K/FiMyROwitdayAmZt1asj499xwHDgWVmINKZmLic7pA4HhJVRRz/heOfIxteU4H/ZgjNhey0RKw2NU5W1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=beuJ0d6IrpV77X3DLamtw2GgqrFoieUGL+90HS7m7RA=; b=McwUMpgpPh6G8sRHueQvuKr6TfBY8EUzdGZiG9FlBbMbG3VWjoJ585WYoGX45qKv+6TcUuMGMuigRQ3z7IKcTzQLsk2o0jXeU7sff5ZQrEUcwFDchxZUa1IQPtwSuhWkLb6yvWRrNaOskiCskHLU2dZcF+Fez6T8Mw18vmOmLeY= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5914.namprd11.prod.outlook.com (2603:10b6:510:138::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 13:46:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 13:46:48 +0000 Message-ID: Date: Wed, 13 Oct 2021 14:46:40 +0100 Content-Language: en-US To: Viacheslav Ovsiienko , CC: , , , , , References: <20210910141609.8410-1-viacheslavo@nvidia.com> <20211012202557.30295-1-viacheslavo@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211012202557.30295-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P192CA0012.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::22) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P192CA0012.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Wed, 13 Oct 2021 13:46:46 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 232b88fb-8487-4c16-73d3-08d98e4fe738 X-MS-TrafficTypeDiagnostic: PH7PR11MB5914: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pj6E+FSbe0Yqlz+T1rUQsZKTvc09ZUetYuG8lJQ3D0xxKQpj5y95Iz7NKho8hqGJt9z0rNvDdhBHekN5o+SiOpM6csUtszvyDCvV4U085luw0qyzDBKBu/zAtQqQZCYdTjEtHIVsTyBV/LJasDbnzaz3altUknxnjcVI+3+cn2FyfofAOU4gpZ2cLpK1bgrBi4Xjo27+uoOfKM1xU2xQjLrnSZ2YESpL7pCuM1nR46MbFx3kxwW8L4K48fJi6Zqn7owdKQTZTUhuIolYLZZlnzZIb+PWusZ0ojGAwaHCdH/048Pw6rHx1H9o/WMdIJjGg3nN9lk5XFDxOGdmbm6EC76wOifLnmbQ+SrjUpCJ7/jzty0bdmO1ZLQ40wGmrXbglwvlGUvCaZROcu8CYgFwbsm6jc/GyCm7Hjxxoug6EONgtQkmAN6C5Uon3oGcmieETlfp8oaP3Fo/pJpp6ut5sl1oxaaW8QB2g3n+3bHm23GITtO2eKyt5g3GWS67V3WuTFN7C8fDAlkOUhPp/sWBysi+j1PssB8WSQRL61RLdOWIbgLFuHL9ubNUKEbMzSq37JK+tVsOsWZXk52Uk0P4LjXz5skwoTokSNXfQt7H7SXSRYTG8g+4Tw1Z2cACh7x1/gHD70J6qSJiKTAnGE82ZwMHY88FLVSMfgRPiO591jiXz7kh7PkFe/q1PQNhJVPfH5fXZtFe/qB23/Lay1/4zdHdW5aUlK4S4jPAlTdQbiPrheZeE7d4QrV5JsNmfHkEq0SWiE7gxzrnxfhm3cxg9le5mFcmKDCUiT4JZw9+XKqHpBpVXjhGPzHRP+drTW+cEc5+dqe/+PEFL0Ysbv71tA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4326008)(53546011)(38100700002)(508600001)(2906002)(966005)(316002)(82960400001)(16576012)(15650500001)(6486002)(5660300002)(86362001)(36756003)(44832011)(66476007)(26005)(83380400001)(66946007)(956004)(6666004)(66556008)(2616005)(186003)(31686004)(31696002)(8676002)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm9MNWQxZjQyQStlL0c1VzJlT2NUdk5Xa2tOZVJVVU1EYUJwTytWdXpiWWRC?= =?utf-8?B?MG5qdmRkMmVKUGFyTkc0VWMwR0UrY05NMUd6dnNRMFNxcHQzTml2NmUyVVpn?= =?utf-8?B?bWwxd2lqR2xOZ3g4RzNPMFRRQzI5bmVXUVZwTC9RbE05aGRaRzYxaWduMlVz?= =?utf-8?B?MEw2WXB0NzNCNVpuQzlpak8zZk11WVIzanJpc1VsLy9UZVMzU2cwTEU1UHdS?= =?utf-8?B?UFlXd09JcEQyRjI0ejU4R3ZCMFdUeFNsa0QvbmliZ0daZk15QmdOZytuMllW?= =?utf-8?B?RkJiaDVtWEZxYVZtL25nS1ljRG5sbUlSTkVydlQ2d3ROWDJSaGdTbUtHdlpG?= =?utf-8?B?ZmtvTEZsSFpBZmlDMTgyVVJsQ21EVCt3YlhMKzZEc0kvZ2I0MEc4U1VsblpE?= =?utf-8?B?RUlsM24zUG5VVWJGNkUxT1hER3YwaFh3cFVTWTRyb1pEYWx6cnJTMHlEYy9H?= =?utf-8?B?RVFvYTVlUWNhSGNQTVhwVXBMNXhYQkhNeGdoUW05TVpwbGFGWFR0d204UUxK?= =?utf-8?B?YTVWc3ZBQlRFRktuT0V0MXdHdTNMZmdRcG5yQjJ2UWdGZzFkdzRza0R4YUhu?= =?utf-8?B?M2xlNWx3OU8zRmtabS9VRHJPbVp1S2pnVUdSbXIxbHRmTTNIUEcyNG01eWZU?= =?utf-8?B?cHMrOTZjUm9YRXJWMDlxa2FlZTVsNDcxMmxrZndTWjk1a25nSVoxb0JRNHF1?= =?utf-8?B?L0UyRXZGV2NuOFhHM0MvS2h5NnI3VEZUWXpibXp1UDdRcGFmcFY2MXJ5eEM3?= =?utf-8?B?UHRseXFyWG81RU4yaytPN0tqS2lOSzBRODJUaTlNTjAveTJFdzdIRXE5UGpE?= =?utf-8?B?cmNDK3Z3bkxzeThIbXZXNmRsRDJyTkRVUVRsRXYzLzNCRktkNUwrR0tXS2Zj?= =?utf-8?B?WVYyMGZ3TXZ2UjNXLzNmTDNMSHhhclQwaTN0K3NyMm9UUWtpT2FaUjRMcFlF?= =?utf-8?B?cHBXeXdXMHc0akFqR2xLU2c4Q0hjYlp3VEQzUENza2dMeEloa3ZkNVIvMkt1?= =?utf-8?B?Y2w1eXNOSFc1VVB2NnRkWTJrcjRXajN3ckZITWRibzI4NzdWemVVQk9WcDJv?= =?utf-8?B?ZkpRYVVsVXFHTDIvbm84a2hVK3BRYWM0eTRZQXI1TG04dnJaTWJzQUJ6aVFJ?= =?utf-8?B?M0RxRVhNWCtZd0YrUUgrTktnVnFmRDhqQ2ZMcjZWZ05pMnJLTmc5RDJ3dGI3?= =?utf-8?B?dDFVN2MxK2tKZVNxdlJSRXpLMk5wWVBhUXlmcWVaTHhRWFZmQUd6Y040QnZ0?= =?utf-8?B?aFBVUmZxbGZLN2lzdmFmWThhOCtEekt5MDhETmZ4c0RrNXYzcC9SWUpOd0RB?= =?utf-8?B?WnhkSVFOM1ppTFIrbDZwNVdCczYwZFphcU1jSnMvNjVSUHZhbVI2UU1ra2hv?= =?utf-8?B?UGRSeEtWd0M3NXhLbG85cVF5bkNYUlQ3QTB5SmRvcCtzQjJ3NTJ2Szg3TnlQ?= =?utf-8?B?QzI4bW9FenphUmVIYVRPdlRLWjBYc3d5eVZDTGhZYWVtL2pEZHVwS2ovaTA0?= =?utf-8?B?a2wvWnVXSWZlbFNxWWYraGtHLytiMXRPc1oyNUJNSDRpRDg3bm9pY2JHQzBO?= =?utf-8?B?OWtiUEpTU0dGQkJ1MG5yY21sUDlycndlWXZKLzlsQ0thV1Q0RWxjazFqYzZZ?= =?utf-8?B?bzZ3ZkpOZHVtMDNXdXZlTVlzSDVldnNkSVlWZ3RJMFIxSkJrNGNEVThsWUpX?= =?utf-8?B?NVNJSlRiNm1JejcrRTBqWExLZUFMWSt6YUFGTndaQkgySy84anRRVjdnNkdL?= =?utf-8?Q?N7CofVbJl3RpU7MVuEPFQl+PGfP8EI0mzZ5Nol+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 232b88fb-8487-4c16-73d3-08d98e4fe738 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 13:46:48.4862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dBfMdnVjdIcxGnkgkdLViUEmLpC8iK00w7ts1C41Z045QewM2bGgd2brIBJVsLprh3nt6DkL2+UcLWXJqSGPGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5914 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 0/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/12/2021 9:25 PM, Viacheslav Ovsiienko wrote: > The generic modify field flow action introduced in [1] has > some issues related to the immediate source operand: > > - immediate source can be presented either as an unsigned > 64-bit integer or pointer to data pattern in memory. > There was no explicit pointer field defined in the union > > - the byte ordering for 64-bit integer was not specified. > Many fields have lesser lengths and byte ordering > is crucial. > > - how the bit offset is applied to the immediate source > field was not defined and documented > > - 64-bit integer size is not enough to provide MAC and > IPv6 addresses > > In order to cover the issues and exclude any ambiguities > the following is done: > > - introduce the explicit pointer field > in rte_flow_action_modify_data structure > > - replace the 64-bit unsigned integer with 16-byte array > > - update the modify field flow action documentation > > Appropriate commit message has been removed. > > [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") > [2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/ > [3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/ > [4] v1 - http://patches.dpdk.org/project/dpdk/cover/20211001195223.31909-1-viacheslavo@nvidia.com/ > [5] v2 - http://patches.dpdk.org/project/dpdk/patch/20211010234547.1495-2-viacheslavo@nvidia.com/ > [6] v3 - http://patches.dpdk.org/project/dpdk/cover/20211012080631.28504-1-viacheslavo@nvidia.com/ > [7] v4 - http://patches.dpdk.org/project/dpdk/cover/20211012104919.13145-1-viacheslavo@nvidia.com/ > > v2: - comments addressed > - documentation updated > - typos fixed > - mlx5 PMD updated > > v3: - comments addressed > - documentation updated > - typos fixed > > v4: - removed errorneously added Ack by Ori K. for mlx5 patch > - mlx5 patch updated - bug fixes and cleanup > > v5: - fix compilation issue with unused variable in mlx5 > > Viacheslav Ovsiienko (5): > ethdev: update modify field flow action > ethdev: fix missed experimental tag for modify field action > app/testpmd: update modify field flow action support > app/testpmd: fix hex string parser in flow commands > net/mlx5: update modify field action > Hi Viacheslav, The set reports build error on the CI [1], can you please check if it is a valid error? [1] http://mails.dpdk.org/archives/test-report/2021-October/227206.html FAILED: drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_flow_dv.c.o ../drivers/net/mlx5/mlx5_flow_dv.c: In function 'flow_dv_convert_action_modify_field.isra.123': ../drivers/net/mlx5/mlx5_flow_dv.c:526:30: error: 'item.spec' may be used uninitialized in this function [-Werror=maybe-uninitialized] data = flow_dv_fetch_field((const uint8_t *)item->spec + ^ ../drivers/net/mlx5/mlx5_flow_dv.c:1865:23: note: 'item.spec' was declared here struct rte_flow_item item; ^