From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38B80A0524; Fri, 8 Jan 2021 15:38:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AA61140F51; Fri, 8 Jan 2021 15:38:10 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7F0D4140F40 for ; Fri, 8 Jan 2021 15:38:08 +0100 (CET) IronPort-SDR: 8MuEPr+GySEQsdJavYek97T3piQ8yKbdi3IHVRSC95Xe2xsuvU661pKT227TsHeyHuvNPDremE Pfnfw72K0ffA== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="177751258" X-IronPort-AV: E=Sophos;i="5.79,331,1602572400"; d="scan'208";a="177751258" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 06:38:07 -0800 IronPort-SDR: Kogaa10tGs2zi1cWzfOrV1Mbj13Y1Qcl0RJklSnNhyrCQAjzFtXhXM4+Cow1Kg1pmZvj3VZwPI oLUv5l8Hpd+Q== X-IronPort-AV: E=Sophos;i="5.79,331,1602572400"; d="scan'208";a="399000464" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.237.192]) ([10.213.237.192]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2021 06:38:05 -0800 To: Tal Shnaiderman , dev@dpdk.org Cc: thomas@monjalon.net, matan@nvidia.com, rasland@nvidia.com, ophirmu@nvidia.com, Dekel Peled References: <20201217173037.11396-2-talshn@nvidia.com> <20201228123302.3608-1-talshn@nvidia.com> <20201228123302.3608-25-talshn@nvidia.com> From: Ferruh Yigit Message-ID: Date: Fri, 8 Jan 2021 14:38:02 +0000 MIME-Version: 1.0 In-Reply-To: <20201228123302.3608-25-talshn@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 24/35] net/mlx5/windows: introduce flow support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/28/2020 12:32 PM, Tal Shnaiderman wrote: > From: Ophir Munk > > This patch adds the initial flow framework under Windows OS. It supports > a subset of filters (ETH, IPV4, UDP) and a QUEUE action. It is based on > DevX mechanism to send commands to the NIC through the kernel. It does > not support steering rules (i.e. writing directly to the NIC memory). > The Windows framework uses the existing DV framework where file > mlx5_flow_dv.c remains intact. > > Steps involved in flow creation: > 1. Create a domain (RX, TX, FDB). Since domains are created by steering > rules and not with DevX, Windows does not require a domain object (this > means switch dev mode which requires an FDB domain is not supported). > 2. Create a table object. Windows only supports table 0. The call to > mlx5_flow_os_create_flow_tbl() silently returns successfully. > 3. Create a matcher object. A matcher struct is created by calling > mlx5_flow_os_create_flow_matcher(). The matcher validation and > translation are part of the DV implementation. The matcher bits that > were created by DV in standard PRM format are copied into the matcher > struct. > 4. Create an action object. The call to > mlx5_flow_os_create_flow_action_dest_devx_tir() creates an action struct > with the TIR type and id. This struct will be a parameter later in a > call to flow creation. All other action calls (e.g. packet reformat, > header modification, jump to flow table, etc) return with a non > supported error. > 5. Create the flow. The call to mlx5_flow_os_create_flow() receives the > matcher struct, action struct, and copy them into Windows specific > fs_rule struct, then it calls glue API devx_fs_rule_add(). > > Details on additional APIs: > * mlx5_flow_os_get_type() is called during flow type selection. In > Windows it constantly returns MLX5_FLOW_TYPE_DV. > * mlx5_flow_os_item_supported() is called before starting DV items > validation or translation. It filters out the OS non supported items in > advance. > * mlx5_flow_os_action_supported() is called before starting DV actions > validation or translation. It filters out the OS non supported actions > in advance. > * mlx5_flow_adjust_priority() is an OS stub for flow priority > adjustment. Windows only supports flow priority 0. > * Alarm API: mlx5_os_alarm_cancel() and mlx5_os_alarm_set() are > implemented in Windows to match their Linux counterpart, see [1]. > Currently they return -ENOTSUP. > > [1] > ("net/mlx5/linux: wrap rte alarm API with mlx5") Can you please provide commit hash for this commit, I can amend it later in the next-net? > > Signed-off-by: Ophir Munk > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad <...>