From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 882AE1396 for ; Sun, 12 Mar 2017 11:23:37 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB7AD81227; Sun, 12 Mar 2017 10:23:37 +0000 (UTC) Received: from [10.36.116.107] (ovpn-116-107.ams2.redhat.com [10.36.116.107]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v2CANXGE010231 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 12 Mar 2017 06:23:35 -0400 To: Yuanhan Liu References: <20170306082740.5675-1-maxime.coquelin@redhat.com> <20170306082740.5675-5-maxime.coquelin@redhat.com> <20170308024501.GY18844@yliu-dev.sh.intel.com> Cc: aconole@redhat.com, sodey@sonusnet.com, jianfeng.tan@intel.com, dev@dpdk.org From: Maxime Coquelin Message-ID: Date: Sun, 12 Mar 2017 11:23:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170308024501.GY18844@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sun, 12 Mar 2017 10:23:37 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 4/7] vhost: Add API to get MTU value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Mar 2017 10:23:37 -0000 On 03/08/2017 03:45 AM, Yuanhan Liu wrote: > On Mon, Mar 06, 2017 at 09:27:37AM +0100, Maxime Coquelin wrote: >> This patch implements the function for the application to >> get the MTU value. >> >> rte_vhost_mtu_get() fills the mtu parameter with the MTU value >> set in QEMU if VIRTIO_NET_F_MTU has been negotiated and returns 0, >> -ENOTSUP otherwise. >> >> The function returns -EAGAIN if Virtio feature negotiation >> didn't happened yet. >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/rte_virtio_net.h | 15 +++++++++++++++ >> lib/librte_vhost/vhost.c | 19 +++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> >> diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h >> index 926039c..ff02e9b 100644 >> --- a/lib/librte_vhost/rte_virtio_net.h >> +++ b/lib/librte_vhost/rte_virtio_net.h >> @@ -100,6 +100,21 @@ int rte_vhost_driver_callback_register(struct virtio_net_device_ops const * cons >> int rte_vhost_driver_session_start(void); >> >> /** >> + * Get the MTU value of the device if set in QEMU. >> + * >> + * @param vid >> + * virtio-net device ID >> + * @param mtu >> + * The variable to store the MTU value >> + * >> + * @return >> + * 0: success >> + * -EAGAIN: device not yet started >> + * -ENOTSUP: device does not support MTU feature >> + */ >> +int rte_vhost_mtu_get(int vid, uint16_t *mtu); > > I'd suggest to name it "_get_mtu", to align with the current naming style: > _get_ifname > _get_numa_node > ... Good point, I named it against the eth_dev's callback name, but it does make more sense to be consistent with vhost API style. > > Besides that, you should add an entry to the rte_vhost_version.map. Right. Thanks, Maxime