From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 260E6A0C43; Fri, 22 Oct 2021 15:28:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08F2F4114A; Fri, 22 Oct 2021 15:28:25 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id E382541149 for ; Fri, 22 Oct 2021 15:28:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="228067801" X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="228067801" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 06:28:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="445769349" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga003.jf.intel.com with ESMTP; 22 Oct 2021 06:28:09 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 06:28:08 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 06:28:08 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 06:28:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxqljFx0u4W/4Cz5uZ8Bby9eri6L3g02TlWAQ77VVxHm07R1PcGamto1NVo7bdrEKs8QuUcXLUnQHeIBoit+WmoX/oM4hALP18Krj70jFQyyl+7XtHxwS8g0Ro5PlgXMLXYg7JaPjcGrZ/0qixhFjuYj77tzcFsEjSSguV0VBJm8S0xVoLOGr+Ns7+3FwIAUrF08f13WYWo9hP2nyonngXO3O645OERGAqUrbHBqyfFbHGQ4txJf4OcYW4smiBm6lLiJ0JsSOv8FB+hOYIzS7VyqudBrJ+CK4oHiiYzWWjcCTkEf8o7jPBFQA/P1ktSAN+f5LUm8o4SsDxfsBEFNTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQo3hgMk2sLUSlo0r2+hYLwcnukp6L33h5ZZpFzfZmc=; b=ckf6Wa2ibUBnxKrqLC76pmN0md+b4cxPpOno8JALrmTTe+uGYLWJnIi70fsbxwy2KPgzK9pgZFCIZHsmExtUPVZGuYGk1tA5Xl4ZmuLQI4cUC8oIoby/v1cYyO0LvBxvXKonrpXhqRdtESzgIno4v1YfTPFr5MkpYZHzw7LXGB+SToLR5+2QCYSX0y0q9w7rzRmVKV0iUVdsjHbT3b5ZXNSNDeigrcux5Fhnu6OoFfQzuKh0jj9n/1H3pUbK9xMGEZixf0db0/EQn+C9PMZa0F1aeL0mizSkrDtXX4jA6Rq6u4OKxkL+V3po4xExO8nSQnTg0nbY1b3GzSYq6SHrMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQo3hgMk2sLUSlo0r2+hYLwcnukp6L33h5ZZpFzfZmc=; b=Q4qHt1KzFUC4ZH+ZeTzVRsuPKzA/Eb5tQaUPCfnvOToddrZuD8bFNARyeoiK7XXY2YDi9lr81NH5YxdUDUAENNlYMFH/4J1L1o36+TZQQUqvq0FP7pmL1jLppHE76ClVIcusPru6FGm8hVxjKMUV57FGFtrQIH4JsIpOxhKrIfI= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Fri, 22 Oct 2021 13:28:07 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 13:28:07 +0000 Message-ID: Date: Fri, 22 Oct 2021 14:27:56 +0100 Content-Language: en-US From: Ferruh Yigit To: Andrew Rybchenko , Thomas Monjalon , Ajit Khaparde , Huisong Li , Konstantin Ananyev , Rosen Xu CC: , Ivan Ilchenko References: <20211022101828.649441-1-andrew.rybchenko@oktetlabs.ru> <9c354744-c1b3-5254-7b95-00c3d035dbb3@intel.com> X-User: ferruhy In-Reply-To: <9c354744-c1b3-5254-7b95-00c3d035dbb3@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR01CA0010.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR01CA0010.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Fri, 22 Oct 2021 13:28:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10299cb5-83b5-4dc8-2818-08d9955fc885 X-MS-TrafficTypeDiagnostic: PH0PR11MB5013: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:751; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 65cYaZyG7cyYinfwkGMioPVKI9XqFrTu8zBbajc8KIM/S65CiX+0bOsJf9b6ESGvTtHOuDkCXJPXL2z6r0yQ4y7dhEGi+smuAZVnDuOLkQkdlLnSFPAK4CAJqq3CsDKhKJgSUFm4stYXkQxCh760SgkRIf//QAvKOE/MOpqYr0su3gcTth7+tDTyftSf3Yon71ypkYaw8/ifwFfEYLEhFSNypS9RmWx2h272Gxp+adzCOPdfFyOgjDuECba9owJDrkLDsNcLEJ4I7V8WDIdwyUO/dng2MA77+larL9EwJz9iyjgn1Kb7WQlnFlIOFdsxLI9xiLjXQzx2g6oyG/f9U9yYei5z6a3yDwfcacO+KmzrtEuMTKdGH65ZRGcz9YO0NdHjuSa1lr5NFr2KF+SmY7w4EqghSxR8diWaBSNC+3wWKxvRdSAduYxI6HIVkEdU6KFdnpsKLVpCDGdSVhKrn4tHG/INv40TPzt0tuAXHi8rIOYKlpGQxqzAMn4FK+LWPeQRoZO1r4PZoKtBH5UiVJeoB4UL9zby6GLA22oUTVn1n877EkUclRvfJDyH55Od9c+p42cRljwC35VuXdb5w/lrN/sQ07h1SNHi8/mFH4sT5o8xcUn+QOdGfCg0FdLp2DYV6ReNKGW8LkW1EaM4Pw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6486002)(4326008)(6666004)(66946007)(8936002)(2906002)(110136005)(66556008)(31686004)(316002)(66476007)(82960400001)(16576012)(5660300002)(53546011)(31696002)(38100700002)(36756003)(86362001)(956004)(508600001)(4744005)(186003)(6636002)(26005)(2616005)(8676002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OElXZ0NLVE5GN1Vxc210ZkVOb3FzZWh1U0Jna0xiL1pwWDF2L1BzYmxYR0tB?= =?utf-8?B?QjlSS2NNNjR1OXBDcUJLNHNoSjA4cUJZZVhWU0Jxa3lrbGprNENLUEVPbHd0?= =?utf-8?B?ZC9ScUxrcmFudi85KzVIODNWR1FUSDJrdHlUNkQ4cmdwWDRaakIzdUFoQ3Ja?= =?utf-8?B?ZDJKZ0t1Vy9jb1cvSmtjbGF6OGpYYnBSKzh5QUQ1dGt2SzNZNE84a2tiZTZO?= =?utf-8?B?RnNyL3BicXFGRkhXZXlFTXlnRVBHNGwybnB4WHRFWjdBREoxZ29oQUtreE4y?= =?utf-8?B?bXBvYmpXVzZUSWRTTmNPK1IweXM1bnl6dnpYRXRMRDJsakw5WjRiQkdYT1Yr?= =?utf-8?B?M21UTVBlU2hFRldoWlh1TGNiQ0ZiQ3czOEg3VXlFSXFTTDl6cU5Vc01USmtC?= =?utf-8?B?cmFFUHdxWUkrQnQzbFI1TDZ5bXdGemRkTk5qay92U2xzU3hlUm5SektDTlpY?= =?utf-8?B?Mk4vUXozTVdNOEdQcHUyai9sampheVVDRXZzQ0tkUFFLTGVobzhOa2ttck1H?= =?utf-8?B?Q2QwZ293WUxtSXQ3d1ZCMmlEWHZQbHN5Tkc2YmN0NGE3Y0luRWtKUUVPYjdo?= =?utf-8?B?RGhDUHlmZFBGS0ErQlZWSnI5RUFQSGdvbCs4TWhOa3NDM2hncmRQcXZsSmsx?= =?utf-8?B?Y3pkS3d0S0FxTnFwcEczeFRRSytDZUJvdWdrWHNBZWh0ZU02U3hIMklPWGFq?= =?utf-8?B?RTYzc3NxQWtCT3lEclhwdGw2SWViTzZEWnl3L2ZUa1crRGQrZWdiTUkzL2p6?= =?utf-8?B?T2ppTitXUGFoOU53ZkEzcGVYblp6dHB0Tyt5VGxoTnhLUmRKUWY2bzBwK3lV?= =?utf-8?B?ZkhhOUxUb1E3ZFhMRDdmM21rZFRlcllXSmc4ZDZoUkJ5clFXOWtSV0ZtVUlQ?= =?utf-8?B?RGYyRmRWblpNSWw5STRKcVZtR0lVcWcxTk5UQ0pqb1dyTHM1bHUycEpYckdI?= =?utf-8?B?UkhFeXpDQ1ZETHN0WHlZc043VnpDZS9FT0M5WGZkOHR2ZE5GYUk5b2VCUHU2?= =?utf-8?B?Vk8xOHYxOVhuWk5zMUExSGtudGVZL2prS3BkK0NHUXQwS3NtNlkweVR2bWt1?= =?utf-8?B?ckN5R3Z1d1UwckFrUHlTWkhCWVRXRE80MWRvUkQrWmFwbDVadytqUldlaDFT?= =?utf-8?B?RitnZ3VBT2J6TXFuNmI3U2hsQjdTRGphcFM4a1Q0KzEwaDJNUXBOMERGUTVT?= =?utf-8?B?K3pSRVFYc0M5VTM4akNsbDk4SWQ0ei9OQjZMSTN1QkdIMVUxYWNLYmpBUnB2?= =?utf-8?B?OXpHTzh4dmNRTUJrTUNZUE5DYzlyclU3YXAvc2Y0VFJBMytZK3psRGgzQmxv?= =?utf-8?B?QVF2OTJBaFZ4aHpsYWlXUjlOR2ZHbUVLWjZmRmpJS1VqYXo4bGVUc3pyTGN5?= =?utf-8?B?eC9UdytXeVFSKzg4UHlxUG12QXNvcjFRZHpmYUVjMS9xdU51RDFJcE5UY1VS?= =?utf-8?B?SDVQRjUwc3BNVS9KaC9JUWIxdzg2ZkIwQVhzajg0dml3d20yVExDMkg3V2I3?= =?utf-8?B?enlRM01lb2ZNbDhRTmZxdmVKV3dETlhlRzc2MUdKTk5ldWlyaUgwWU9idk1L?= =?utf-8?B?eWp4S01qRDNxVjg1S3RSQU12Sk5WaElkamo1ZE1qNDVETVh6aE1tcEc0LzNa?= =?utf-8?B?amx1eFFhUkZIN3VDeEpFV0k5dUU5dE1nY2QxcGVkZ3grc1dUY09IeXREcHgz?= =?utf-8?B?ODV0Q0J0ZEMvZFNMZTVwdEVmanBmK1g2Zno1NUxUbnZBeFdmeVZ0RlUxTGFB?= =?utf-8?B?MGlNQjBpMXEwZkgvQW9QbmJlWXZ3TUZBZ2YxUUg2ZFBuZ21QeXlVbk1YUUFX?= =?utf-8?B?c1BPbytZb24wTXBtbC9mRFhiUmF1KzNpTHVDcUhEM01YVndwU3pHekVSRVNT?= =?utf-8?B?MWlaK1lhN3NQVHhDTHJDL1FRalRrdzZkRkNzNHZUU2ZNbDlDYTBPS3N3ZTN5?= =?utf-8?Q?QtfeLkzsV/KRLnDVRJh2NoWpY6yiUDjn?= X-MS-Exchange-CrossTenant-Network-Message-Id: 10299cb5-83b5-4dc8-2818-08d9955fc885 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 13:28:07.0696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5013 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 2:21 PM, Ferruh Yigit wrote: > On 10/22/2021 11:18 AM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> rte_eth_dev_configure() always sets MTU to either dev_conf.rxmode.mtu >> or RTE_ETHER_MTU if application doesn't provide the value. >> So, there is no point to allow rte_eth_dev_set_mtu() before since >> set value will be overwritten on configure anyway. >> >> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") >> >> Signed-off-by: Ivan Ilchenko >> Signed-off-by: Andrew Rybchenko > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.