From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E402A00C2; Thu, 23 Apr 2020 10:49:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1304F1D54E; Thu, 23 Apr 2020 10:49:41 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 902AF1D513 for ; Thu, 23 Apr 2020 10:49:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587631779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FHR1Pdj0v54o8G+ih2Q5DblK4X7wn01VbcUce3Kq34g=; b=CcR6NE8YZG13aoAQ5XOacJ/dGxSJHrOnRKfb4Yxz66OPheTbGs5wI1+ipZPOu1Q3w0yQV+ 6QMTXDmLFE45mMsHN9Uj7OBRLnaxJdXUiX+AxqTTproGSPbFS2Rp1lJ2HgQlojPvxJCUUV sCr70sQGlLyqPXu1jC7IiLC8q6b6dc8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-MTw7bAggOWC_u7MHAEjrCg-1; Thu, 23 Apr 2020 04:49:37 -0400 X-MC-Unique: MTw7bAggOWC_u7MHAEjrCg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47B10800C78; Thu, 23 Apr 2020 08:49:36 +0000 (UTC) Received: from [10.36.110.50] (unknown [10.36.110.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 51AEA5D71E; Thu, 23 Apr 2020 08:49:34 +0000 (UTC) To: "Liu, Yong" , "Ye, Xiaolong" , "Wang, Zhihong" Cc: "Van Haaren, Harry" , "dev@dpdk.org" References: <20200313174230.74661-1-yong.liu@intel.com> <20200423123106.78513-1-yong.liu@intel.com> <20200423123106.78513-3-yong.liu@intel.com> <8fa86b57-e791-807b-9887-c8fd81f62c47@redhat.com> <86228AFD5BCD8E4EBFD2B90117B5E81E635420B5@SHSMSX103.ccr.corp.intel.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: Date: Thu, 23 Apr 2020 10:49:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E635420B5@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 2/9] net/virtio: enable vectorized path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/23/20 10:46 AM, Liu, Yong wrote: > > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, April 23, 2020 4:34 PM >> To: Liu, Yong ; Ye, Xiaolong ; >> Wang, Zhihong >> Cc: Van Haaren, Harry ; dev@dpdk.org >> Subject: Re: [PATCH v8 2/9] net/virtio: enable vectorized path >> >> >> >> On 4/23/20 2:30 PM, Marvin Liu wrote: >>> Previously, virtio split ring vectorized path is enabled as default. >> >> s/is/was/ >> s/as/by/ >> >>> This is not suitable for everyone because of that path not follow virtio >> >> s/because of that path not follow/because that path does not follow the/ >> >>> spec. Add new config for virtio vectorized path selection. By default >>> vectorized path is disabled. >> >> I think we can keep it enabled by default for consistency between make & >> meson, now that you are providing a devarg for it that is disabled by >> default. >> >> Maybe we can just drop this config flag, what do you think? >> > > Maxime, > Devarg will only have effect on virtio-user path selection, while DPDK configuration can affect both virtio pmd and virtio-user. > It maybe worth to add new configuration as it can allow user to choice whether disabled vectorized path in virtio pmd. Ok, so we had a misunderstanding. I was requesting the the devarg to be effective also for the Virtio PMD, disabled by default. Thanks, Maxime > IMHO, AVX512 instructions should be selective in each component. > > Regards, > Marvin > >> Thanks, >> Maxime >> >>> Signed-off-by: Marvin Liu >>> >>> diff --git a/config/common_base b/config/common_base >>> index 00d8d0792..334a26a17 100644 >>> --- a/config/common_base >>> +++ b/config/common_base >>> @@ -456,6 +456,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_PMD=y >>> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n >>> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n >>> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n >>> +CONFIG_RTE_LIBRTE_VIRTIO_INC_VECTOR=n >>> >>> # >>> # Compile virtio device emulation inside virtio PMD driver >>> diff --git a/drivers/net/virtio/Makefile b/drivers/net/virtio/Makefile >>> index c9edb84ee..4b69827ab 100644 >>> --- a/drivers/net/virtio/Makefile >>> +++ b/drivers/net/virtio/Makefile >>> @@ -28,6 +28,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += >> virtio_rxtx.c >>> SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_ethdev.c >>> SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx_simple.c >>> >>> +ifeq ($(CONFIG_RTE_LIBRTE_VIRTIO_INC_VECTOR),y) >>> ifeq ($(CONFIG_RTE_ARCH_X86),y) >>> SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx_simple_sse.c >>> else ifeq ($(CONFIG_RTE_ARCH_PPC_64),y) >>> @@ -35,6 +36,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += >> virtio_rxtx_simple_altivec.c >>> else ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) >> $(CONFIG_RTE_ARCH_ARM64)),) >>> SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_rxtx_simple_neon.c >>> endif >>> +endif >>> >>> ifeq ($(CONFIG_RTE_VIRTIO_USER),y) >>> SRCS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio_user/vhost_user.c >>> diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build >>> index 15150eea1..ce3525ef5 100644 >>> --- a/drivers/net/virtio/meson.build >>> +++ b/drivers/net/virtio/meson.build >>> @@ -8,6 +8,7 @@ sources += files('virtio_ethdev.c', >>> 'virtqueue.c') >>> deps += ['kvargs', 'bus_pci'] >>> >>> +dpdk_conf.set('RTE_LIBRTE_VIRTIO_INC_VECTOR', 1) >>> if arch_subdir == 'x86' >>> sources += files('virtio_rxtx_simple_sse.c') >>> elif arch_subdir == 'ppc' >>> >