From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA7B945D32; Mon, 18 Nov 2024 20:59:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D7FB340EE3; Mon, 18 Nov 2024 20:59:25 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2067.outbound.protection.outlook.com [40.107.243.67]) by mails.dpdk.org (Postfix) with ESMTP id 408FF40664 for ; Mon, 18 Nov 2024 20:59:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hZlR/HFcRVrBwAd9ylv/xR4uygU2QR179yPAHx1HuuZ7uMK6Qbt6+rBPriNMiy4c2paUIVa8zADN9Oa+r4dmfw6ZIEHZHGdpNQ8DuaYufFeyk9tEsFv/s3BR9aylrzkS/LUPuuq4433erzqHZWqgOv6boZ7wis5rKsRc8fI/ZrF0WH+otdABT86mfCGOJXkNevGZeTLcg8yWIlHZ+jW6kRrCw0C3/Zn5jgyRI/GEGl/T2jLIBO4kNqNCI7Puea0k1svImaXwq2mjvSpJcQi3s5z4S7QtBrzGTK7KMTk7kTWaWrwUBGdpodABNGyqGzUVEcShcNJfxiF3MQfZo6kSng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3E7UXQyT8VOF8r+XpqpjEkoLVqxIOYPdY5/fQ3II/lM=; b=iZYLPXJHohHO7gfUY8wZ8UJQINtZ64RD4UcUt2wk0lOHVU4Zd7dgQ4oHfuBwbC5M8YdgqyJU07azUmSWNmwjy6iTN3OoUqQgA/swHJ19v3H4aBDmRgcFkZEuPCDNm+JAUDAo8g/2FKFNPBAKjh6odCtLWESZt/Q/GFS67j8g43fdo6/1VlZ7a0PZ2lCDFqxhEjmBwT8ilp19lvPg8Cx+m/XtLdxzyu8F54mtcU+G+v04+CNA6d5wKbFNlVv3qDepi/f2fA+yntpIbI8GPY5qSuzOxXrqsu0yGW9T+OTHQx/6kayC2rVbvwXNgrHCQu1mp2iEbZEtozatOBPX/j99/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3E7UXQyT8VOF8r+XpqpjEkoLVqxIOYPdY5/fQ3II/lM=; b=uRZdymhUFpRBCE19l4BGcCfVbdIVXf3al25RIu5hzLJ4ARNvsa3dWEKNO4E7tam3adG6bb68EbaeLwGo85azl5qCN1mxHRaP5Wlyr6d5LaqVhQKj/dR/v7xJudKyAU3E1/yWH4NU9XdSO46RUn4WT18WvdSgVIV/cQXYoW16KO8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by PH7PR12MB5903.namprd12.prod.outlook.com (2603:10b6:510:1d7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.23; Mon, 18 Nov 2024 19:59:22 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8158.021; Mon, 18 Nov 2024 19:59:22 +0000 Message-ID: Date: Mon, 18 Nov 2024 19:59:17 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/txgbe: fix a mass of interrupts To: Jiawen Wu , dev@dpdk.org References: <20241115083336.1195101-1-jiawenwu@trustnetic.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241115083336.1195101-1-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0049.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::13) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|PH7PR12MB5903:EE_ X-MS-Office365-Filtering-Correlation-Id: ed125985-babe-4c97-f034-08dd080b7e93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MnFRckgxL0tvY0dkbUFwSnBEWXhxSFB5MU42ZldyOEVaQ3JMNHYwNWxlc04z?= =?utf-8?B?eGp5emlrK1pQa3E4MFZJSU1rbm9PSURudjdtYWlsV0NXZjRQQmluV0ZNWU5J?= =?utf-8?B?eXVPVzN6RWlycFo1QWNYc2JUNFY3SzZ3NVRxMWFadENDd05GcTFJalpqcmdm?= =?utf-8?B?dXJLTEs3WnZ0ejNYb1NZbGRTN0JJUTluQitqVFlBa3Q5R3JNTjNPM3YvZkhZ?= =?utf-8?B?Y3lxR3NEbVpiNC9NeHQxaklyNkxHaDlVUmp6SDQvazZLMEQydjZ0SFBjU3lD?= =?utf-8?B?UW5hQzJBY2xuOExndDR1dGxJWVlsRGRqbzRwY05oQ252ZTN5T3piczNyOW4y?= =?utf-8?B?ZG5sbUROVlYxV1grNDV0ZFJGb3JIa1UxdjRUbUM0VlFKZ1o2djZRUkJBYWEy?= =?utf-8?B?RmlkQ1VDbFpBNjhvT0s2M1RIcGNkVG5qQnJlbm5pT3BoOXRzdnhSekRJNmNG?= =?utf-8?B?Q1dhd2tObWhPdGRXWUtlUXVPa29IWFVQTjJpeFVPMGdaSWRCQWNIMFNJVmFZ?= =?utf-8?B?L0tUNlpNaklWa1ZoU1hNZjlxekttSGQvWWJIcG5jcmZnZlhHaWRkTmYyWEN0?= =?utf-8?B?Q2F1TFZVck1OSEdLSTlIZUlSZHdVanIwcTdjbFNmZFZvQ3V3YVJ1ZkhxNStw?= =?utf-8?B?dWthd2tlcTlTVWw4b2lHbnpvQjB3a2ZDSmhSTnNuMnZ3dWgwVHBmQWx5WXBM?= =?utf-8?B?TVdFblhDQXRkdGo2NTZjOTVEejlVZ0x4cXpQWkcyVFF2YW42VXhHS1BRYWY0?= =?utf-8?B?L3VmK2c2cUFLQmVoajlyaVV3K3llZ0tQM0dwaWJ0YWsrNFhaTmY1T01xQXlK?= =?utf-8?B?S3UyektNQ2RpRlBmSzE4czd4ekZvT2F4d3AyMUk3L21oRXVnTmdJNThtdWM0?= =?utf-8?B?SmVyaVVPb1NCVXY3SkJoN3d2ZUtZY1orWGRHL1NKUk13ZC9LbXZ6bE5EWTdt?= =?utf-8?B?OXV4TjZmT0pRcTY5WUR4QUcvRjlWd3c0RVBtSnJibnZMMFprNHErc2xFTEsx?= =?utf-8?B?U2FqSXNpZSs1bDJsazN6Szh1MmJFaDlCVGc3OFJzS3pTcW1iSXZtY0xJM3Yw?= =?utf-8?B?UkIvTmJZY283cElZM3ZoUElYeU01ditFUGFXTGM1SEd3d0dNWVN2NXoreXNp?= =?utf-8?B?dzZqNDVMNndQQko3Y241YnhoVnlKNHBzM2JQelFvU0JJblc1VktIRlFXUTN6?= =?utf-8?B?ZlFCMk1iOEpJS3R5TjVBZ1BNclhjOVhnblBxR29uZ25QS01kMGtYVGpqUFdH?= =?utf-8?B?R2hoS1Arb0wzQWp5d0ErMG5JWUFZc3RJMHU1blFYSDUrT1dGR0xzMVlPRXpE?= =?utf-8?B?ZlhPakVJcnlGVmRKN1BpcnUzeUx0dEJna1pIWU9tL1Z6eTFlK0pyUzBhc01Q?= =?utf-8?B?a1J2V2w4Y09VRXl1R2tvRnRZNnRBVWtEcFh4cWlESVVqSkxaNjV3blBrL3do?= =?utf-8?B?bGNRTmVnajU1aEtlL3BsQW9BbStYWm1mNkFYbmVpVDdqUWw3VkhrN1ZLd1Nz?= =?utf-8?B?MW9MUE1nemE0U3llT1FHRGJCQys0akZ3b3JTYnByaEh4THZwalJnQzVvN1oy?= =?utf-8?B?cE1Qb09VcWZWaGRpTGhrMmZkUVQ1dlNQbklEL0YrdmpwajloaWxRcFZlN3FV?= =?utf-8?B?bnV6cCtYVlVIZ3IwUlhaQjJ2QnZocThSeTI3ektxeUhRMzg2NjZoS0h6bDhw?= =?utf-8?B?TW5JK3pURGszdnJhZVJBMW80WndPaFVIL0x2aHpObEhhZnJnSmtNSSthVG5V?= =?utf-8?Q?Dw523yxxzRtvZgsnYgQYWshr5REOQAtiCZoj5YQ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1NSeTdMdkZRM1ppV1htMUFaZ1FHOExpKzZwMVkycElyVSt6d0t5V0JFUU1u?= =?utf-8?B?QTl6V3NCTUNzR1lpVWhna2JoUWVvMFZRcTVJbExIOVVxVTlnZWFPL29paER4?= =?utf-8?B?MDFmTFJ6b3ZWWHFURVFuOFJiT0ZERzdxcjVHZWxxOUNMOXZwcjBFVUVES2U2?= =?utf-8?B?UVlEZFR4YmxSUzVsbU5vditHUVI2L0ZRaGc4ZWd0dnZhYzZrRmhQb21pZ0NG?= =?utf-8?B?VVRPQkcwdzZaQ0RWQ1FMTGhqNFM0UFh5bjdBRXoxYlVpcjl0dlRQdzRXQk85?= =?utf-8?B?TUxwN0dZRHpRVWNVelZXNUdVaWg3UEE1Z28ycUFNUkJrcmpOQVYvTFhadDNG?= =?utf-8?B?aFhkM3RDSjE0aGgvRWxDSVZXZk80WTJIcmxPUUxqY01BcThISm5tUjRBcUFF?= =?utf-8?B?ZGV5NWJOa25GUXhyYTNaSC94M2J2T2pZc0RtdzA4d1VoWkwxU3pEV2lmSHA4?= =?utf-8?B?NG1BcUxiTnltbmc0R2VQbmt2a1YyVDJGamNUZFNTVU91YzU4WUdUZ2dDeGJZ?= =?utf-8?B?UWQwNmZaT1B0enlldVpmU29SblpsYXdsOG1qbkUwTStSOVlCekMwUnJ0aUVD?= =?utf-8?B?L2N1VnUvQVJJZE93dU80V25WOXh5ci9YYVFRWjNacGovQmdLVXFJYk1kTG12?= =?utf-8?B?SUEzMW05RW8wc0Q3ZVl6Tmp4cWpmYmw3NHV0d2J4OWpUN1h1dThsVzlTNFZh?= =?utf-8?B?TllPNXJSY3RGYUVIWDlwR0EyS3RiWHZkNWZkZjQ5T3QzVU5lbHdpQmZjcG1K?= =?utf-8?B?c1pCZmlzZUNFZnhScVMzSFBRUTF4ODBuTEZ5dDFNdXpuelJ4NDJGZlVESW11?= =?utf-8?B?MVJ0R1JjTW4rWVhpU2tXQUpaL3BhVEk3UnVGQ0VQZ2Z5dkdLNUwxRWllUzBq?= =?utf-8?B?ekorS0dGR1AyVTNIWFFRNVhPREQycFhRUGRva3pLVmpqdTVycCtIL3NrOEJq?= =?utf-8?B?bXN5Qmo5VU1POGMrYlJqSVlwUzYzVGF2WFcwOFcxU2R1MjljU3RZcmQ2NGMy?= =?utf-8?B?UGlQR1NEMTBzUXBXRjZPVmYrL2FxZWRTMXhUektnWURHUXkrQUh0TXppbmNQ?= =?utf-8?B?ZWhrTk42bHhwRnd5ODdDa3hDMEFuK3MzbU91K3VVTURhTTBxempsWVpyd1N3?= =?utf-8?B?VEVHU0JJNkdicWk3UEpZajlCMkdRUlA5UXJodFNrNzk1dFE1VytXSmt2MVJ5?= =?utf-8?B?aWlqTUhWemQwcTRJbmF6TXdkbUNQa1hieTFGRUoyNXJFRW1KZ2JnV1dGYThu?= =?utf-8?B?Y1NBQzVYR2llcUVGcGJCT0ZhMS9PLy9raWdLWSt0NXFOakNpU0lCSVR1enAz?= =?utf-8?B?c2lYTlpMbCswbjhWbzI2K2ZmQ1VJdVhUbGgrbDhTS1liaVphNEkvTWd4R2lG?= =?utf-8?B?VitXNlpYZ2VXdDFOSEE0bXR5bWp4ZnBtU0RJc2xHRXloL0Y5Q2RUOGtxQk1B?= =?utf-8?B?cXBmOXJrVGZ0MW1qSllkSk1VbW45WEI0M3VCUlFPZTdIUEs3TjJJQUcvQnBq?= =?utf-8?B?Sml0WG1zaGNyYU11SnNpQWNGOWJiSE9HY1lUU0tza3hZZFd5TWJiYXRYNGFV?= =?utf-8?B?dzFGN2FEeHpady9GZVpXTXlRSC9ua2xSdk5tMUJpU3pNb245RWVIOWdvNURh?= =?utf-8?B?R0dzWU0wbjRtMWtNVFF6NDVBbGJGeTdjeFZ2N3pSM2h1U0xaOTMrMTVkaHJa?= =?utf-8?B?U3k0RmVwemJ1dWxZcm9MVFN2MkwxQnBwN0UxT2c0dHFtdVpLckgwR2oydjlT?= =?utf-8?B?UHRZTkVJT25nRXEvOUErbHpIdjF3bnRxRjR6Qkd5UkNtSlJOUFp0NXlCSEow?= =?utf-8?B?cjVtZmhpa0RRc21LcUV2Ritxc2poenNQME1jRmYrMGxHNlNhdWZaYSsrQnlo?= =?utf-8?B?Syt4cDN5bStSZ0c5YlVXOXZLRG11NmU5MDBjRXpLUFJEVFlxMS8vK2x0MTI1?= =?utf-8?B?VExPWkJJdzlZRXdNZDNwTEh3Vm1yaHNHbmRwK2t4UXFXTEtSaTZPejlDMGFp?= =?utf-8?B?a09IQkJhN1J1UTJRaXlRNWJZanJPdHVSSGZURjFrZGVxNG1rQ0RyVEdGZHA1?= =?utf-8?B?YUdSSklMb0pSdlV0cHdBV0x5ejBqYlQ2SUxXdUhMZjEwYk8ybndwMjNMSGkv?= =?utf-8?Q?QGIXFWXZTNzqGUvRkoGneUyno?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed125985-babe-4c97-f034-08dd080b7e93 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2024 19:59:22.1018 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ERIY2/+RVWLM93Mr8VHclgabrG418grsdkpXBFHzqY8K/8vJSYLOqnJv4vKAYgdL X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5903 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/15/2024 8:33 AM, Jiawen Wu wrote: > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity > is set to 0xd by default too, which means these interrupts are rising-edge > sensitive. > > So when unplug the SFP module, GPIO line 0 'tx_fault' is 0 -> 1 triggers > the interrupt. However, the interrupt is not cleared. And GPIO interrupt > mask is enabled and disabled to trigger the MISC interrupt repeatedly. > > Since this 'tx_fault' interrupt does not make much sense, simply clear it > to fix the issue. > > Signed-off-by: Jiawen Wu > Hi Jiawen, Can you please provide a fixes tag? Also I believe you would like to backport this fix, if so please add the stable tag as well.