From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EA4EA0548; Mon, 27 Sep 2021 13:52:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C90A4410DA; Mon, 27 Sep 2021 13:52:49 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id A3F8040E3C for ; Mon, 27 Sep 2021 13:52:48 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10119"; a="224110716" X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="224110716" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 04:52:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="553161847" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 27 Sep 2021 04:52:42 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 04:52:42 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 04:52:42 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 04:52:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hHM4HxHWRswnIJmm6L0yonmsH8g/I+LuOnFycvfqw+b9IPq+Y4WHHyjs1IIo1Bhg9qiWtrhsEozi4zYpRNxbxzatCQ+Sfzmc5pZQQJed2AakOpPHYzhzWy1TL3tni6fUXQB4sVS+qPvK/fxF/gjBcGYzEWgOCfhDSII8Q/5hAaYEtb2HdznF586YJLb5pqVvgS27wsniq4XktA8J6bQR4oAS3vfDakabkH7XosSxlGaMcrOlQ6E+IL4zoTnZaMSrmva4tzTqXLJ/Lzh9oph3hOa6E5u/1sZE5qRfBLv9mYgZejQlFo0oE7bZICPgw6hU0qX3Wi/GRSg61LFggfbaeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Apct7yzKxWeVzEBrMerzraotYpMvTH5LmzKZwnNy534=; b=THAJZiZIIFCr4uJYBkHpK9l4vMpOb8SdE2HSRCvqoEBVuERp0FAzmJJ9xZoPIemeBdc8Pgl2aYPyxnZJ7AarsT/HqemBlqWAjrv+Hu0RJDdeVRMeA+nckm4gdPRfFnfr8HrT9ruRQUR8yEqXD+5trQkUhZ5xARezQhMfUWXJ7kL22TXyv73e2x8FACnwpnNR8EOMRj8M19wDct89dcwzIkcGUF1W0pyddgQlcgqGD+cF8LeX8r8P5+NRB4fVRwMcZxEhBaRUA19kLlCDStW8fDKSP8vPnUG8aPXQLvX+BkXJcR3tjxjeGGS0ggMuJDFrXbpOgbXsQKe/C2bNo1joew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Apct7yzKxWeVzEBrMerzraotYpMvTH5LmzKZwnNy534=; b=g12vDYE+sG6MzHuZDEEhmy/co6XYdLZohepFgqLCdzxcP8rOl4k+lNktxQ0TIWhpx+IolEE2uj5Vc4SoEP1OyEn+xsAfR/LhD5bP9iTI3zv+zVA1XMk98mkQHL6UghO2X26TbfPGu3tg6+mtPmutuIBjNMSebKLpnT+uI8jJniM= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4872.namprd11.prod.outlook.com (2603:10b6:510:32::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Mon, 27 Sep 2021 11:52:39 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 11:52:39 +0000 To: Kevin Traynor , Thomas Monjalon , CC: Andrew Rybchenko References: <20210830104232.598703-1-thomas@monjalon.net> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 27 Sep 2021 12:52:33 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR07CA0071.eurprd07.prod.outlook.com (2603:10a6:6:2a::33) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0071.eurprd07.prod.outlook.com (2603:10a6:6:2a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.7 via Frontend Transport; Mon, 27 Sep 2021 11:52:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9fd0e688-95b1-4069-b8b3-08d981ad4e17 X-MS-TrafficTypeDiagnostic: PH0PR11MB4872: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ei4RfBB4VglB3PWOJv005DzhSC+ybGT7IpwVIsAQhZsleqyQ2j1vyP3YlXzEy5bltiIMR1nPy6FbN9RNB6O22XJkOvvcU8F4P4H84Ou3tbD2AY1rHLk15ZNpb6W7IwnGa0ConLzroUVOMo/GAo3JYILzVaXmzvdQ79DuqwcWN0YrS4J4RKk38udeZf16WNcND7OcBiQ3sB6d/5zvapiwwIdDCpRYCq0JU8xZ4VceGHmkgusE3WbX6JKHIaDI4RbOM5lY3zrEp96DNPIS9wrGm9wPAj6q/wHUZbCFM5dlsqyX/ZfQyNlf+4HN3eeo9ojYWuMEsZqrcvOdnal3ceutkEvHDP//fzo5AZP4m8wJKXi8qNdUMFEEEuqiUsIIF6HNJmNphCuq0oAsbb8OAEMbij8nEFrNl0QUdhlq6rJWYSM/qnl6BGluleSQAiupFSBghCYLo/1DtIRW29p32uYOq159A2OYoqj0MHjNd8K2ZjG04f1vqEMSXOkdkrMYs0GXR3lFdVk8yGAnQlu+Ausr1hMAfDdgHKyWDFX0U5tLSpJkS6Pe62y+Hn6Ti1QbJKUUP4Z8ts4hAlMmALrtqSCWM3wjnlXxJ+MXP7WB/OrK51x8wOnh5Ck5ZjEdRnP/xUBxz/SjinWdBgiUoC56NKlsy+jhMlWzFtutwUSj+iwspoSRjgb+H8nYoxgj0dXB0UWrmsh7hjThA6AX8cAha8NKJA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(86362001)(316002)(31696002)(66946007)(66476007)(53546011)(31686004)(8936002)(2906002)(6486002)(16576012)(44832011)(110136005)(4744005)(66556008)(4326008)(8676002)(6666004)(36756003)(5660300002)(956004)(83380400001)(186003)(508600001)(2616005)(38100700002)(26005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zk9zODMrNyt6RUZ2SitNaUZmRzFXZHNmN0huc05jYm9KR05YMG93Z3NFUFFu?= =?utf-8?B?NXc5RUtUaElwRmFYZ1ZBaFZMR3MyU2V3SGEzUllIZjcrSHJzN2dQYWxtV1JS?= =?utf-8?B?Y2Y3T0FDSGRoMGYyYnZaT2l0TWlTYWRYWGZaSkNTZHNjWHBodkZqMlBrM1RV?= =?utf-8?B?TDF4ZmNMeXVmM1dncDZNMTRTUjczbHdyWlFaeC9CS1BiS1AvbVFvbkU3OFlU?= =?utf-8?B?Y2NwOFEvc1ZKaFh4NHluN0Q0eW5WNU4zYW5CODF4K2I1cW5XcUZKdUJ6Zm9a?= =?utf-8?B?MTJ0dnh0eHlneVVjM1N0b3Z5Um53SE5JbFFLMDlsMXNSK0xLR0hiRVZWRG9R?= =?utf-8?B?eW9xYS92bWRiQTBNQk9WRTN4RDZDZUs3R3RDdnNzOVhrOVF6Z3Uydjc5MkVw?= =?utf-8?B?OHpkTUd1dWk0UGVqdTJ4TFNlaTh2QlM0VTZDRXZTczJ0NVRPSXpYUlVHQVQw?= =?utf-8?B?RVRmdWR0TjMrZ0JGa2c1TkxENUYrTGlKL2lBYzUvQ0E5eGg5K2hySWIyaUJv?= =?utf-8?B?Qi9CZGlNVlUwbEpnTzE2dC8xZVJDcTlUSlJ1emlXeWJZZm5pa0F6RkFCSHdk?= =?utf-8?B?UWZRbUc1VStYVlIwWlV0WCtva0hDaFgxU2srVTlMMEhaejkxaThnNzFyUDZ1?= =?utf-8?B?YmNBRVhqeWJ1UmZlZDF0Q0dLcmZ1ckZUSGxITU5JczVkaEJvTExjTG8rdGpr?= =?utf-8?B?RWVpNzg0NVZRbUlOWUM3Z1FEVU9UeUdkcU1JbGpKVXVQWUxzMTlab2RrekNE?= =?utf-8?B?bVE5NEhyWUhiVFhMeDdzYXdndjFjOXV6UDduN0htSTdzejNlUmVoMkVjemVt?= =?utf-8?B?dG9yOGd5TXB3YXVwZy9vVnlRc3FrU2tlc2xFS1lETlFSM2UreE1IN1BJanNw?= =?utf-8?B?VlJpdjEyclA4NzkxMG54SGlic3RPNnNjYTlkY3lIQkdBalNDTzJjcGp5clVB?= =?utf-8?B?WW9vZE53ZEVrV1RCSHB5VEh5bFA0bWt1N1pqRHNqZGZMYXk1R2RpemRDUzBQ?= =?utf-8?B?dGN2OE81TmJFS094UFhVNUwzNExEVjJ5T3dpN1RIZ1YwbzU0UHB6K2EyQ2ty?= =?utf-8?B?aGM3SlhlbVFkWjlJK0hBK1RJbXZYZFdSb0VpZHdVL1dVTHA2U1BaWWRqTHVh?= =?utf-8?B?S3dSQVhCdzVyVHI0Z1ZBelRwc0N0cFdUeDAvdmZVNVNnUzQxbXJGSGUwU2VL?= =?utf-8?B?SGk3Rmg3bDZabHdmQUIzZG5nS290VFRPa2NaOTZBUnBUQnhUTm5IekRBa0s1?= =?utf-8?B?UjdWTVp5NzVoVHp5WkRRbFFod2UwQ2pidWVmeDlMNnhIaXp6MUV4RjV0RUpu?= =?utf-8?B?anpjZStNUnY5Mm45L1kzK1VhWjlDRDZwNFhsRFM1MzVyRDBMaTA5azljR2pl?= =?utf-8?B?ZnVPWncwNlpLWVYrY0RXLyt3bTdzMXFsditlaU54MWQ4TTV0NFZXcFlvbUtS?= =?utf-8?B?eXlnMmd4T0h6ZFNDemRSWkdrNEs5aDl0UTd0ajZSRGhDM1g0SEVWK1Vwck41?= =?utf-8?B?V0sxbVNVTzNEcUZlMkMvemRVWXVPeEYyT2FaNUNEV0N5d0kxeXl4RUhtaFJv?= =?utf-8?B?ZHFWUWUvdndqNUZCRTB3MFN2UDRKNVZWRm5JYmVXQ3JFcy9ubXFtbEV0ZmFj?= =?utf-8?B?UnUvTXpFQmF5azRmOU13VXpJYjFsbUYrT0ZueU4zQnQrVEF4NkF0VmxPM1Vl?= =?utf-8?B?MjlFL0EwZXlMWC82MXpxOXJTYmh2TlBMblhkS3YrWWJmYlVIRm1uVTUycENM?= =?utf-8?Q?MhHx5PRV2Ie3CigAGX/htXtuDpSRlnEYy0aMnnF?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9fd0e688-95b1-4069-b8b3-08d981ad4e17 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 11:52:39.1060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mBlM3JyHzD6eIoPmLPPAJDkXQEOyxtCt+i7ZAszLJGrlyBLhXyqA1zSwpnUMKzoHNcu2UXPXQmGttSGx3oiIEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4872 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: group constant definitions in Doxygen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2021 5:35 PM, Kevin Traynor wrote: > On 30/08/2021 11:42, Thomas Monjalon wrote: >> A lot of flags are parts of a group but are documented alone. >> The Doxygen syntax @{ and @} for grouping is used >> to make flags appear together and have a common description. >> >> Some Rx/Tx offload flags and RSS definitions are not grouped >> because they need to be all properly documented first. >> >> Signed-off-by: Thomas Monjalon >> --- >>   lib/ethdev/rte_ethdev.h | 71 ++++++++++++++++++++++++++++------------- >>   1 file changed, 48 insertions(+), 23 deletions(-) > > lgtm, this is a nice enhancement when reading the api guide. > > Acked-by: Kevin Traynor > Converting to explicit acks: Acked-by: Ferruh Yigit Acked-by: Andrew Rybchenko Applied to dpdk-next-net/main, thanks.