From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <andy@warmcat.com>
Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82])
by dpdk.org (Postfix) with ESMTP id 08B3D1CBF6;
Sat, 12 May 2018 03:39:50 +0200 (CEST)
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
References: <152600304856.53146.9681482138854493833.stgit@localhost.localdomain>
<152600320633.53146.1883908043976158624.stgit@localhost.localdomain>
<E115CCD9D858EF4F90C690B0DCB4D8976CD08DBE@IRSMSX108.ger.corp.intel.com>
From: Andy Green <andy@warmcat.com>
Message-ID: <ffd16a01-a9ad-c7e0-5694-51775125af44@warmcat.com>
Date: Sat, 12 May 2018 09:39:38 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.7.0
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CD08DBE@IRSMSX108.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 18/18] app/test-bbdev: strcpy ok for
allocated string
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 12 May 2018 01:39:51 -0000
On 05/11/2018 09:02 PM, De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
>> Sent: Friday, May 11, 2018 2:47 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v4 18/18] app/test-bbdev: strcpy ok for allocated
>> string
>>
>> Signed-off-by: Andy Green <andy@warmcat.com>
>> ---
>> app/test-bbdev/test_bbdev_vector.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-
>> bbdev/test_bbdev_vector.c
>> index c574f2135..4a3ddcffe 100644
>> --- a/app/test-bbdev/test_bbdev_vector.c
>> +++ b/app/test-bbdev/test_bbdev_vector.c
>> @@ -914,7 +914,8 @@ test_bbdev_vector_read(const char *filename,
>> }
>>
>> entry = entry_extended;
>> - strncat(entry, line, strlen(line));
>> + /* entry has been allocated accordingly */
>> + strcpy(&entry[strlen(entry)], line);
>
> If memset is removed in the previous patch, then we'll need to use strlcpy
> here, to ensure NULL termination.
No... the destination has been allocated dynamically so there is no case
where the source length can exceed the destination.
I think for that reason it's OK to remove the memset() here, because for
the same reason it will always exactly fill the dynamically sized string
anyway.
-Andy
> Missing fixes line and CC stable:
>
> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
> Cc: stable@dpdk.org
>