From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15A5841D41; Wed, 22 Feb 2023 18:55:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 064A4430B1; Wed, 22 Feb 2023 18:55:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C41784309C for ; Wed, 22 Feb 2023 18:55:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677088555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g09lWaDXRjDSsrArAuKg+xM7EUuOiDq3U7qICHKMVf8=; b=MUfq7u20+mbaMVx4p75gB++9c5tSN6xZ+tfPccuAhX8wZA8oVQhYhiGlrQRLCs13FKj8Lz T2U6sy3rjmMZ/TIRa8zklrfx8gT1FWVPdhJyf74Zsv3E6Jyb0hdqlNC2DotOOlBpfXhux7 QQMu8ZrKs/NLESniyzMEoM0DpbNpkW4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-157-T_thcYP8O6afMhn4ENLYxA-1; Wed, 22 Feb 2023 12:55:52 -0500 X-MC-Unique: T_thcYP8O6afMhn4ENLYxA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B8613857D07; Wed, 22 Feb 2023 17:55:51 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52E5A2166B29; Wed, 22 Feb 2023 17:55:50 +0000 (UTC) Message-ID: Date: Wed, 22 Feb 2023 18:55:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 3/3] baseband/acc: add check for empty queue To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com References: <20230222164043.170909-1-hernan.vargas@intel.com> <20230222164043.170909-4-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230222164043.170909-4-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/22/23 17:40, Hernan Vargas wrote: > Add optimization to return early if there are no available descriptors > in ring to dequeue. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index c242f7737a..9941754aa0 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -4106,6 +4106,9 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, > int ret, cbm; > struct rte_bbdev_enc_op *op; > > + if (avail == 0) > + return 0; > + > op = acc_op_tail(q, 0); > if (unlikely(ops == NULL || op == NULL)) > return 0; Reviewed-by: Maxime Coquelin Thanks, Maxime