From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B11AA0C41; Wed, 6 Oct 2021 11:42:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B8554141A; Wed, 6 Oct 2021 11:42:25 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E3371413D0 for ; Wed, 6 Oct 2021 11:42:23 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="212893840" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="212893840" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 02:42:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="439840512" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 06 Oct 2021 02:42:23 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 02:42:22 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 02:42:22 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 6 Oct 2021 02:42:22 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 6 Oct 2021 02:42:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eY2L3Lj4wVJIS1li6cku7kErV+pihXPZTAOoVOBa4lZusQxixVhz5C4RzVhVQ1bWtfBupCLgjhU3pv/VVseYJV7qMArRCDWalLncnvdUIP9Bxm0l0SsZLUBuYXTpOuwfCBXWPr7B65HWoN208dYN0p+P24EEL3XEdHZ7fwOG1F8dzZLl4mkwFXXyeKPvzupeSTISSpFB7XbMh4WMETjU8iq+QRsvw3Sk+S81jS36FKZ2sgwPFyJejf7KBU6c2DA/Wkcssq/kt5ALDJ7lykPqC+rKojAg3rEByuh3eAYjtLXZPj1evCDH0ccCMnLHpfKLXs30qW0y+cQb/864onNK1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X2MI1IVkPZkGPiFdW2D93iUI3BOk+fD6s/o1AkOy9NA=; b=K3378+AXSjL6TRliKx6SEX7KF6EQ1IkCXZTyrLGUq5VoMs8dIH5GXK4Z8+hxk+dO2iBU1e6VwiCUixlIP8LrvHtjvMaJhJPjqqncwnd2yMBj6YcxVbaGxkNWFeIVAXYGmDwjKmqTY9JRMHsJlVld2skrei2myE7WaIYkVkcD0G0Q6v9sfbWn8k4oTajxcm9Vj6TjufA+bs82UAjKkLRfXJfJ6m78KP1jnKP6F2IxKAnmvMMEo/QXXJpAAwxa+C75Ud5BUsFFG3jaTwr1MzZmEQfDxQcm2LExqfR7p/7ZUMfnPwlTNugbvL6/KPGSkngIHqq9ORCu6MbqtBq16BE3ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X2MI1IVkPZkGPiFdW2D93iUI3BOk+fD6s/o1AkOy9NA=; b=s5GcYiO7x2+kDWJ88JMYy6AIbX9vVJR0+y4v8rbwItbAXQxqt5NOavoQmoM73qL9F+L3RjeQD80XNSnOUhdXapdI/prieZJIDNSUqluZOEyQNg9cWNZ73vNzvhkfKPdDKDj3p2Dk0E7m79be0nRKvPP2IqsJRjers60A3pSFkY0= Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5141.namprd11.prod.outlook.com (2603:10b6:510:3c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 6 Oct 2021 09:42:20 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Wed, 6 Oct 2021 09:42:20 +0000 Message-ID: Date: Wed, 6 Oct 2021 10:42:14 +0100 Content-Language: en-US To: Stephen Hemminger , Tudor Cornea CC: , , , , References: <1632924497-60394-1-git-send-email-tudor.cornea@gmail.com> <1633077301-68561-1-git-send-email-tudor.cornea@gmail.com> <20211001080225.442806c4@hermes.local> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211001080225.442806c4@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0052.eurprd03.prod.outlook.com (2603:10a6:4:54::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0052.eurprd03.prod.outlook.com (2603:10a6:4:54::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Wed, 6 Oct 2021 09:42:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf9aa09c-91c9-4afc-9d73-08d988ad9796 X-MS-TrafficTypeDiagnostic: PH0PR11MB5141: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wTRK/RgqLBClr6SIzjVjLRN7+RWXaF9Cd+WeOVl1wHOxkv6pjPAQo0zvBYVKe9O4GaQCZAUh/cTzKyFQIDqTDG303Zx8PMGZjQoPNSlkOobLd7AEN0AB6XGIYLne7wd1+qTK6x9VDWSIngvfgMpPJ88asNxSWFy85Zj5I5yNyuicLQW9OD9TPgbAkYTlQpA04okKPQvcYXYTb4oW8hDpH5C7WrBEY7Wvn4GxLO/HSSOSu5W4h2PQTYjBchI3J4BFkQf7Dfo8B2ziIXrf0apPvmxyeNKfSqj7uTAN/9AUH9Yh5zluhxQhUpeg91nIhmwRO3T0wgdK1tE/FRGb+kpDsUPwByNeWnZqad+tsAuzKKJCFjzBlOmr7DZ0/5vFAz0+9dZ5y+pI+UMiBN+qmpI1IMwKaPXXG1uYv7LA+NFmJWvbRJlTq7ONSWW2Fv+KLMjkQ8eqN8lQISm8lcFfuixIEmFHwHR4gZZMgrvnspr/ENPxKV7hrvGh7wmzKKNVATzgd//M4TFAANCcq+sB2O+DVq0YNKWA3bOa63RN7AczlpRdwpLQUXjjcqOpC+g16qUvFAC08zkRQqf5WjcgE12Z9sb/qZ2gaM8lGUy/Ff9QzPKcoBixwb9K+//Qo4en28n630dOIUT96aetnQqS0flL68cRGlRA8on5Yr7mzfErtEQcUM9ozwNTIV5QluLhpcEGRw52DvUnEC6W22fwwNLscSpkAV7pW646Foi6wS+vg76fSQ/PGEVXXDrwSbWgrATMuZ5A80z9UutPnuoKA3I5CaVgtPVYxZUGobsVtQNBpUo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6666004)(44832011)(26005)(31696002)(966005)(8676002)(186003)(2616005)(956004)(4326008)(6486002)(38100700002)(66946007)(83380400001)(16576012)(36756003)(53546011)(316002)(66556008)(66476007)(110136005)(86362001)(5660300002)(508600001)(8936002)(31686004)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWk1TWQ4SzNkSHR5a1Bna2ZTMWdaQTRvNW14VnhHd2YxRHJZemtmUWFGdEc3?= =?utf-8?B?dlFYaCszcGM5TjRsM0ZSUGlXeG42dUdDbWV2Vkk5RUpXS2MrQzR2STBGUHFQ?= =?utf-8?B?M2NOd1YrU25XSmVlWDcxR2JZdVZuUkVxcnU5RXZPcFE4MVFQYlZtb0l4a2lv?= =?utf-8?B?c0FJOE4wa0REaUhyaFZWVElOUlJ3eEVMaVlTUGtPQ1lRaStxRHFrS0l0ZU9i?= =?utf-8?B?WDRyNGdQdW9XS3JyMERvMUNGMkdZcjNCUW81eStjYzF4UEdhdGUwbmplT0w4?= =?utf-8?B?anVDVkdFMWZBbU9SZW93L3RLTmFQMHZ2VWRSbVB3aFFxVGxUcUJHalhWWlha?= =?utf-8?B?YllBdWhiVWMrajdibW5iWWVJSmlGbVJOd0ZMemsvS3lJdFpMNnVoN2tSbzFh?= =?utf-8?B?aXpRa1dSSUNLS05TVG9tL01WMUVpUU5vTWRuamVGdkU3Q3preENkOHNSd2Zs?= =?utf-8?B?TU9HTUZCUWd4azVIdDR6QzIrQlQrVzRvL0JIUzdxekxIRldOSEhrQUI0WFFF?= =?utf-8?B?Sjh6UGJiMlJhNUYvTTVnYmlNNEdSRVpZN3l6bHpGMnVRR241QmZqeFc5bS9u?= =?utf-8?B?TElXUXhENmdmN0dLcEhyaWR5VFQwbGYxcGs0MHMrVnVWeW1SeWhoVGd0UlRB?= =?utf-8?B?VlFTUWhxaEdoQXp1S3NTMUpBNVhLSTlmQVhBcFF6czl5SWJRREN6bDYxU21C?= =?utf-8?B?OFBQOU9Rd092UTNxeWRIQUN4UDI3em15L2lYaFV1RzRYdGFwWjl6WnNjVEY1?= =?utf-8?B?U0w1Tk45b04wYnpDd1hkTVBpalJXQjlZUVhFRkcvTmE0STh5YVlkOHdlR0sr?= =?utf-8?B?NFY1Z2FYek1BNzJHaDNRMkxQTnBNVDhxbE43REVZaGFXWFNQaEQzQUFTczc0?= =?utf-8?B?cmo5bVUxUFFIR3RGem1DdWVWc1pFVWIxSEpoRHBUcEtZSXluWU1KdEdKNlpO?= =?utf-8?B?WGd6UHBwTjN5UVdXMkRYb1pFNndHTkZpdUtoVWlNclcvS1BnWWh2Sk9WNEpo?= =?utf-8?B?eGZnMHF1blZ3OGpkc0E3dDR6NWVQWGQ1SDQrMnRIMGZJRkwxNzNGa3U5VHB1?= =?utf-8?B?LzVaNzduWnE2YllhTEFMaGVYUFc2Tmtsejhhd3FvTGt6SEdQZE9DN2ZDRWN5?= =?utf-8?B?YW42d2RVSmh3MHFrcVpRRHIra0Q4VTByV2JudXVQVWZoOW4yRHZaTEx0WHc3?= =?utf-8?B?Tkk2Q3VkdGwvRTVJNnFiWDhraSs3ZmExMGN2bWN3c0cweFo2MWs5eGhaalFz?= =?utf-8?B?eFRDWkZDZGhCaDZ2OXcrNThlWjF5T1RSRjB2eFVFTkJYUVNtMmpCSERvWGRm?= =?utf-8?B?Tnd6enpiSnExbnJsaFFyWkxlci93ekM4MHRyV1IrRHFaYllhOHRCRFprL1dJ?= =?utf-8?B?cWVsTndRT2d2dXR4VnVTNmkzQy9mb2RQU2xxenZRNGV3Ky9QVE1oc2tDNGlt?= =?utf-8?B?eDBPMlRSVjg3YWJkSFNac0c1SE1YQlFMa0ttc1JzUWV1b083YnExa0toa1JC?= =?utf-8?B?VEhyQTZLM2F6RXl1MnlOcCtXbnJlQ0tXMmNRQWQvclBEQWpmbmkvZTU5c01j?= =?utf-8?B?cUl1OUoxb0l1VlFPZXNOZU93YXpCTzE1c1hIaDV0aisxQ1JZVW9oK2I1TzBD?= =?utf-8?B?ZngwSGJqWW9pUkJTcFZubUNOU2lINnZjN3NVSndObEo1Wk9CQ0luaHEwZ3ZQ?= =?utf-8?B?R1J2ZEtTNzhVUC8wQzN1WUdZVEUxc1dLN2VFWmo5TGNrNFdwMk9Xa2Rpc0Z2?= =?utf-8?Q?Jld1kw2XJ/4a7pT0feuSDdzdpKj2N6MLvI6osqD?= X-MS-Exchange-CrossTenant-Network-Message-Id: bf9aa09c-91c9-4afc-9d73-08d988ad9796 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2021 09:42:20.6413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RSwlAwsbl8lzVQepy702cLajrh5AeNlUesIoNMrzAmqZsFBWJhf7srnb0KhSk33Cn8WIL0Vbd9HZAEMMHlivZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5141 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5] net/af_packet: reinsert the stripped vlan tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/1/2021 4:02 PM, Stephen Hemminger wrote: > On Fri, 1 Oct 2021 11:35:01 +0300 > Tudor Cornea wrote: > >> The af_packet pmd driver binds to a raw socket and allows >> sending and receiving of packets through the kernel. >> >> Since commit [1], the kernel strips the vlan tags early in >> __netif_receive_skb_core(), so we receive untagged packets while >> running with the af_packet pmd. >> >> Luckily for us, the skb vlan-related fields are still populated from the >> stripped vlan tags, so we end up having all the information >> that we need in the mbuf. >> >> Having the pmd driver support DEV_RX_OFFLOAD_VLAN_STRIP allows the >> application to control the desired vlan stripping behavior, >> until we have a way to describe offloads that can't be disabled by >> pmd drivers. >> >> This patch will cause a change in the default way that the af_packet >> pmd treats received vlan-tagged frames. While previously, the >> application was required to check the PKT_RX_VLAN_STRIPPED flag, after >> this patch, the pmd will re-insert the vlan tag transparently to the >> user, unless the DEV_RX_OFFLOAD_VLAN_STRIP is enabled in >> rxmode.offloads. >> >> I've attempted a preliminary benchmark to understand if the change could >> cause a sizable performance hit. >> >> Setup: >> Two virtual machines running on top of an ESXi hypervisor >> >> Tx: DPDK app (running on top of vmxnet3 PMD) >> Rx: af_packet (running on top of a kernel vmxnet3 interface) >> Packet size :68 (packet contains a vlan tag) >> >> Rates: >> Tx - 1.419 Mpps >> Rx (without vlan insertion) - 1227636 pps >> Rx (with vlan insertion) - 1220081 pps >> >> At a first glance, we don't seem to have a large degradation in terms >> of packet rate. >> >> [1] https://github.com/torvalds/linux/commit/bcc6d47903612c3861201cc3a866fb604f26b8b2 >> >> Signed-off-by: Tudor Cornea > > > Acked-by: Stephen Hemminger > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. Release notes slightly updated, to simplify the sentences, while merging.