Re: [dpdk-dev] [PATCH v4 16/19] net/ena: make ethdev references SMP safe

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 5/11/2021 7:45 AM, Michal Krawczyk wrote:
> From: Stanislaw Kardach <kda@semihalf.com>
> 
> rte_pci_device and rte_eth_dev are process-local structures. Therefore
> ena_adapter::pdev and ena_adapter::rte_dev cannot be used universally.
> Switch this to extracting those structures via rte_eth_devices indexing
> and remove pdev since it's not used outside of init.
> 

Commit log also needs to be updated, since it still mentions "rte_eth_devices
indexing".

Meanwhile adapter::port_id become kind of redundant in this version, perhaps you
may want to remove it.

> Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> Reviewed-by: Michal Krawczyk <mk@semihalf.com>
> Reviewed-by: Igor Chauskin <igorch@amazon.com>
> Reviewed-by: Shay Agroskin <shayagr@amazon.com>
> ---
> v4:
> * Remove access to the "rte_eth_devices" and instead pass rte_eth_dev as an
>   argument to all the primary process callbacks.
> * Fix commit heading style.
> 

<...>