From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83879A0A0E; Tue, 11 May 2021 14:22:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E830A40140; Tue, 11 May 2021 14:22:42 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 05C794003E for ; Tue, 11 May 2021 14:22:40 +0200 (CEST) IronPort-SDR: 1II6eWkeBs4dMki9Hs6FyAqaMDUM1LDxwQwfTYmVvynm68f+l9HtOXz6UT8/1+J+t4LhFT8bAH rPerB4Gy0JtA== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="179020485" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="179020485" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 05:22:39 -0700 IronPort-SDR: XyPHYag5ypdMYPgk/oQsGRqPymCcpq1cFIlGapaBe3MuuNWy5ciarIivVfsUTmFRmOnk9X2pAM jteqVJW6UD3g== X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="537004480" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.45]) ([10.213.224.45]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 05:22:37 -0700 To: Michal Krawczyk Cc: dev@dpdk.org, ndagan@amazon.com, gtzalik@amazon.com, igorch@amazon.com, upstream@semihalf.com, Stanislaw Kardach , Shay Agroskin References: <87e65a42-4ae5-1a81-8f8e-74759fc14999@intel.com> <20210511064554.10656-1-mk@semihalf.com> <20210511064554.10656-17-mk@semihalf.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 11 May 2021 13:22:33 +0100 MIME-Version: 1.0 In-Reply-To: <20210511064554.10656-17-mk@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 16/19] net/ena: make ethdev references SMP safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/11/2021 7:45 AM, Michal Krawczyk wrote: > From: Stanislaw Kardach > > rte_pci_device and rte_eth_dev are process-local structures. Therefore > ena_adapter::pdev and ena_adapter::rte_dev cannot be used universally. > Switch this to extracting those structures via rte_eth_devices indexing > and remove pdev since it's not used outside of init. > Commit log also needs to be updated, since it still mentions "rte_eth_devices indexing". Meanwhile adapter::port_id become kind of redundant in this version, perhaps you may want to remove it. > Signed-off-by: Stanislaw Kardach > Reviewed-by: Michal Krawczyk > Reviewed-by: Igor Chauskin > Reviewed-by: Shay Agroskin > --- > v4: > * Remove access to the "rte_eth_devices" and instead pass rte_eth_dev as an > argument to all the primary process callbacks. > * Fix commit heading style. > <...>