From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.adaptivemobile.com (mx1.adaptivemobile.com [217.173.221.226]) by dpdk.org (Postfix) with ESMTP id 6A5603B5 for ; Tue, 7 Oct 2014 09:55:23 +0200 (CEST) Received: from unknown (HELO Exchange-AMS.adaptivemobile.com) ([10.80.11.15]) by ams-mta-dub-int.adaptivemobile.com with ESMTP; 07 Oct 2014 08:55:27 +0100 Received: from kraus (10.10.9.208) by Exchange-AMS.adaptivemobile.com (10.80.11.15) with Microsoft SMTP Server (TLS) id 14.1.355.2; Tue, 7 Oct 2014 09:02:32 +0100 From: stepan To: Date: Tue, 7 Oct 2014 00:14:04 +0100 User-agent: mu4e 0.9.8.5; emacs 24.3.1 Message-ID: MIME-Version: 1.0 X-Originating-IP: [10.10.9.208] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] [pcap PATCH] pcap: fix build of all-in-one shared library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Oct 2014 07:55:23 -0000 Build of some of the test binaries fails when the following flags are enabled: CONFIG_RTE_LIBRTE_PMD_PCAP=y CONFIG_RTE_BUILD_SHARED_LIB=y CONFIG_RTE_BUILD_COMBINE_LIBS=y The binarieas are missing symbols from libpcap. This patch adds the missing '-lpcap' linker flag into the respective Makefiles. Signed-off-by: stepan --- app/cmdline_test/Makefile | 4 ++++ app/dump_cfg/Makefile | 4 ++++ app/test-acl/Makefile | 4 ++++ app/test/Makefile | 4 ++++ 4 files changed, 16 insertions(+) diff --git a/app/cmdline_test/Makefile b/app/cmdline_test/Makefile index e9eafd2..ce44fd5 100644 --- a/app/cmdline_test/Makefile +++ b/app/cmdline_test/Makefile @@ -47,6 +47,10 @@ SRCS-y += commands.c CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) +LDFLAGS += -lpcap +endif + include $(RTE_SDK)/mk/rte.app.mk endif diff --git a/app/dump_cfg/Makefile b/app/dump_cfg/Makefile index 3257127..513ce59 100644 --- a/app/dump_cfg/Makefile +++ b/app/dump_cfg/Makefile @@ -35,6 +35,10 @@ APP = dump_cfg CFLAGS += $(WERROR_FLAGS) +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) +LDFLAGS += -lpcap +endif + # all source are stored in SRCS-y SRCS-y := main.c diff --git a/app/test-acl/Makefile b/app/test-acl/Makefile index 43dfdcb..ea063fd 100644 --- a/app/test-acl/Makefile +++ b/app/test-acl/Makefile @@ -37,6 +37,10 @@ APP = testacl CFLAGS += $(WERROR_FLAGS) +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) +LDFLAGS += -lpcap +endif + # all source are stored in SRCS-y SRCS-y := main.c diff --git a/app/test/Makefile b/app/test/Makefile index 6af6d76..e456140 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -145,6 +145,10 @@ CFLAGS_test_kni.o += -Wno-deprecated-declarations endif CFLAGS += -D_GNU_SOURCE +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) +LDFLAGS += -lpcap +endif + # this application needs libraries first DEPDIRS-y += lib -- 1.8.4.GIT *****************************************This email and any files transmitted with are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error then please delete it and notify the sender. Do not make a copy or forward it to anyone. This footnote also confirms that this email message has been swept for the presence of computer viruses. Adaptive Mobile Security Ltd, Ferry House, 48 Lower Mount Street, Dublin 2, Ireland Directors: B. Collins, G. Maclachlan (UK), N. Grierson (UK), J. Ennis (UK), D. Summers (UK). Registered in Ireland, Company No. 370343, VAT Reg.No.IE6390343O*****************************************