* [PATCH] eal/arm: include rte_config.h upfront to fix ARM arch header selection
@ 2025-12-02 8:08 luyan
2025-12-05 8:23 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: luyan @ 2025-12-02 8:08 UTC (permalink / raw)
To: maxime.coquelin, chenbox; +Cc: dev, luyan
From: luyan <luyan@cmss.chinamobile.com>
Fix incorrect arch header inclusion on ARM by adding rte_config.h before
architecture judgment.
Signed-off-by: Yan Lu <luyan@cmss.chinamobile.com>
---
lib/eal/arm/include/rte_atomic.h | 2 ++
lib/eal/arm/include/rte_cpuflags.h | 2 ++
lib/eal/arm/include/rte_cycles.h | 2 ++
lib/eal/arm/include/rte_io.h | 2 ++
lib/eal/arm/include/rte_memcpy.h | 2 ++
lib/eal/arm/include/rte_pause.h | 2 ++
lib/eal/arm/include/rte_prefetch.h | 2 ++
7 files changed, 14 insertions(+)
diff --git a/lib/eal/arm/include/rte_atomic.h b/lib/eal/arm/include/rte_atomic.h
index 40e14e56f7..c329b18761 100644
--- a/lib/eal/arm/include/rte_atomic.h
+++ b/lib/eal/arm/include/rte_atomic.h
@@ -5,6 +5,8 @@
#ifndef _RTE_ATOMIC_ARM_H_
#define _RTE_ATOMIC_ARM_H_
+#include <rte_config.h>
+
#ifdef RTE_ARCH_64
#include <rte_atomic_64.h>
#else
diff --git a/lib/eal/arm/include/rte_cpuflags.h b/lib/eal/arm/include/rte_cpuflags.h
index 022e7da55e..3ee840593a 100644
--- a/lib/eal/arm/include/rte_cpuflags.h
+++ b/lib/eal/arm/include/rte_cpuflags.h
@@ -5,6 +5,8 @@
#ifndef _RTE_CPUFLAGS_ARM_H_
#define _RTE_CPUFLAGS_ARM_H_
+#include <rte_config.h>
+
#ifdef RTE_ARCH_64
#include <rte_cpuflags_64.h>
#else
diff --git a/lib/eal/arm/include/rte_cycles.h b/lib/eal/arm/include/rte_cycles.h
index e8ffa894bb..196a947bf8 100644
--- a/lib/eal/arm/include/rte_cycles.h
+++ b/lib/eal/arm/include/rte_cycles.h
@@ -5,6 +5,8 @@
#ifndef _RTE_CYCLES_ARM_H_
#define _RTE_CYCLES_ARM_H_
+#include <rte_config.h>
+
#ifdef RTE_ARCH_64
#include <rte_cycles_64.h>
#else
diff --git a/lib/eal/arm/include/rte_io.h b/lib/eal/arm/include/rte_io.h
index 781774dd72..0d9823e484 100644
--- a/lib/eal/arm/include/rte_io.h
+++ b/lib/eal/arm/include/rte_io.h
@@ -5,6 +5,8 @@
#ifndef _RTE_IO_ARM_H_
#define _RTE_IO_ARM_H_
+#include <rte_config.h>
+
#ifdef RTE_ARCH_64
#include "rte_io_64.h"
#else
diff --git a/lib/eal/arm/include/rte_memcpy.h b/lib/eal/arm/include/rte_memcpy.h
index 47dea9a8cc..095bee3b63 100644
--- a/lib/eal/arm/include/rte_memcpy.h
+++ b/lib/eal/arm/include/rte_memcpy.h
@@ -5,6 +5,8 @@
#ifndef _RTE_MEMCPY_ARM_H_
#define _RTE_MEMCPY_ARM_H_
+#include <rte_config.h>
+
#ifdef RTE_ARCH_64
#include <rte_memcpy_64.h>
#else
diff --git a/lib/eal/arm/include/rte_pause.h b/lib/eal/arm/include/rte_pause.h
index 9c793c8803..3670f4c94b 100644
--- a/lib/eal/arm/include/rte_pause.h
+++ b/lib/eal/arm/include/rte_pause.h
@@ -5,6 +5,8 @@
#ifndef _RTE_PAUSE_ARM_H_
#define _RTE_PAUSE_ARM_H_
+#include <rte_config.h>
+
#ifdef RTE_ARCH_64
#include <rte_pause_64.h>
#else
diff --git a/lib/eal/arm/include/rte_prefetch.h b/lib/eal/arm/include/rte_prefetch.h
index 27870c2a88..1d1367d5e7 100644
--- a/lib/eal/arm/include/rte_prefetch.h
+++ b/lib/eal/arm/include/rte_prefetch.h
@@ -5,6 +5,8 @@
#ifndef _RTE_PREFETCH_ARM_H_
#define _RTE_PREFETCH_ARM_H_
+#include <rte_config.h>
+
#ifdef RTE_ARCH_64
#include <rte_prefetch_64.h>
#else
--
2.45.2.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] eal/arm: include rte_config.h upfront to fix ARM arch header selection
2025-12-02 8:08 [PATCH] eal/arm: include rte_config.h upfront to fix ARM arch header selection luyan
@ 2025-12-05 8:23 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2025-12-05 8:23 UTC (permalink / raw)
To: luyan; +Cc: maxime.coquelin, chenbox, dev, luyan
On Tue, Dec 02, 2025 at 04:08:49PM +0800, luyan wrote:
> From: luyan <luyan@cmss.chinamobile.com>
>
> Fix incorrect arch header inclusion on ARM by adding rte_config.h before
> architecture judgment.
>
> Signed-off-by: Yan Lu <luyan@cmss.chinamobile.com>
> ---
> lib/eal/arm/include/rte_atomic.h | 2 ++
> lib/eal/arm/include/rte_cpuflags.h | 2 ++
> lib/eal/arm/include/rte_cycles.h | 2 ++
> lib/eal/arm/include/rte_io.h | 2 ++
> lib/eal/arm/include/rte_memcpy.h | 2 ++
> lib/eal/arm/include/rte_pause.h | 2 ++
> lib/eal/arm/include/rte_prefetch.h | 2 ++
> 7 files changed, 14 insertions(+)
>
> diff --git a/lib/eal/arm/include/rte_atomic.h b/lib/eal/arm/include/rte_atomic.h
> index 40e14e56f7..c329b18761 100644
> --- a/lib/eal/arm/include/rte_atomic.h
> +++ b/lib/eal/arm/include/rte_atomic.h
> @@ -5,6 +5,8 @@
> #ifndef _RTE_ATOMIC_ARM_H_
> #define _RTE_ATOMIC_ARM_H_
>
> +#include <rte_config.h>
> +
> #ifdef RTE_ARCH_64
> #include <rte_atomic_64.h>
> #else
When building DPDK or building DPDK apps, rte_config.h should already be
included by this point anyway. We pass "-include rte_config.h" as a flag to
the C compiler, meaning it is included first as a header for building each
file. This flag is also included in the pkg-config output, so apps building
against DPDK should get the same behaviour.
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-05 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-02 8:08 [PATCH] eal/arm: include rte_config.h upfront to fix ARM arch header selection luyan
2025-12-05 8:23 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).