DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v2 1/6] bus/dpaa: fix the curly braces mismatch problem
@ 2022-02-07 12:36 Weiguo Li
  2022-02-08 16:24 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Weiguo Li @ 2022-02-07 12:36 UTC (permalink / raw)
  To: dev; +Cc: bruce.richardson, shreyansh.jain

Supplement the missing half of braces for the extern "C" block,
or remove the incomplete guard in internal header.

Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations")
Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton")
Cc: shreyansh.jain@nxp.com

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/bus/dpaa/include/fsl_fman.h | 4 ----
 drivers/bus/dpaa/rte_dpaa_bus.h     | 4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/dpaa/include/fsl_fman.h b/drivers/bus/dpaa/include/fsl_fman.h
index acb344584f..20690f8329 100644
--- a/drivers/bus/dpaa/include/fsl_fman.h
+++ b/drivers/bus/dpaa/include/fsl_fman.h
@@ -9,10 +9,6 @@
 
 #include <rte_compat.h>
 
-#ifdef __cplusplus
-extern "C" {
-#endif
-
 /* Status field in FD is updated on Rx side by FMAN with following information.
  * Refer to field description in FM BG.
  */
diff --git a/drivers/bus/dpaa/rte_dpaa_bus.h b/drivers/bus/dpaa/rte_dpaa_bus.h
index 31a5ea3fca..54bb1436fd 100644
--- a/drivers/bus/dpaa/rte_dpaa_bus.h
+++ b/drivers/bus/dpaa/rte_dpaa_bus.h
@@ -17,6 +17,10 @@
 #include <fsl_bman.h>
 #include <netcfg.h>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /* This sequence number field is used to store event entry index for
  * driver specific usage. For parallel mode queues, invalid
  * index will be set and for atomic mode queues, valid value
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 1/6] bus/dpaa: fix the curly braces mismatch problem
  2022-02-07 12:36 [PATCH v2 1/6] bus/dpaa: fix the curly braces mismatch problem Weiguo Li
@ 2022-02-08 16:24 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2022-02-08 16:24 UTC (permalink / raw)
  To: Weiguo Li; +Cc: dev, bruce.richardson, shreyansh.jain

07/02/2022 13:36, Weiguo Li:
> Supplement the missing half of braces for the extern "C" block,
> or remove the incomplete guard in internal header.
> 
> Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations")
> Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton")
> Cc: shreyansh.jain@nxp.com
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>

Series applied, thanks.

It seems there are more useless C++ include guard in drivers and examples.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-08 16:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 12:36 [PATCH v2 1/6] bus/dpaa: fix the curly braces mismatch problem Weiguo Li
2022-02-08 16:24 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).