回复：Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

回复：Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

[曹文博]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

Hi David,


Thanks for your advice, as you can see this is first time that send the patch :(.

For nic feature/cap, what is the right thing that i need to do ?
Describe on the cover letter or that on the doc/guides/nics/features/rnp.ini.


regards Wenbo



             ----------回复的邮件信息----------
       David Marchand<david.marchand@redhat.com&gt;&nbsp;在 2023-08-01 周二 15:55 写道：

Hello Wenbo,

On Tue, Aug 1, 2023 at 9:21 AM Wenbo Cao <caowenbo@mucse.com&gt; wrote:
&gt;
&gt; *** BLURB HERE ***

I think you hit the "send" button too early, adding a new net driver
deserves a better cover letter :-).
Please provide some high level description of this driver features and
the nic details/capabilities.

Also, don't forget to Cc: net maintainers, like Ferruh and Andrew.


-- 
David Marchand

[-- Attachment #2: Type: text/html, Size: 2949 bytes --]

Re: Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

[David Marchand]

On Tue, Aug 1, 2023 at 10:09 AM 曹文博 <caowenbo@mucse.com> wrote:
> Thanks for your advice, as you can see this is first time that send the patch :(.

No problem, everyone had to learn how to do this in the past.

There is an issue with threading the patches together.
You should read the contributors guide and check your git send-email
configuration.
https://doc.dpdk.org/guides/contributing/patches.html

Especially:
https://doc.dpdk.org/guides/contributing/patches.html#sending-patches

> For nic feature/cap, what is the right thing that i need to do ?
> Describe on the cover letter or that on the doc/guides/nics/features/rnp.ini.

For the cover letter content, git format-patch provided you an empty
0000-XXX file that you must fill with a title and a summary of what
this series does.
In your case here, I am just requesting a description of what this nic
is (like its name and a list of supported hardwares if you have many)
and what the driver added with this series support (like rx / tx,
stats ...).
Maybe Ferruh has more requests, but it is a good start.


-- 
David Marchand