From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DA60A00C2; Thu, 3 Feb 2022 09:26:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 132F14014F; Thu, 3 Feb 2022 09:26:57 +0100 (CET) Received: from out203-205-221-155.mail.qq.com (out203-205-221-155.mail.qq.com [203.205.221.155]) by mails.dpdk.org (Postfix) with ESMTP id F368A40143 for ; Thu, 3 Feb 2022 09:26:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1643876812; bh=syDqsIajMaFqww+W94/ZiODl/8BKInwzkvUxvigPtvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=b/g/mMLlqgbwJHwarjufx0IFrTNmVwSUUZE/pI9dffEoGSsJD2+/rvBCiOHg1il9l +cvsSdnkoLJ0kb27wQkLtSbFyeyWE1SPICzb8GpiIv3ciBfrTs6WFUvnFRNLJgzdFH Ymbwq8m/oSoqW1SWogm22mxG5ZbdBPU7+Vk3QF14= Received: from liwg-ubuntu.lan ([111.193.130.237]) by newxmesmtplogicsvrszc11.qq.com (NewEsmtp) with SMTP id 6A235C7A; Thu, 03 Feb 2022 16:26:34 +0800 X-QQ-mid: xmsmtpt1643876794tzw8xrfry Message-ID: X-QQ-XMAILINFO: ND3CPZxVFFQcwuR9WRD9NxALbU/p3z30py7KOoXrMx1K9TFD1RzkHnH7kOU1gr 9tYw0k6C9d8ZUhUsC+VN+Qg2c+XEw+puvEDNvlIPcEUNRi5t5Kegj3CMunEqE7O9hOknLGd/uQCn 3i0tv8xVBJKzHYcgfa1ZBUFa6zkmUNw1IzVA4mqhbDaGHmgrj0DWKhcLUreGtqIgmnVi4lD4MO94 a98l0BCG4ncGBRtnBT+GwKREPWMOHL3MY9d2DZmuW2ROWxBIeiiUFWV/4xI1n/fqTh0yfAJjAFvp j7C6oRQudQQ7SqeoZI4VIHfxBu1EnQeM04TNr7rcnsE6CFcpZ0DYVmGLrKp91hHuawKyDVFrnLHi lQ7e804DfU0RXpfsgAvR6/JiDhp1qn8/j/5k256AwHSNKXj3hSsv16sPJwY6gkwvL0Peq0G9mUbi Ju/UDEgZcCffB9kef4PjXbmfe0IxGFyBth4EnMb2cCsmDX+3wM509+SievIQ7jZYoKd56oQrkmf6 5YIS5HDC5KA1rJx1gvfBUcWvdsV5YxYiWn2H67aUeYdSX8lwn6iDuLhhb6ztH5HR8REoo17H++H8 lzqO5TyJtWyZ6Oo36JzhwbsAPoz836Dv4atebL3CINhuUpWXSqyooOSd2lo3YynSH/8CcKKje9bk T+lQdpLzBqnKx9/ESYVXrIaAod1e+qm/rE5OICGEH47pkPs4/pESn3VPPWjPfZGIPgwbeDz8FhdA E1Bu9a1RUeWYtKbmnG5R/l5SwxBrPcU6AMcn2IAQNDh5MhRclSsnkLtAihnYr3sdtO1fkFYtxSaX BpyHcyfiIiof3qdFXA2y4J9210eAqL6d4xcWiSjozazHoQHcuSNKZSkZCfXY7NPqbF8fph2ceNBc Spr+bEemP+LXMGAWRKI2SYL/aiO6B/tAG6gPKmzGIyfP0lzpGOyCA= From: Weiguo Li To: thomas@monjalon.net Cc: dev@dpdk.org Subject: RE:[PATCH] net/enic: adjust memory check and use in proper order Date: Thu, 3 Feb 2022 16:26:34 +0800 X-OQ-MSGID: <20220203082634.1873622-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Monjalon, This fix only moves the memcpy after to null check. so the misplaced of memcpy and null check is reordered. I thought maybe it's too trival a fix to add more explanation. Sorry if it makes any confusion. (last mail is garbled in format) -Weiguo > -----Original Message----- > From: "Thomas Monjalon" ; > Date: Wed, Feb 2, 2022 07:50 PM > To: "John Daley (johndale)";"Weiguo Li"; > Cc: "dev";"Ferruh Yigit"; > Subject: Re: [PATCH] net/enic: adjust memory check and use in proper order > > > > Subject: [PATCH] net/enic: adjust memory check and use in proper order > > > > > > Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") > > > > > > Signed-off-by: Weiguo Li > > > > > > Reviewed-by: John Daley > > > > > > Applied to dpdk-next-net/main, thanks. > Please could we have a little of explanation in the commit log? > The title says "adjust [...] and use in proper order" > but I see only a move of the check.