From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8000B4585A; Wed, 11 Sep 2024 17:57:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F1D34029E; Wed, 11 Sep 2024 17:57:10 +0200 (CEST) Received: from out203-205-221-235.mail.qq.com (out203-205-221-235.mail.qq.com [203.205.221.235]) by mails.dpdk.org (Postfix) with UTF8SMTP id B1C6E40267 for ; Wed, 11 Sep 2024 17:57:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1726070220; bh=rxXI8p+6V/8E/OCGydE0XxFmXBpJkV4XFJ8j4GRI+ak=; h=From:To:Cc:Subject:Date; b=eEZy8Zvye2c/m9MUxXfNwjgmgANtDCMAIKgFSo+sAxlYv2j5opZNoMaTqGLFhkG9B XfwTn+ajy0DAg48BqUst0KmKN7xjSkHJeRoqZbyfCE/QN8uU7BUKXq14aGfCg+yAu8 m4ouwBYZZVEjpQRp0wDS8EG8Mym/BEaw6V9OtXtE= Received: from liangyong-System-Product-Name.. ([113.104.214.72]) by newxmesmtplogicsvrszb16-1.qq.com (NewEsmtp) with SMTP id E2FAE8CA; Wed, 11 Sep 2024 23:56:47 +0800 X-QQ-mid: xmsmtpt1726070207t6ceow905 Message-ID: X-QQ-XMAILINFO: N93eMgvKWC5WeBI7YRRfhyX4BjaZCgSmfHENUgBqekhA+rlEYJWdFwqjM3GOCI izVswBY5Z7l0NCmteMh0RAvh4ny3DsRDVUgnh2jOETWfPMFHkpftoz/Y8ocJJiPJTjPfm67E0lOt /sVp8axdFkszwDsmnYz0X1Ik1iTypcHHq/GDoWDr7qX4ZuKyAu2OIwASaUGQqvRf1jClvTQKH3Uu XrZpFejxNKAvROcRH6jvUSTKL5KLKlkizhGhx5BmSiE6hQQ2TYgv5ZNkqJgpi91935eI6FDgl8Fu XQDWu5vRGZxsiuMV3EaVNn6ZVzfD5qGaXGsPu4TPBKWIrFhmKv4M1tLJbT2t+IA/u28O8WrWSrT/ n1PI6t1+hn/b8apHaghGNZwqViH4CTwcXI8Jk8bkaBQLLW0swOE1r1D7Mtowq28AmiYk50KqlTxO 8PoFXz974fo3qJcnKqJGXcyudkcVgfsijTdwDnQPlT1SApe3I/0gOYJbeCevP4yYYHIGv1pi/G3M USJ1aRGhX00vHHquLTP3XcCVTsdqYuMMimLNJjM8nAur+JfsvBDzV8wwm+x8VuonPKjkq+6t+1uP uqR0QJ/pKd39e//+PEHUr7LT1SAq9riXIb55CgR1fqhag7pook/55N7A70YYaJZmRiGrynXqo51q t+oy+VcbFMK07LqGYDkJZNsyJFfJ78EJNBKVbXLsE0d+QRIzxDSBfXbo0T1k5nGEfFDMYgpM4ffZ w2c0vWq9ok12jAGlSl5AnyT8RsTMCUTb/NgZMgJqiRadn3uUb4mZvOc9ZRQufO+FXW+jFjqwLu2y DA55ZENc9B4BUmdjAGoRmshtS+o64jHs2OYej7Aq3sph/ie3vXaEbrxEt+4EshzLjOwTdKueYBAD /QT1yJlFbu4UHcOzeVOT8cLD2vM1TfP72hzD8QJt+9CfIQ6la2PjtaK1ktA5NTo1pc8HDA+L99hw /3r7qO7XsJubDz65ZdQnkHiFXzYucF6OGmWGs7ny6FOvKMvus5bGeCXbleAykv8sJuWl6I8f8faj lFn7fVgIrqd0PSarlx+xioqrZMn3oycG9Fb3RzGg== X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: Yong Liang <1269690261@qq.com> To: dev@dpdk.org Cc: roy.fan.zhang@intel.com Subject: [PATCH] doc: fix crashes in scheduler_multicore due to incorrect variable usage Date: Wed, 11 Sep 2024 23:56:45 +0800 X-OQ-MSGID: <20240911155645.19017-1-1269690261@qq.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The variable `pending_deq_ops` was incorrectly used instead of `pending_enq_ops`. This causes the program to crash when the worker PMD accesses the session Bugzilla ID: 1537 Fixes: 6812b9bf470e ("crypto/scheduler: use unified session") Cc: roy.fan.zhang@intel.com Signed-off-by: Yong Liang <1269690261@qq.com> --- drivers/crypto/scheduler/scheduler_multicore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/scheduler/scheduler_multicore.c b/drivers/crypto/scheduler/scheduler_multicore.c index a21b522f9f..70f8a25b70 100644 --- a/drivers/crypto/scheduler/scheduler_multicore.c +++ b/drivers/crypto/scheduler/scheduler_multicore.c @@ -191,11 +191,11 @@ mc_scheduler_worker(struct rte_cryptodev *dev) worker->qp_id, &enq_ops[pending_enq_ops_idx], pending_enq_ops); - if (processed_ops < pending_deq_ops) + if (processed_ops < pending_enq_ops) scheduler_retrieve_sessions( &enq_ops[pending_enq_ops_idx + processed_ops], - pending_deq_ops - processed_ops); + pending_enq_ops - processed_ops); pending_enq_ops -= processed_ops; pending_enq_ops_idx += processed_ops; inflight_ops += processed_ops; -- 2.43.0