From: Weiguo Li <liwg06@foxmail.com>
To: hemant.agrawal@nxp.com
Cc: shreyansh.jain@nxp.com, dev@dpdk.org
Subject: [PATCH] common/dpaax: fix a memory leak in iterate dir
Date: Sat, 19 Feb 2022 01:32:48 +0800 [thread overview]
Message-ID: <tencent_F278344ED1229874E4BE954602442E62DE09@qq.com> (raw)
Release the memory when error occur.
Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning")
Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
drivers/common/dpaax/dpaa_of.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/common/dpaax/dpaa_of.c b/drivers/common/dpaax/dpaa_of.c
index bb2c8fc66b..a827b42efa 100644
--- a/drivers/common/dpaax/dpaa_of.c
+++ b/drivers/common/dpaax/dpaa_of.c
@@ -126,8 +126,10 @@ iterate_dir(struct dirent **d, int num, struct dt_dir *dt)
d[loop]->d_name);
subdir->parent = dt;
ret = process_dir(subdir->node.node.full_name, subdir);
- if (ret)
+ if (ret) {
+ free(subdir);
return ret;
+ }
list_add_tail(&subdir->node.list, &dt->subdirs);
break;
default:
--
2.25.1
reply other threads:[~2022-02-18 17:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_F278344ED1229874E4BE954602442E62DE09@qq.com \
--to=liwg06@foxmail.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).