From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pepperjo@japf.ch>
Received: from gozo.iway.ch (gozo.iway.ch [212.25.24.36])
 by dpdk.org (Postfix) with ESMTP id C52A71B2FB
 for <dev@dpdk.org>; Tue, 16 Jan 2018 17:09:37 +0100 (CET)
Received: from gozo.iway.ch (localhost [127.0.0.1])
 by localhost (Postfix) with ESMTP id 97E62340E11;
 Tue, 16 Jan 2018 17:09:37 +0100 (CET)
Received: from localhost (localhost [127.0.0.1]) by localhost (ACF/6597.15164);
 Tue, 16 Jan 2018 17:09:37 +0100 (CET)
Received: from switchplus-mail.ch (switchplus-mail.ch [212.25.8.236])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gozo.iway.ch (Postfix) with ESMTPS;
 Tue, 16 Jan 2018 17:09:37 +0100 (CET)
Received: from [195.176.20.45] (account pepperjo@japf.ch)
 by japf.ch (CommuniGate Pro WEBUSER 6.1.18)
 with HTTP id 42312712; Tue, 16 Jan 2018 17:09:37 +0100
From: "Jonas Pfefferle" <pepperjo@japf.ch>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 "Thomas Monjalon" <thomas@monjalon.net>
Cc: dev@dpdk.org
X-Mailer: CommuniGate Pro WebUser v6.1.18
Date: Tue, 16 Jan 2018 17:09:37 +0100
Message-ID: <web-42312716@switchplus-mail.ch>
In-Reply-To: <e1bc83ba-3528-cf4b-7e3a-bdd5f1ce498f@intel.com>
References: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com>
 <5559040.Nhk1psZjz2@xps>
 <45d1aa7c-2ceb-b6df-8e16-83ff1316cba1@intel.com>
 <2075027.JcYejM7RvO@xps> <web-42154786@switchplus-mail.ch>
 <e1bc83ba-3528-cf4b-7e3a-bdd5f1ce498f@intel.com>
MIME-Version: 1.0
Content-Type: text/plain;charset=utf-8; format="flowed"
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2018 16:09:37 -0000


  On Tue, 16 Jan 2018 10:07:51 +0000
  "Burakov, Anatoly" <anatoly.burakov@intel.com> wrote:
> On 15-Jan-18 12:22 PM, Jonas Pfefferle wrote:
>> 
>>   On Sat, 13 Jan 2018 23:49:30 +0100
>>   Thomas Monjalon <thomas@monjalon.net> wrote:
>>> 13/01/2018 13:15, Burakov, Anatoly:
>>>> On 11-Jan-18 11:45 PM, Thomas Monjalon wrote:
>>>> > 07/11/2017 10:50, Jonas Pfefferle1:
>>>> >>> Is there something urgent for 17.11?
>>>> >>> Or can it be refined in 18.02?
>>>> >>
>>>> >> Nothing urgent. We can refine this for 18.02.
>>>> >>
>>>> >>> Anatoly, any thought?
>>>> > > Anatoly, Jonas, how do you want to proceed with this patch?
>>>> >
>>>> I don't see anything to be refined here, it's a simple bug fix - 
>>>>code assumes noiommu mode support is always available, when it might 
>>>>not be the case on older kernels.
>>>
>>> As a bug fix, the title must start with "fix" and a tag "Fixes:"
>>> must be added to help with backport.
>>> At the same time, the explanation of the bug must be added in
>>> the commit log please.
>>>
>>> Thanks
>> 
>> It's not really a bug fix since it does not change the semantic of 
>>the function but just adds nicer error handling.
> 
> Well, as far as i can tell, it *does* change semantics - previously, 
>if noiommu mode file was not found, we returned -1, now we return 0.
> 
> 
> -- 
> Thanks,
> Anatoly

True. I can change it to a bug fix.