test suite reviews and discussions
 help / color / mirror / Atom feed
* [V1] framework/crb: fix bug of generating core list on freebsd platform
@ 2022-04-29  9:09 Jun Dong
  2022-05-05  1:34 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Jun Dong @ 2022-04-29  9:09 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, qingx.sun, junx.dong

On freebsd platform that supporting Hyper threading, if crb.cfg configured 
support pass core 0, the cores list(Hyper threading) need not only skip thread 0,
but also other threads that on core 0.

Signed-off-by: Jun Dong <junx.dong@intel.com>
---
 framework/crb.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/framework/crb.py b/framework/crb.py
index a15d15e9..0dc82005 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -739,10 +739,11 @@ class Crb(object):
             for core in core_elements:
                 threads = [int(x) for x in core.text.split(",")]
                 for thread in threads:
-                    if thread != 0:
-                        self.cores.append(
-                            {"socket": socket_id, "core": core_id, "thread": thread}
-                        )
+                    if self.crb["bypass core0"] and socket_id == 0 and core_id == 0:
+                        continue
+                    self.cores.append(
+                        {"socket": socket_id, "core": core_id, "thread": thread}
+                    )
                 core_id += 1
             socket_id += 1
         self.number_of_cores = len(self.cores)
-- 
2.33.1.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [V1] framework/crb: fix bug of generating core list on freebsd platform
  2022-04-29  9:09 [V1] framework/crb: fix bug of generating core list on freebsd platform Jun Dong
@ 2022-05-05  1:34 ` lijuan.tu
  0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2022-05-05  1:34 UTC (permalink / raw)
  To: dts, Jun Dong; +Cc: lijuan.tu, qingx.sun, junx.dong

On Fri, 29 Apr 2022 17:09:58 +0800, Jun Dong <junx.dong@intel.com> wrote:
> On freebsd platform that supporting Hyper threading, if crb.cfg configured 
> support pass core 0, the cores list(Hyper threading) need not only skip thread 0,
> but also other threads that on core 0.
> 
> Signed-off-by: Jun Dong <junx.dong@intel.com>

Reviewed-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-05  1:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29  9:09 [V1] framework/crb: fix bug of generating core list on freebsd platform Jun Dong
2022-05-05  1:34 ` lijuan.tu

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git