From: Lijuan Tu <lijuan.tu@intel.com>
To: "zhao,meijuan" <meijuanx.zhao@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V2] tests/vf kernel : fix vf wrong action
Date: Sat, 29 Dec 2018 23:31:38 +0800 [thread overview]
Message-ID: <050b794d-ecc6-0de1-1b60-fe12633dd310@intel.com> (raw)
In-Reply-To: <1545380705-41338-1-git-send-email-meijuanx.zhao@intel.com>
Applied, thanks
On 2018年12月21日 16:25, zhao,meijuan wrote:
> for fortville,tcpdump need add -p parameter to disable promisc mode;
> for niantic, same result if has -p parameter or not
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_vf_kernel.py | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
> index a46a07b..a669a6f 100644
> --- a/tests/TestSuite_vf_kernel.py
> +++ b/tests/TestSuite_vf_kernel.py
> @@ -417,15 +417,14 @@ class TestVfKernel(TestCase):
>
> # Send packet from tester to VF MAC with not-matching vlan id, check
> # the packet can't be received at the vlan device
> + # fortville nic need add -p parameter to disable promisc mode
> wrong_vlan = vlan_ids % 4095 + 1
> -
> self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, vm0_vf0_mac,
> - vlan_id='%d' % wrong_vlan) == False, "received wrong vlan packet")
> -
> + vlan_id='%d' % wrong_vlan, param='-p') == False, "received wrong vlan packet")
> # Send packet from tester to VF MAC with matching vlan id, check the packet can be received at the vlan device.
> # check_result = self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, self.vm0_vf0_mac, vlan_id='%d' %vlan_ids)
> check_result = self.verify_vm_tcpdump(
> - self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids)
> + self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids, param='-p')
> self.verify(check_result, "can't received vlan_id=%d packet" % vlan_ids)
>
> # Delete configured vlan device
> @@ -436,12 +435,8 @@ class TestVfKernel(TestCase):
> not in out, "vlan error")
> # behavior is diffrent bettwn niantic and fortville ,because of kernel
> # driver
> - if self.nic.startswith('fortville'):
> - self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
> - vm0_vf0_mac, vlan_id='%d' % vlan_ids) == True, "delete vlan error")
> - else:
> - self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
> - vm0_vf0_mac, vlan_id='%d' % vlan_ids) == False, "delete vlan error")
> + self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
> + vm0_vf0_mac, vlan_id='%d' % vlan_ids, param='-p') == False, "delete vlan error")
> self.dut_testpmd.execute_cmd("vlan set filter off 0")
>
> def test_packet_statistic(self):
prev parent reply other threads:[~2018-12-29 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 8:25 zhao,meijuan
2018-12-29 3:06 ` Zhu, WenhuiX
2018-12-29 15:31 ` Lijuan Tu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=050b794d-ecc6-0de1-1b60-fe12633dd310@intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=meijuanx.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).