From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 3FB264CAB for ; Sat, 29 Dec 2018 08:03:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Dec 2018 23:03:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,412,1539673200"; d="scan'208";a="133775134" Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110]) ([10.67.119.110]) by fmsmga001.fm.intel.com with ESMTP; 28 Dec 2018 23:03:55 -0800 To: "zhao,meijuan" , dts@dpdk.org References: <1545380705-41338-1-git-send-email-meijuanx.zhao@intel.com> From: Lijuan Tu Message-ID: <050b794d-ecc6-0de1-1b60-fe12633dd310@intel.com> Date: Sat, 29 Dec 2018 23:31:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1545380705-41338-1-git-send-email-meijuanx.zhao@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dts] [PATCH V2] tests/vf kernel : fix vf wrong action X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Dec 2018 07:03:57 -0000 Applied, thanks On 2018年12月21日 16:25, zhao,meijuan wrote: > for fortville,tcpdump need add -p parameter to disable promisc mode; > for niantic, same result if has -p parameter or not > > Signed-off-by: zhao,meijuan > --- > tests/TestSuite_vf_kernel.py | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py > index a46a07b..a669a6f 100644 > --- a/tests/TestSuite_vf_kernel.py > +++ b/tests/TestSuite_vf_kernel.py > @@ -417,15 +417,14 @@ class TestVfKernel(TestCase): > > # Send packet from tester to VF MAC with not-matching vlan id, check > # the packet can't be received at the vlan device > + # fortville nic need add -p parameter to disable promisc mode > wrong_vlan = vlan_ids % 4095 + 1 > - > self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, > - vlan_id='%d' % wrong_vlan) == False, "received wrong vlan packet") > - > + vlan_id='%d' % wrong_vlan, param='-p') == False, "received wrong vlan packet") > # Send packet from tester to VF MAC with matching vlan id, check the packet can be received at the vlan device. > # check_result = self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, self.vm0_vf0_mac, vlan_id='%d' %vlan_ids) > check_result = self.verify_vm_tcpdump( > - self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids) > + self.vm0_dut, self.vm0_intf0, vm0_vf0_mac, vlan_id='%d' % vlan_ids, param='-p') > self.verify(check_result, "can't received vlan_id=%d packet" % vlan_ids) > > # Delete configured vlan device > @@ -436,12 +435,8 @@ class TestVfKernel(TestCase): > not in out, "vlan error") > # behavior is diffrent bettwn niantic and fortville ,because of kernel > # driver > - if self.nic.startswith('fortville'): > - self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, > - vm0_vf0_mac, vlan_id='%d' % vlan_ids) == True, "delete vlan error") > - else: > - self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, > - vm0_vf0_mac, vlan_id='%d' % vlan_ids) == False, "delete vlan error") > + self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0, > + vm0_vf0_mac, vlan_id='%d' % vlan_ids, param='-p') == False, "delete vlan error") > self.dut_testpmd.execute_cmd("vlan set filter off 0") > > def test_packet_statistic(self):