From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CDD3310A3 for ; Fri, 24 Aug 2018 09:59:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Aug 2018 00:59:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,281,1531810800"; d="scan'208";a="256872757" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 24 Aug 2018 00:57:07 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 24 Aug 2018 00:57:07 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 24 Aug 2018 00:57:07 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.143]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Fri, 24 Aug 2018 15:57:04 +0800 From: "Lin, Xueqin" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH] tests/dynamic_queue: add dynamic queue test suite Thread-Index: AQHUOFevjckW93PLDkO/hQkoInWMAqTOhxqg Date: Fri, 24 Aug 2018 07:57:05 +0000 Message-ID: <0D300480287911409D9FF92C1FA2A3355B3D924B@SHSMSX104.ccr.corp.intel.com> References: <1533615829-108513-1-git-send-email-xueqin.lin@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E63129BB0@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E63129BB0@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/dynamic_queue: add dynamic queue test suite X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2018 07:59:08 -0000 Thanks Marvin a lot for you review. My comment as below, I will send v2 ver= sion to fix them. Best regards, Xueqin > -----Original Message----- > From: Liu, Yong > Sent: Monday, August 20, 2018 3:31 PM > To: Lin, Xueqin ; dts@dpdk.org > Cc: Lin, Xueqin > Subject: RE: [dts] [PATCH] tests/dynamic_queue: add dynamic queue test > suite >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin > > Sent: Tuesday, August 07, 2018 12:24 PM > > To: dts@dpdk.org > > Cc: Lin, Xueqin > > Subject: [dts] [PATCH] tests/dynamic_queue: add dynamic queue test > > suite > > > > From: "xueqin.lin" > > > > Signed-off-by: Xueqin Lin > > > > --- > > tests/TestSuite_dynamic_queue.py | 180 > > +++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 180 insertions(+) > > create mode 100644 tests/TestSuite_dynamic_queue.py > > > > diff --git a/tests/TestSuite_dynamic_queue.py > > b/tests/TestSuite_dynamic_queue.py > > new file mode 100644 > > index 0000000..880d421 > > --- /dev/null > > +++ b/tests/TestSuite_dynamic_queue.py > > @@ -0,0 +1,180 @@ > > +# > > + > > +import time > > +import re > > +import utils > > +from test_case import TestCase > > +from pmd_output import PmdOutput > > +from settings import get_nic_name > > +from packet import Packet, sniff_packets, load_sniff_packets import > > +random > > + > > + > > +class TestDynamicQueue(TestCase): > > + > > + def set_up_all(self): > > + self.dut_ports =3D self.dut.get_ports(self.nic) > > + self.verify(len(self.dut_ports) >=3D 1, "Insufficient ports") > > + out =3D self.dut.send_expect("cat config/common_base", "]# ", = 10) > > + self.PF_Q_strip =3D 'CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF' > > + pattern =3D "%s=3D(\d*)" % self.PF_Q_strip > > + self.PF_QUEUE =3D self.element_strip(out, pattern) >=20 > We can strip config value by existing API self.dut.get_def_rte_config. Pl= ease > use that one. If use self.dut.get_def_rte_config, return value is None, it is wrong to st= rip the PF queue number. The function call below to return search loop, the out range is wrong. out =3D self.session.send_command("cat config/defconfig_%s | sed '/^#/d' | = sed '/^\s*$/d'" % self.target, 1) >=20 > > + self.used_dut_port =3D self.dut_ports[0] > > + tester_port =3D self.tester.get_local_port(self.used_dut_port) > > + self.tester_intf =3D self.tester.get_interface(tester_port) > > + self.dut_testpmd =3D PmdOutput(self.dut) > > + > > + def set_up(self): > > + self.dut_testpmd.start_testpmd( > > + "Default", "--port-topology=3Dchained --txq=3D%s --rxq=3D%= s" > > + % (self.PF_QUEUE, self.PF_QUEUE)) > > + > > + def element_strip(self, out, pattern): > > + """ > > + Strip and get queue number. > > + """ > > + s =3D re.compile(pattern, re.DOTALL) > > + res =3D s.search(out) > > + if res is None: > > + print utils.RED('Fail to search number.') > > + return None > > + else: > > + result =3D res.group(1) > > + return int(result) > > + > > + def send_packet(self): > > + """ > > + Generate packets and send them to dut > > + """ > > + mac =3D self.dut.get_mac_address(0) > > + for i in range(self.PF_QUEUE * 2): > > + pkt =3D Packet(pkt_type=3D'IP_RAW') > > + pkt.config_layer('ether', {'dst': mac}) > > + pkt.config_layer( > > + 'ipv4', {'dst': '192.168.0.%d' % i, 'src': '191.168.0.= 1'}) > > + pkt.send_pkt(tx_port=3Dself.tester_intf) > > + > > + def rxq_setup_test(self, chgflag=3D0): > > + """ > > + Dynamic to setup rxq and reconfigure ring size at runtime. > > + chgflag: reconfigure ring size flag > > + 1:reconfigure Rx ring size > > + 0:no change on Rx ring size > > + """ > > + queue =3D range(3) >=20 > Queue is just list here, why not just use list() ? Agree, will fix it. >=20 > > + for i in range(3): >=20 > Recommend not use hard-code 3 here, you can define one global variable fo= r > test loop. Agree, will fix it. >=20 > > + queue[i] =3D random.randint(1, self.PF_QUEUE - 1) > > + self.dut_testpmd.execute_cmd('port 0 rxq %d stop' % > > + queue[i]) >=20 > Please add blank line here for different code block. NP, will add it. >=20 > > + self.dut_testpmd.execute_cmd('set fwd rxonly') > > + self.dut_testpmd.execute_cmd('start') > > + self.send_packet() > > + self.dut.get_session_output(timeout=3D10) > > + out =3D self.dut_testpmd.execute_cmd('stop') > > + for i in range(3): > > + self.verify( > > + "Forward Stats for RX Port=3D 0/Queue=3D%2d" % queue[i= ] > > + not in > > out, > > + "Fail to verify rxq stop!") >=20 > Check queue stop by "Forward stats" not shown is not straight-forward. Is > there any other method like check rx stats? Don't find other better method to verify result. But if queue stop, don't h= ave the Rx forward stats on this queue, if queue start, have the forward s= tats. Also check this with dev, he is agree this method.=20 If you have other better idea, pls let me know, thanks. >=20 > > + if chgflag =3D=3D 1: > > + for i in range(3): > > + out =3D self.dut_testpmd.execute_cmd( > > + 'show rxq info 0 %d' % queue[i]) > > + qring_strip =3D 'Number of RXDs: ' > > + pattern =3D "%s([0-9]+)" % qring_strip > > + qringsize =3D self.element_strip(out, pattern) > > + chg_qringsize =3D qringsize % 1024 + 256 >=20 > Xueqin, why first mod 1024 and then add 256? Why not just add 256? If qringsize is max value, add 256 may not set successfully. >=20 > > + self.dut_testpmd.execute_cmd( > > + 'port config 0 rxq %d ring_size %d' > > + % (queue[i], chg_qringsize)) > > + self.dut_testpmd.execute_cmd('port 0 rxq %d setup' % > > queue[i]) > > + out =3D self.dut_testpmd.execute_cmd( > > + 'show rxq info 0 %d' % queue[i]) > > + chk_qringsize =3D self.element_strip(out, pattern) > > + self.verify(chk_qringsize =3D=3D chg_qringsize, > > + "Fail to change ring size at runtime!") > > + for i in range(3): > > + if chgflag =3D=3D 0: > > + self.dut_testpmd.execute_cmd('port 0 rxq %d setup' % > > queue[i]) > > + self.dut_testpmd.execute_cmd('port 0 rxq %d start' % queue= [i]) > > + self.dut_testpmd.execute_cmd('start') > > + self.send_packet() > > + self.dut.get_session_output(timeout=3D10) > > + out =3D self.dut_testpmd.execute_cmd('stop') >=20 >=20 > Please add blank line here, one line comment will be helpful. Okay. >=20 > > + for i in range(3): > > + self.verify("Forward Stats for RX Port=3D 0/Queue=3D%2d" > > + % queue[i] in out, "Fail to setup rxq %d at ru= ntime" > > + % queue[i]) > > + > > + def txq_setup_test(self, chgflag=3D0): > > + """ > > + Dynamic to setup txq and reconfigure ring size at runtime. > > + chgflag: reconfigure ring size flag > > + 1:reconfigure Tx ring size > > + 0:no change on Tx ring size > > + """ > > + for i in range(3): > > + queue =3D random.randint(1, self.PF_QUEUE - 1) > > + out =3D self.dut_testpmd.execute_cmd('show txq info 0 %d' = % queue) > > + qring_strip =3D 'Number of TXDs: ' > > + pattern =3D "%s([0-9]+)" % qring_strip > > + qringsize =3D self.element_strip(out, pattern) > > + self.dut_testpmd.execute_cmd('port 0 txq %d stop' % queue) > > + self.dut_testpmd.execute_cmd('set fwd txonly') > > + self.dut_testpmd.execute_cmd('start') > > + time.sleep(10) > > + out =3D self.dut_testpmd.execute_cmd('stop') > > + tx_num =3D qringsize - 1 > > + self.verify("TX-packets: %d" % tx_num in out, > > + "Fail to stop txq at runtime") > > + if chgflag =3D=3D 1: > > + chg_qringsize =3D qringsize % 1024 + 256 > > + self.dut_testpmd.execute_cmd( > > + 'port config 0 txq %d ring_size %d' > > + % (queue, chg_qringsize)) > > + self.dut_testpmd.execute_cmd('port 0 txq %d setup' % q= ueue) > > + out =3D self.dut_testpmd.execute_cmd( > > + 'show txq info 0 %d' % queue) > > + chk_qringsize =3D self.element_strip(out, pattern) > > + self.verify(chk_qringsize =3D=3D chg_qringsize, > > + "Fail to change ring size at runtime!") > > + if chgflag =3D=3D 0: > > + self.dut_testpmd.execute_cmd('port 0 txq %d setup' % q= ueue) > > + self.dut_testpmd.execute_cmd('port 0 txq %d start' % queue= ) > > + self.dut_testpmd.execute_cmd('start') > > + time.sleep(10) > > + out =3D self.dut_testpmd.execute_cmd('stop') > > + self.verify("TX-packets: %d" % tx_num not in out, > > + "Fail to setup txq at runtime") >=20 > Tx stats should be much larger than tx_num, please check that number. If queue stops, only fwd 255 packets(ringsize is 256) on this queue, other = packets will be dropped. If queue setups and starts, Tx stats on his queue is bigger than 255. ------- Forward Stats for RX Port=3D 0/Queue=3D 2 -> TX Port=3D 0/Queue=3D = 2 ------- RX-packets: 0 TX-packets: 255 TX-dropped: 1778643= 85 >=20 > > + if chgflag =3D=3D 1: > > + chgtx_num =3D chg_qringsize - 1 > > + self.verify("TX-packets: %d" % chgtx_num not in out, > > + "Fail to change txq ring size at > > + runtime") > > + >=20 > Same as previous comment. >=20 > > + def test_rxq_setup(self): > > + """ > > + Dynamic to setup rxq test > > + """ > > + self.rxq_setup_test() > > + > > + def test_rxq_chgring_setup(self): > > + """ > > + Dynamic to setup rxq and change ring size test > > + """ > > + self.rxq_setup_test(chgflag=3D1) > > + > > + def test_txq_setup(self): > > + """ > > + Dynamic to setup txq test > > + """ > > + self.txq_setup_test() > > + > > + def test_txq_chgring_setup(self): > > + """ > > + Dynamic to setup txq and change ring size test > > + """ > > + self.txq_setup_test(chgflag=3D1) > > + > > + def tear_down(self): > > + self.dut_testpmd.quit() > > + > > + def tear_down_all(self): > > + pass > > -- > > 2.7.5