test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Lin, Xueqin" <xueqin.lin@intel.com>
To: "Tu, Lijuan" <lijuan.tu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] test_plans/unit_test_eal: add hash relative unit test	plan
Date: Tue, 25 Dec 2018 05:11:05 +0000	[thread overview]
Message-ID: <0D300480287911409D9FF92C1FA2A3355B464C40@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <8CE3E05A3F976642AAB0F4675D0AD20E0B9E6812@SHSMSX101.ccr.corp.intel.com>

NP, I will check the format, thanks. 

Best regards,
Xueqin

> -----Original Message-----
> From: Tu, Lijuan
> Sent: Tuesday, December 25, 2018 1:04 PM
> To: Lin, Xueqin <xueqin.lin@intel.com>; dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: RE: [dts] [PATCH] test_plans/unit_test_eal: add hash relative unit test
> plan
> 
> Hi Xueqin,
> 
> There are some errors with the format:
> 
> test_plans/unit_tests_eal_test_plan.rst:322: ERROR: Unexpected indentation.
> test_plans/unit_tests_eal_test_plan.rst:370: ERROR: Unexpected indentation.
> test_plans/unit_tests_eal_test_plan.rst:371: WARNING: Block quote ends
> without a blank line; unexpected unindent.
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
> > Sent: Tuesday, December 4, 2018 10:45 AM
> > To: dts@dpdk.org
> > Cc: Lin, Xueqin <xueqin.lin@intel.com>
> > Subject: [dts] [PATCH] test_plans/unit_test_eal: add hash relative
> > unit test plan
> >
> > From: "xueqin.lin" <xueqin.lin@intel.com>
> >
> > Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> >
> > ---
> >  test_plans/unit_tests_eal_test_plan.rst | 64
> > +++++++++++++++++++++++++++++++++
> >  1 file changed, 64 insertions(+)
> >
> > diff --git a/test_plans/unit_tests_eal_test_plan.rst
> > b/test_plans/unit_tests_eal_test_plan.rst
> > index 201fd30..fba30d8 100644
> > --- a/test_plans/unit_tests_eal_test_plan.rst
> > +++ b/test_plans/unit_tests_eal_test_plan.rst
> > @@ -313,3 +313,67 @@ To Be Filled
> >  Link_bonding
> >  ============
> >  To Be Filled
> > +
> > +Hash
> > +====
> > +This does unit function test for hash features:
> > +- Average table utilization when disable extendable table function
> > +- Average table utilization when enable extendable table function,
> > +  check could reach 100% utilization
> > +
> > +Hash_perf
> > +=========
> > +This does the performance test with a single thread, including the
> > +cases with and without extendable table:
> > +- Measure cycles for add, lookup, lookup_bulk, delete
> > +- With/without pre-computed hash values
> > +- For different key lengths
> > +
> > +Hash_functions
> > +==============
> > +This does unit test for hash functions:
> > +- Measure cycles for hashing
> > +- Jhash vs rte_hash_crc
> > +- For different key lenthgs, seeds
> > +
> > +Hash_multiwriter
> > +================
> > +This does the performance and function test of multi-threads case –
> > +multiple writers.
> > +Introduce scalable multi-writer Cuckoo Hash insertion based on a
> > +split cuckoo search and move operation using Intel TSX. It can do
> > +scalable hash insertion with 22 cores with little performance loss
> > +and negligible TSX abortion rate.
> > +
> > +Hash_readwrite
> > +==============
> > +This does the performance and function test of multi-threads case –
> > +multiple reader/writer.
> > +Read-write concurrency support in rte_hash. A new flag value is added
> > +to indicate if read-write concurrency is needed during creation time.
> > +The new concurrency model is based on rte_rwlock. When Intel TSX is
> > +available and the users indicate to use it, the TM version of the
> > +rte_rwlock will be called. Both multi-writer and read-write
> > +concurrency are protected by the rte_rwlock instead of the x86
> > +specific RTM instructions, so the x86 specific header
> > +rte_cuckoo_hash_x86.h is removed and the code is infused into the main .c
> file.
> > +A new rte_hash_count API is proposed to count how many keys are
> > +inserted into the hash table.
> > +
> > +Hash_hash_readwrite_lf
> > +======================
> > +This does the unit tests to check for hash lookup and bulk-lookup
> > +perf with lock-free enabled and with lock-free disabled. Unit tests
> > +performed with readers running in parallel with writers.
> > +Tests include:
> > +- hash lookup on existing keys with:
> > +  - hash add causing NO key-shifts of existing keys in the table
> > +- hash lookup on existing keys likely to be on shift-path with:
> > +  - hash add causing key-shifts of existing keys in the table
> > +- hash lookup on existing keys NOT likely to be on shift-path with:
> > +  - hash add causing key-shifts of existing keys in the table
> > +- hash lookup on non-existing keys with:
> > +  - hash add causing NO key-shifts of existing keys in the table
> > +  - hash add causing key-shifts of existing keys in the table
> > +- hash lookup on keys likely to be on shift-path with:
> > +  - multiple writers causing key-shifts of existing keys in the table
> > --
> > 2.7.5


      reply	other threads:[~2018-12-25  5:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04  2:45 Xueqin Lin
2018-12-25  5:04 ` Tu, Lijuan
2018-12-25  5:11   ` Lin, Xueqin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0D300480287911409D9FF92C1FA2A3355B464C40@SHSMSX104.ccr.corp.intel.com \
    --to=xueqin.lin@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).