test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Lin, Xueqin" <xueqin.lin@intel.com>
To: "20190819110625.73544-9-qi.fu@intel.com"
	<20190819110625.73544-9-qi.fu@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Fu, Qi" <qi.fu@intel.com>
Subject: Re: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to	support nic of ipgre
Date: Mon, 19 Aug 2019 09:41:24 +0000	[thread overview]
Message-ID: <0D300480287911409D9FF92C1FA2A3355B55505A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190819175759.25357-1-qi.fu@intel.com>

Strange for the change, you can try below.

+            self.verify(self.nic.startswith("fortville") or self.nic.startswith("carlsville "), "GRE tunnel packet type only support by Fortville and carlsville")

Best regards,
Xueqin


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of qifu
> Sent: Tuesday, August 20, 2019 1:58 AM
> To: dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>
> Subject: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to
> support nic of ipgre
> 
> Add carlsville to support nic of ipgre.
> Signed-off-by: qifu <qi.fu@intel.com>
> ---
>  tests/TestSuite_ipgre.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> 6f465fa..2a66928 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -63,8 +63,9 @@ class TestIpgre(TestCase):
>          """
>          self.printFlag = self._enable_debug
>          ports = self.dut.get_ports()
> -        self.verify(self.nic.startswith("fortville"),
> -                    "GRE tunnel packet type only support by Fortville")
> +        if self.nic != "carlsville":
> +            self.verify(self.nic.startswith("fortville"),
> +                        "GRE tunnel packet type only support by
> + Fortville and carlsville")
>          self.verify(len(ports) >= 1, "Insufficient ports for testing")
>          valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
>          # start testpmd
> --
> 2.17.1


  reply	other threads:[~2019-08-19  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 17:57 qifu
2019-08-19  9:41 ` Lin, Xueqin [this message]
2019-08-19 10:07   ` Lin, Xueqin
  -- strict thread matches above, loose matches on Subject: below --
2019-08-19 11:06 [dts] [PATCH 08/17] tests/TestSuite_ipgre: " qifu
2019-08-19 18:09 ` [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: " qifu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0D300480287911409D9FF92C1FA2A3355B55505A@SHSMSX104.ccr.corp.intel.com \
    --to=xueqin.lin@intel.com \
    --cc=20190819110625.73544-9-qi.fu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qi.fu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).