Re: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to support nic of ipgre

["Lin, Xueqin" <xueqin.lin@intel.com>]

Sorry, wrong for the verify function, or just simple to list supported nic list. 

self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville"], "GRE tunnel packet type only support by fortville and carlsville")

Best regards,
Xueqin


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lin, Xueqin
> Sent: Monday, August 19, 2019 5:41 PM
> To: 20190819110625.73544-9-qi.fu@intel.com; dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>
> Subject: Re: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to
> support nic of ipgre
> 
> Strange for the change, you can try below.
> 
> +            self.verify(self.nic.startswith("fortville") or
> + self.nic.startswith("carlsville "), "GRE tunnel packet type only
> + support by Fortville and carlsville")
> 
> Best regards,
> Xueqin
> 
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of qifu
> > Sent: Tuesday, August 20, 2019 1:58 AM
> > To: dts@dpdk.org
> > Cc: Fu, Qi <qi.fu@intel.com>
> > Subject: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville
> > to support nic of ipgre
> >
> > Add carlsville to support nic of ipgre.
> > Signed-off-by: qifu <qi.fu@intel.com>
> > ---
> >  tests/TestSuite_ipgre.py | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> > 6f465fa..2a66928 100644
> > --- a/tests/TestSuite_ipgre.py
> > +++ b/tests/TestSuite_ipgre.py
> > @@ -63,8 +63,9 @@ class TestIpgre(TestCase):
> >          """
> >          self.printFlag = self._enable_debug
> >          ports = self.dut.get_ports()
> > -        self.verify(self.nic.startswith("fortville"),
> > -                    "GRE tunnel packet type only support by Fortville")
> > +        if self.nic != "carlsville":
> > +            self.verify(self.nic.startswith("fortville"),
> > +                        "GRE tunnel packet type only support by
> > + Fortville and carlsville")
> >          self.verify(len(ports) >= 1, "Insufficient ports for testing")
> >          valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
> >          # start testpmd
> > --
> > 2.17.1