* Re: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to support nic of ipgre
2019-08-19 17:57 [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to support nic of ipgre qifu
@ 2019-08-19 9:41 ` Lin, Xueqin
2019-08-19 10:07 ` Lin, Xueqin
0 siblings, 1 reply; 4+ messages in thread
From: Lin, Xueqin @ 2019-08-19 9:41 UTC (permalink / raw)
To: 20190819110625.73544-9-qi.fu, dts; +Cc: Fu, Qi
Strange for the change, you can try below.
+ self.verify(self.nic.startswith("fortville") or self.nic.startswith("carlsville "), "GRE tunnel packet type only support by Fortville and carlsville")
Best regards,
Xueqin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of qifu
> Sent: Tuesday, August 20, 2019 1:58 AM
> To: dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>
> Subject: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to
> support nic of ipgre
>
> Add carlsville to support nic of ipgre.
> Signed-off-by: qifu <qi.fu@intel.com>
> ---
> tests/TestSuite_ipgre.py | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> 6f465fa..2a66928 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -63,8 +63,9 @@ class TestIpgre(TestCase):
> """
> self.printFlag = self._enable_debug
> ports = self.dut.get_ports()
> - self.verify(self.nic.startswith("fortville"),
> - "GRE tunnel packet type only support by Fortville")
> + if self.nic != "carlsville":
> + self.verify(self.nic.startswith("fortville"),
> + "GRE tunnel packet type only support by
> + Fortville and carlsville")
> self.verify(len(ports) >= 1, "Insufficient ports for testing")
> valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
> # start testpmd
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to support nic of ipgre
2019-08-19 9:41 ` Lin, Xueqin
@ 2019-08-19 10:07 ` Lin, Xueqin
0 siblings, 0 replies; 4+ messages in thread
From: Lin, Xueqin @ 2019-08-19 10:07 UTC (permalink / raw)
To: Lin, Xueqin, 20190819110625.73544-9-qi.fu, dts; +Cc: Fu, Qi
Sorry, wrong for the verify function, or just simple to list supported nic list.
self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville"], "GRE tunnel packet type only support by fortville and carlsville")
Best regards,
Xueqin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lin, Xueqin
> Sent: Monday, August 19, 2019 5:41 PM
> To: 20190819110625.73544-9-qi.fu@intel.com; dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>
> Subject: Re: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to
> support nic of ipgre
>
> Strange for the change, you can try below.
>
> + self.verify(self.nic.startswith("fortville") or
> + self.nic.startswith("carlsville "), "GRE tunnel packet type only
> + support by Fortville and carlsville")
>
> Best regards,
> Xueqin
>
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of qifu
> > Sent: Tuesday, August 20, 2019 1:58 AM
> > To: dts@dpdk.org
> > Cc: Fu, Qi <qi.fu@intel.com>
> > Subject: [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville
> > to support nic of ipgre
> >
> > Add carlsville to support nic of ipgre.
> > Signed-off-by: qifu <qi.fu@intel.com>
> > ---
> > tests/TestSuite_ipgre.py | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> > 6f465fa..2a66928 100644
> > --- a/tests/TestSuite_ipgre.py
> > +++ b/tests/TestSuite_ipgre.py
> > @@ -63,8 +63,9 @@ class TestIpgre(TestCase):
> > """
> > self.printFlag = self._enable_debug
> > ports = self.dut.get_ports()
> > - self.verify(self.nic.startswith("fortville"),
> > - "GRE tunnel packet type only support by Fortville")
> > + if self.nic != "carlsville":
> > + self.verify(self.nic.startswith("fortville"),
> > + "GRE tunnel packet type only support by
> > + Fortville and carlsville")
> > self.verify(len(ports) >= 1, "Insufficient ports for testing")
> > valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
> > # start testpmd
> > --
> > 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to support nic of ipgre
@ 2019-08-19 17:57 qifu
2019-08-19 9:41 ` Lin, Xueqin
0 siblings, 1 reply; 4+ messages in thread
From: qifu @ 2019-08-19 17:57 UTC (permalink / raw)
To: dts; +Cc: qifu
Add carlsville to support nic of ipgre.
Signed-off-by: qifu <qi.fu@intel.com>
---
tests/TestSuite_ipgre.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index 6f465fa..2a66928 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -63,8 +63,9 @@ class TestIpgre(TestCase):
"""
self.printFlag = self._enable_debug
ports = self.dut.get_ports()
- self.verify(self.nic.startswith("fortville"),
- "GRE tunnel packet type only support by Fortville")
+ if self.nic != "carlsville":
+ self.verify(self.nic.startswith("fortville"),
+ "GRE tunnel packet type only support by Fortville and carlsville")
self.verify(len(ports) >= 1, "Insufficient ports for testing")
valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
# start testpmd
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to support nic of ipgre
2019-08-19 11:06 [dts] [PATCH 08/17] tests/TestSuite_ipgre: " qifu
@ 2019-08-19 18:09 ` qifu
0 siblings, 0 replies; 4+ messages in thread
From: qifu @ 2019-08-19 18:09 UTC (permalink / raw)
To: dts; +Cc: qifu
Add carlsville to support nic of ipgre.
Signed-off-by: qifu <qi.fu@intel.com>
---
tests/TestSuite_ipgre.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index 6f465fa..2a66928 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -63,8 +63,9 @@ class TestIpgre(TestCase):
"""
self.printFlag = self._enable_debug
ports = self.dut.get_ports()
- self.verify(self.nic.startswith("fortville"),
- "GRE tunnel packet type only support by Fortville")
+ if self.nic != "carlsville":
+ self.verify(self.nic.startswith("fortville"),
+ "GRE tunnel packet type only support by Fortville and carlsville")
self.verify(len(ports) >= 1, "Insufficient ports for testing")
valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
# start testpmd
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-19 10:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 17:57 [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: add carlsville to support nic of ipgre qifu
2019-08-19 9:41 ` Lin, Xueqin
2019-08-19 10:07 ` Lin, Xueqin
-- strict thread matches above, loose matches on Subject: below --
2019-08-19 11:06 [dts] [PATCH 08/17] tests/TestSuite_ipgre: " qifu
2019-08-19 18:09 ` [dts] [PATCH V2 08/17]tests/TestSuite_ipgre: " qifu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).