From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83FC8A00C3; Tue, 18 Jan 2022 03:54:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 590C64117A; Tue, 18 Jan 2022 03:54:23 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7F99840140 for ; Tue, 18 Jan 2022 03:54:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642474462; x=1674010462; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hNAMCMlTNBAAhn0rYi1NkQjo//7T6kqC5soLsPOGyIk=; b=ldZAjOSgY1/t1v78rnAw60GJIYfL+YIV4ANq8QKFP2zBiW/QWZJREjj3 rNAqFakqOdxcoxwsrRv0UACaG20X7HZLG2gse7To+ST2sypfbaXKM4v9D Qi95A6ZJEhSai5fd9tJ/i87sYpQPNK93RQDAswGSR2lGhXk4FR9SUVfCo eAUwY5gYEe3m8PGn7cCRWgoUiUMT1ZEWYfKgPSnKjPpqzOD0S9w+HoZcs tdQaIE3Zg52iPRzyTaM1J0hHoRNsrPQFSvjuxTpeFuaVlzvqtfM1AaVDw jhh5s8WIal5YqlIizNQzhVbhXpV7SDDA5o1Eh5p0Ep1n5kTlWADpnvJiE w==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="243549674" X-IronPort-AV: E=Sophos;i="5.88,296,1635231600"; d="scan'208";a="243549674" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2022 18:54:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,296,1635231600"; d="scan'208";a="517600109" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 17 Jan 2022 18:54:21 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 17 Jan 2022 18:54:20 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 10:54:18 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.020; Tue, 18 Jan 2022 10:54:18 +0800 From: "Tu, Lijuan" To: "Sun, QinX" , "dts@dpdk.org" CC: "Fu, Qi" , "Sun, QinX" Subject: RE: [dts] [PATCH V1] tests/cvl_pps: add 4 new cases Thread-Topic: [dts] [PATCH V1] tests/cvl_pps: add 4 new cases Thread-Index: AQHX8u+Phv142zpr/k2yi2guspfSpqxoQNWQ Date: Tue, 18 Jan 2022 02:54:18 +0000 Message-ID: <0cbdb49e8e1e4a6da76dc9b53ebaaba8@intel.com> References: <20211217110746.14318-1-qinx.sun@intel.com> In-Reply-To: <20211217110746.14318-1-qinx.sun@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org > -----Original Message----- > From: Qin Sun > Sent: 2021=1B$BG/=1B(B12=1B$B7n=1B(B17=1B$BF|=1B(B 19:08 > To: dts@dpdk.org > Cc: Fu, Qi ; Sun, QinX > Subject: [dts] [PATCH V1] tests/cvl_pps: add 4 new cases >=20 > add 4 new cases for pps according to test plan >=20 > Signed-off-by: Qin Sun Could you add some description for your core functions: check_register and = check_value. All registers are hard code, so how to compatible to following : when test the onboard NIC of HCC/SNR platform, the timer =3D 1, so all the = register need to add 4 except GLGEN_GPIO_CTL. > +# Copyright(c) 2010-2021 Intel Corporation. All rights reserved. It's the year of 2022, and we don't have copyright of PAST. > + self.verify(actual_value !=3D 0, > + 'check register failed, expected value is no= n-zero, actual value is:{}'.format(actual_value)) The verify failure message is valueless, definitely the actual value is ze= ro, because it is checkout non-zero. > + self.logger.info('check register pass') Also, it is valueless, if target to get stage info, better to use something= like:=20 Check register
: pass > + def tear_down(self): > + self.dut.kill_all() Please use "quit()" in testpmd at first, kill_all should be used as a last = resort.