From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: Ali Alnubani <alialnu@nvidia.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>,
"dpdklab@iol.unh.edu" <dpdklab@iol.unh.edu>
Subject: Re: [dts] [PATCH] tests/nic_single_core_perf: modify accepted_tolerance to percentage
Date: Tue, 23 Mar 2021 08:48:25 +0000 [thread overview]
Message-ID: <0e4279f9e86442ed81df0416e9e19ffd@intel.com> (raw)
In-Reply-To: <MWHPR12MB1472D561EA13F12289833D30DA649@MWHPR12MB1472.namprd12.prod.outlook.com>
> -----Original Message-----
> From: Ali Alnubani <alialnu@nvidia.com>
> Sent: 2021年3月23日 16:44
> To: Tu, Lijuan <lijuan.tu@intel.com>
> Cc: dts@dpdk.org; dpdklab@iol.unh.edu
> Subject: RE: [dts] [PATCH] tests/nic_single_core_perf: modify
> accepted_tolerance to percentage
>
> > -----Original Message-----
> > From: dts <dts-bounces@dpdk.org> On Behalf Of Lijuan Tu
> > Sent: Thursday, March 11, 2021 12:48 PM
> > To: dpdklab@iol.unh.edu
> > Cc: dts@dpdk.org; Lijuan Tu <lijuan.tu@intel.com>
> > Subject: [dts] [PATCH] tests/nic_single_core_perf: modify
> > accepted_tolerance to percentage
> >
> > * accepted_tolerance in conf/nic_single_core_perf.cfg are changed to
> > percentage, e.g.
> > accepted_tolerance = '1%%'
> > if not set, it will be set to 2% by default.
> > * delat in json are chagned to percentage too, e.g.
> > 'delta': '1.5%'
> > * expected_throughput will be forced to 1Mpps for compute delat in
> > percentage
> > * add new conf test_interval in conf/nic_single_core_perf.cfg, which
> > indicates interval of getting throughput statistics in second, e.g.
> > test_interval = 10
> > if not set, it will be set to 5 seconds by default.
> > * collect better statistics , get multiple throughput statistics
> > during the test run, and compute the average as the final results.
> >
> > Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
> > ---
> <snipped>
> > +accepted_tolerance = '1%%'
> <snipped>
> > + diff =
> > + (self.throughput[fwd_config][frame_size][nb_desc] -
> > +
> > self.expected_throughput[fwd_config][frame_size][nb_desc])/ \
> > +
> > self.expected_throughput[fwd_config][frame_size][nb_desc]
>
> The value of `diff` here is still a decimal, and needs to be multiplied by a 100
> before it can be compared to `accepted_tolerance`.
>
> I suggest splitting this patch into multiple ones. One for making the percentage
> change and one for taking the mean for multiple readings since they are
> unrelated changes.
> I also see other unrelated changes not explained in the commit message.
Really appreciate for your review, I will accept your advices.
>
> Thanks,
> Ali
next prev parent reply other threads:[~2021-03-23 8:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:48 Lijuan Tu
2021-03-22 18:13 ` Ali Alnubani
2021-03-23 8:43 ` Ali Alnubani
2021-03-23 8:48 ` Tu, Lijuan [this message]
2021-03-23 14:52 ` David Liu
2021-03-23 17:23 ` [dts] [dpdklab] " Owen Hilyard
2021-03-25 7:28 ` Tu, Lijuan
2021-03-26 3:34 ` Tu, Lijuan
2021-03-30 14:27 ` David Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4279f9e86442ed81df0416e9e19ffd@intel.com \
--to=lijuan.tu@intel.com \
--cc=alialnu@nvidia.com \
--cc=dpdklab@iol.unh.edu \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).