From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBDDBA0562; Tue, 23 Mar 2021 09:48:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95BAC4014F; Tue, 23 Mar 2021 09:48:31 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 695F54014D for ; Tue, 23 Mar 2021 09:48:29 +0100 (CET) IronPort-SDR: zmw4sFshPL66MZt/valwCTpaDco1wT6PjkfLk/uwC6twCCH/h7zIk5pLvUtTSjuW5kuMNZgRkY vkd7atTNeGqw== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="254432532" X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="254432532" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 01:48:28 -0700 IronPort-SDR: ZpHcsy815MFXXJa48GJArwb0FLb1ILJmX/fm0UoxI+IaHiMEIlO6Dv8UB1F29rIfSbpheInflY kMroP7UsXWjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,271,1610438400"; d="scan'208";a="408220632" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 23 Mar 2021 01:48:28 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 01:48:27 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 16:48:25 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Tue, 23 Mar 2021 16:48:25 +0800 From: "Tu, Lijuan" To: Ali Alnubani CC: "dts@dpdk.org" , "dpdklab@iol.unh.edu" Thread-Topic: [dts] [PATCH] tests/nic_single_core_perf: modify accepted_tolerance to percentage Thread-Index: AQHXFiEKutfJMCbnN0ikH/S8sC5joKqQzuwAgACGucA= Date: Tue, 23 Mar 2021 08:48:25 +0000 Message-ID: <0e4279f9e86442ed81df0416e9e19ffd@intel.com> References: <20210311104800.243752-1-lijuan.tu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/nic_single_core_perf: modify accepted_tolerance to percentage X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: Ali Alnubani > Sent: 2021=1B$BG/=1B(B3=1B$B7n=1B(B23=1B$BF|=1B(B 16:44 > To: Tu, Lijuan > Cc: dts@dpdk.org; dpdklab@iol.unh.edu > Subject: RE: [dts] [PATCH] tests/nic_single_core_perf: modify > accepted_tolerance to percentage >=20 > > -----Original Message----- > > From: dts On Behalf Of Lijuan Tu > > Sent: Thursday, March 11, 2021 12:48 PM > > To: dpdklab@iol.unh.edu > > Cc: dts@dpdk.org; Lijuan Tu > > Subject: [dts] [PATCH] tests/nic_single_core_perf: modify > > accepted_tolerance to percentage > > > > * accepted_tolerance in conf/nic_single_core_perf.cfg are changed to > > percentage, e.g. > > accepted_tolerance =3D '1%%' > > if not set, it will be set to 2% by default. > > * delat in json are chagned to percentage too, e.g. > > 'delta': '1.5%' > > * expected_throughput will be forced to 1Mpps for compute delat in > > percentage > > * add new conf test_interval in conf/nic_single_core_perf.cfg, which > > indicates interval of getting throughput statistics in second, e.g. > > test_interval =3D 10 > > if not set, it will be set to 5 seconds by default. > > * collect better statistics , get multiple throughput statistics > > during the test run, and compute the average as the final results. > > > > Signed-off-by: Lijuan Tu > > --- > > > +accepted_tolerance =3D '1%%' > > > + diff =3D > > + (self.throughput[fwd_config][frame_size][nb_desc] - > > + > > self.expected_throughput[fwd_config][frame_size][nb_desc])/ \ > > + > > self.expected_throughput[fwd_config][frame_size][nb_desc] >=20 > The value of `diff` here is still a decimal, and needs to be multiplied b= y a 100 > before it can be compared to `accepted_tolerance`. >=20 > I suggest splitting this patch into multiple ones. One for making the per= centage > change and one for taking the mean for multiple readings since they are > unrelated changes. > I also see other unrelated changes not explained in the commit message. Really appreciate for your review, I will accept your advices. >=20 > Thanks, > Ali