test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Yang, LeweiX" <leweix.yang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Yang, LeweiX" <leweix.yang@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vm_power_manager:restart libvirtd
Date: Mon, 25 Oct 2021 03:34:15 +0000	[thread overview]
Message-ID: <0edd35bf79e048d0bbcfc61d12aa7bae@intel.com> (raw)
In-Reply-To: <20211018190436.12097-1-leweix.yang@intel.com>



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Lewei Yang
> Sent: 2021年10月19日 3:05
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts] [PATCH V1] tests/vm_power_manager:restart libvirtd
> 
> dut needs to create a new vm,but a suite has created a vm before.
> restart libvirtd to make sure new vm can be created
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>
> ---
>  tests/TestSuite_vm_power_manager.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_vm_power_manager.py
> b/tests/TestSuite_vm_power_manager.py
> index f650ba28..455383f7 100644
> --- a/tests/TestSuite_vm_power_manager.py
> +++ b/tests/TestSuite_vm_power_manager.py
> @@ -63,6 +63,7 @@ class TestVmPowerManager(TestCase):
>          self.vcpu_map = []
>          # start vm
>          self.vm_name = "vm0"
> +        self.dut.send_expect("service libvirtd restart", "# ")

It's real a bad idea to restart service. Libvirt should have the cap to create a new vm.

>          self.vm = LibvirtKvm(self.dut, self.vm_name, self.suite_name)
>          channels = [
>              {'path': '/tmp/powermonitor/%s.0' %
> --
> 2.17.1


      reply	other threads:[~2021-10-25  3:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 19:04 Lewei Yang
2021-10-25  3:34 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0edd35bf79e048d0bbcfc61d12aa7bae@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=leweix.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).