test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast with multicast mac
@ 2020-04-06  4:56 Xiao Qimai
  2020-04-06  5:03 ` Xiao, QimaiX
  0 siblings, 1 reply; 3+ messages in thread
From: Xiao Qimai @ 2020-04-06  4:56 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_vhost_pmd_xstats.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vhost_pmd_xstats.py b/tests/TestSuite_vhost_pmd_xstats.py
index ad9e245..9b3b92c 100755
--- a/tests/TestSuite_vhost_pmd_xstats.py
+++ b/tests/TestSuite_vhost_pmd_xstats.py
@@ -182,7 +182,7 @@ class TestVhostPmdXstats(TestCase):
         date_new = date_old + datetime.timedelta(minutes=2)
         while (1):
             date_now = datetime.datetime.now()
-            scope = 'broadcast'
+            scope = 'multicast'
             self.dmac = '01:00:00:33:00:01'
             self.scapy_send_packet(64, self.dmac, 1)
             if date_now >= date_new:
@@ -327,4 +327,4 @@ class TestVhostPmdXstats(TestCase):
         """
         Run after each test suite.
         """
-        pass
\ No newline at end of file
+        pass
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast with multicast mac
  2020-04-06  4:56 [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast with multicast mac Xiao Qimai
@ 2020-04-06  5:03 ` Xiao, QimaiX
  2020-04-08  2:33   ` Wang, Yinan
  0 siblings, 1 reply; 3+ messages in thread
From: Xiao, QimaiX @ 2020-04-06  5:03 UTC (permalink / raw)
  To: dts

Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>

-----Original Message-----
From: Xiao, QimaiX <qimaix.xiao@intel.com> 
Sent: Monday, April 6, 2020 12:57 PM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts][PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast with multicast mac

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_vhost_pmd_xstats.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vhost_pmd_xstats.py b/tests/TestSuite_vhost_pmd_xstats.py
index ad9e245..9b3b92c 100755
--- a/tests/TestSuite_vhost_pmd_xstats.py
+++ b/tests/TestSuite_vhost_pmd_xstats.py
@@ -182,7 +182,7 @@ class TestVhostPmdXstats(TestCase):
         date_new = date_old + datetime.timedelta(minutes=2)
         while (1):
             date_now = datetime.datetime.now()
-            scope = 'broadcast'
+            scope = 'multicast'
             self.dmac = '01:00:00:33:00:01'
             self.scapy_send_packet(64, self.dmac, 1)
             if date_now >= date_new:
@@ -327,4 +327,4 @@ class TestVhostPmdXstats(TestCase):
         """
         Run after each test suite.
         """
-        pass
\ No newline at end of file
+        pass
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast with multicast mac
  2020-04-06  5:03 ` Xiao, QimaiX
@ 2020-04-08  2:33   ` Wang, Yinan
  0 siblings, 0 replies; 3+ messages in thread
From: Wang, Yinan @ 2020-04-08  2:33 UTC (permalink / raw)
  To: Xiao, QimaiX, dts

Hi Qimai,

I sent another patch instead of your patch by changing self.dmac to keep the broadcast test.
Thanks!

BR,
Yinan

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xiao, QimaiX
> Sent: 2020年4月6日 13:03
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast
> with multicast mac
> 
> Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>
> 
> -----Original Message-----
> From: Xiao, QimaiX <qimaix.xiao@intel.com>
> Sent: Monday, April 6, 2020 12:57 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts][PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast
> with multicast mac
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_vhost_pmd_xstats.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vhost_pmd_xstats.py
> b/tests/TestSuite_vhost_pmd_xstats.py
> index ad9e245..9b3b92c 100755
> --- a/tests/TestSuite_vhost_pmd_xstats.py
> +++ b/tests/TestSuite_vhost_pmd_xstats.py
> @@ -182,7 +182,7 @@ class TestVhostPmdXstats(TestCase):
>          date_new = date_old + datetime.timedelta(minutes=2)
>          while (1):
>              date_now = datetime.datetime.now()
> -            scope = 'broadcast'
> +            scope = 'multicast'
>              self.dmac = '01:00:00:33:00:01'
>              self.scapy_send_packet(64, self.dmac, 1)
>              if date_now >= date_new:
> @@ -327,4 +327,4 @@ class TestVhostPmdXstats(TestCase):
>          """
>          Run after each test suite.
>          """
> -        pass
> \ No newline at end of file
> +        pass
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-08  2:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06  4:56 [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: check multicast with multicast mac Xiao Qimai
2020-04-06  5:03 ` Xiao, QimaiX
2020-04-08  2:33   ` Wang, Yinan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).